diff options
| author | Lennart Poettering <lennart@poettering.net> | 2010-08-20 02:26:05 +0200 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2010-08-20 02:31:54 +0200 |
| commit | c4e2ceae941d02de5574becbfd3b4db15de2eda3 (patch) | |
| tree | c0bda809e0b860f5b0f8e66942dd486c17f2e309 /src/dbus-unit.c | |
| parent | d06dacd0020af7e31ff6089deff339b00ed979e3 (diff) | |
dbus: follow standardized fdo PropertiesChanged signal spec
Diffstat (limited to 'src/dbus-unit.c')
| -rw-r--r-- | src/dbus-unit.c | 33 |
1 files changed, 31 insertions, 2 deletions
diff --git a/src/dbus-unit.c b/src/dbus-unit.c index ca4e5f248e..519aa5c3e8 100644 --- a/src/dbus-unit.c +++ b/src/dbus-unit.c @@ -28,6 +28,18 @@ const char bus_unit_interface[] = BUS_UNIT_INTERFACE; +#define INVALIDATING_PROPERTIES \ + "LoadState\0" \ + "ActiveState\0" \ + "SubState\0" \ + "InactiveExitTimestamp\0" \ + "ActiveEnterTimestamp\0" \ + "ActiveExitTimestamp\0" \ + "InactiveEnterTimestamp\0" \ + "Job\0" \ + "NeedDaemonReload\0" \ + "\0" + int bus_unit_append_names(Manager *m, DBusMessageIter *i, const char *property, void *data) { char *t; Iterator j; @@ -470,10 +482,27 @@ void bus_unit_send_change_signal(Unit *u) { goto oom; if (u->meta.sent_dbus_new_signal) { - /* Send a change signal */ + /* Send a properties changed signal. First for the + * specific type, then for the generic unit. The + * clients may rely on this order to get atomic + * behaviour if needed. */ + + if (UNIT_VTABLE(u)->bus_invalidating_properties) { + + if (!(m = bus_properties_changed_new(p, + UNIT_VTABLE(u)->bus_interface, + UNIT_VTABLE(u)->bus_invalidating_properties))) + goto oom; + + if (bus_broadcast(u->meta.manager, m) < 0) + goto oom; - if (!(m = dbus_message_new_signal(p, "org.freedesktop.systemd1.Unit", "Changed"))) + dbus_message_unref(m); + } + + if (!(m = bus_properties_changed_new(p, "org.freedesktop.systemd1.Unit", INVALIDATING_PROPERTIES))) goto oom; + } else { /* Send a new signal */ |