diff options
author | David Herrmann <dh.herrmann@gmail.com> | 2015-06-18 10:18:31 +0200 |
---|---|---|
committer | David Herrmann <dh.herrmann@gmail.com> | 2015-06-18 10:25:08 +0200 |
commit | fd23f9c9a70e1214507641d327da40d1688b74d7 (patch) | |
tree | 632e9e613f58f4c5068ab6105fcb783f25dd3829 /src/import/pull-job.h | |
parent | 575ee5e4f76c28c91828637de17e9a5a0da9523d (diff) |
test: disable test-barrier by default
The test-barrier binary uses real-time alarms and timeouts to test for
races in the thread-barrier implementation. Hence, if your system is under
high load and your scheduler decides to not run test-barrier for
>BASE_TIME, then the tests are likely to fail.
Two options:
1) Increase BASE_TIME. This will make the test take significantly longer
for no real good. Furthermore, it is still not guaranteed that the
task is scheduled.
2) Don't rely on real-time timers, but use explicit synchronization. This
would basically test one barrier implementation with another.. kinda
ironic.. but maybe something worth looking into.
3) Disable test-barrier by default.
This patch chooses option 3) and makes sure test-barrier only runs if you
pass any argument.
Side note:
test-barrier is written in a way that if it fails under load, but
does not on idle systems, then it is very _unlikely_ that the
barrier implementation is the culprit. Hence, it makes little
sense to run it under load, anyway. It will not improve the test
coverage of barrier.c, but rather the coverage of the test itself.
Diffstat (limited to 'src/import/pull-job.h')
0 files changed, 0 insertions, 0 deletions