journald: minor fixes

This primarily contains some minor coding style fixups for 7a24f3bf2fb181243a1957a0cdd54cd919396793 and earlier changes. Specifically:

* Don't log at log levels above LOG_DEBUG from "library" code like journal-file.c

* Don't negate errno values before passing them to log_debug_errno(), as the call can handle this fine anyway

* Cast some calls we knowingly ignore the return values of to (void)

* Don't clobber function call-by-ref return values on failure

* Don't mix function calls and variable declarations in one line

There's also one more relevant change: when failing to enqueue a journal change fs event, we'll run it immediately.

1 files changed, 6 insertions, 5 deletions

diff --git a/src/journal/journald-server.c b/src/journal/journald-server.c
index c3add87ed1..0a85c38e1c 100644
--- a/src/journal/journald-server.c
+++ b/src/journal/journald-server.c
@@ -233,25 +233,26 @@ static int open_journal(
                 JournalFile *template,
                 JournalFile **ret) {
         int r;
+        JournalFile *f;
 
         assert(s);
         assert(fname);
         assert(ret);
 
         if (reliably)
-                r = journal_file_open_reliably(fname, flags, 0640, s->compress, seal, metrics, s->mmap, template, ret);
+                r = journal_file_open_reliably(fname, flags, 0640, s->compress, seal, metrics, s->mmap, template, &f);
         else
-                r = journal_file_open(fname, flags, 0640, s->compress, seal, metrics, s->mmap, template, ret);
-
+                r = journal_file_open(fname, flags, 0640, s->compress, seal, metrics, s->mmap, template, &f);
         if (r < 0)
                 return r;
 
-        r = journal_file_enable_post_change_timer(*ret, s->event, POST_CHANGE_TIMER_INTERVAL_USEC);
+        r = journal_file_enable_post_change_timer(f, s->event, POST_CHANGE_TIMER_INTERVAL_USEC);
         if (r < 0) {
-                *ret = journal_file_close(*ret);
+                journal_file_close(f);
                 return r;
         }
 
+        *ret = f;
         return r;
 }