diff options
| author | Vinay Kulkarni <vskibum@gmail.com> | 2016-04-04 15:13:06 -0700 |
|---|---|---|
| committer | Vinay Kulkarni <kulkarniv@vmware.com> | 2016-04-04 21:06:11 -0700 |
| commit | b7f71444c01a9b4ac6f7072bf4f7d6d8098cb982 (patch) | |
| tree | 8972940ee98fbf6a016c10012e42cd8628d9c609 /src/libsystemd-network | |
| parent | 77384fb0edda2e9d826c1e6786faae607b48e47d (diff) | |
Address code-review items for pull-request #2890
1. Replace strtol with unhexchar, verified with valid and invalid DUID strings.
2. Fix logging to use log_syntax instead of log_error.
3. On error reading DUID, ignore read and preserve previous state.
4. Fix man-pages to use markup, remove options not yet implemented.
5. Remove spurious header line in new files.
Diffstat (limited to 'src/libsystemd-network')
| -rw-r--r-- | src/libsystemd-network/network-internal.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/libsystemd-network/network-internal.c b/src/libsystemd-network/network-internal.c index 0e2d757b2b..99b3a1d01f 100644 --- a/src/libsystemd-network/network-internal.c +++ b/src/libsystemd-network/network-internal.c @@ -355,8 +355,9 @@ int config_parse_iaid(const char *unit, r = safe_atou32(rvalue, &iaid); if (r < 0) { - log_syntax(unit, LOG_ERR, filename, line, 0, "Unable to read IAID: %s", rvalue); - return r; + log_syntax(unit, LOG_ERR, filename, line, r, + "Unable to read IAID, ignoring assignment: %s", rvalue); + return 0; } *((uint32_t *)data) = iaid; |