summaryrefslogtreecommitdiff
path: root/src/libsystemd
diff options
context:
space:
mode:
authorPhilippe De Swert <philippedeswert@gmail.com>2014-09-10 12:20:42 +0300
committerDavid Herrmann <dh.herrmann@gmail.com>2014-09-11 17:29:19 +0200
commit2b347169b9046ff2d735ef23e62a8c74f5151600 (patch)
treeba1f0d423cbd4aed6b868b46f6124ee82eda9d08 /src/libsystemd
parentb67ddc7bbe31cde7f69f9814204d9bb1d4623c47 (diff)
bus: unref buscreds on failure
Actually unref the buscreds when we are not going to return a pointer to them. As when bus_creds_add_more fails we immediately return the error code otherwise and leak the new buscreds. Found with coverity. Fixes: CID#1237761
Diffstat (limited to 'src/libsystemd')
-rw-r--r--src/libsystemd/sd-bus/sd-bus.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/libsystemd/sd-bus/sd-bus.c b/src/libsystemd/sd-bus/sd-bus.c
index 78e91b9654..83b3aa1c3c 100644
--- a/src/libsystemd/sd-bus/sd-bus.c
+++ b/src/libsystemd/sd-bus/sd-bus.c
@@ -3339,8 +3339,10 @@ _public_ int sd_bus_get_peer_creds(sd_bus *bus, uint64_t mask, sd_bus_creds **re
}
r = bus_creds_add_more(c, mask, pid, 0);
- if (r < 0)
+ if (r < 0) {
+ sd_bus_creds_unref(c);
return r;
+ }
*ret = c;
return 0;