diff options
| author | Lennart Poettering <lennart@poettering.net> | 2015-09-04 10:34:47 +0200 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2015-09-04 10:34:47 +0200 |
| commit | 5744f59a3ee883ef3a78214bd5236157acdc35ba (patch) | |
| tree | 4846ffbd7904964bb215eed1900f96c10285e849 /src/login | |
| parent | c7f837628b18b2e531fd36e175ca424c2ed30c9e (diff) | |
logind: treat an empty wall message like a NULL one
Diffstat (limited to 'src/login')
| -rw-r--r-- | src/login/logind-dbus.c | 19 |
1 files changed, 11 insertions, 8 deletions
diff --git a/src/login/logind-dbus.c b/src/login/logind-dbus.c index 5b2b36b9c0..281314f03a 100644 --- a/src/login/logind-dbus.c +++ b/src/login/logind-dbus.c @@ -1339,8 +1339,7 @@ static int bus_manager_log_shutdown( InhibitWhat w, const char *unit_name) { - const char *p; - const char *q; + const char *p, *q; assert(m); assert(unit_name); @@ -1365,8 +1364,8 @@ static int bus_manager_log_shutdown( q = NULL; } - if (m->wall_message) - p = strjoina(p, " (", m->wall_message, ")", NULL); + if (!isempty(m->wall_message)) + p = strjoina(p, " (", m->wall_message, ")"); return log_struct(LOG_NOTICE, LOG_MESSAGE_ID(SD_MESSAGE_SHUTDOWN), @@ -2310,15 +2309,19 @@ static int method_set_wall_message( UID_INVALID, &m->polkit_registry, error); - if (r < 0) return r; if (r == 0) return 1; /* Will call us back */ - r = free_and_strdup(&m->wall_message, wall_message); - if (r < 0) - return log_oom(); + if (isempty(wall_message)) + m->wall_message = mfree(m->wall_message); + else { + r = free_and_strdup(&m->wall_message, wall_message); + if (r < 0) + return log_oom(); + } + m->enable_wall_messages = enable_wall_messages; return sd_bus_reply_method_return(message, NULL); |