summaryrefslogtreecommitdiff
path: root/src/login
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2013-06-27 04:14:27 +0200
committerLennart Poettering <lennart@poettering.net>2013-06-27 04:17:34 +0200
commit4ad490007b70e6ac18d3cb04fa2ed92eba1451fa (patch)
tree20c7aab57b1f2722be1a057a28a6e7c16788c976 /src/login
parentabb26902e424c4142b68ead35676028b12249b77 (diff)
core: general cgroup rework
Replace the very generic cgroup hookup with a much simpler one. With this change only the high-level cgroup settings remain, the ability to set arbitrary cgroup attributes is removed, so is support for adding units to arbitrary cgroup controllers or setting arbitrary paths for them (especially paths that are different for the various controllers). This also introduces a new -.slice root slice, that is the parent of system.slice and friends. This enables easy admin configuration of root-level cgrouo properties. This replaces DeviceDeny= by DevicePolicy=, and implicitly adds in /dev/null, /dev/zero and friends if DeviceAllow= is used (unless this is turned off by DevicePolicy=).
Diffstat (limited to 'src/login')
-rw-r--r--src/login/logind-machine.c2
-rw-r--r--src/login/logind-session.c4
-rw-r--r--src/login/logind-user.c4
3 files changed, 5 insertions, 5 deletions
diff --git a/src/login/logind-machine.c b/src/login/logind-machine.c
index 347e5aa022..0b35a9e2d0 100644
--- a/src/login/logind-machine.c
+++ b/src/login/logind-machine.c
@@ -223,7 +223,7 @@ static int machine_create_one_group(Machine *m, const char *controller, const ch
r = -EINVAL;
if (r < 0) {
- r = cg_create(controller, path, NULL);
+ r = cg_create(controller, path);
if (r < 0)
return r;
}
diff --git a/src/login/logind-session.c b/src/login/logind-session.c
index aba517d1f7..760425329b 100644
--- a/src/login/logind-session.c
+++ b/src/login/logind-session.c
@@ -472,12 +472,12 @@ static int session_create_one_group(Session *s, const char *controller, const ch
r = -EINVAL;
if (r < 0) {
- r = cg_create(controller, path, NULL);
+ r = cg_create(controller, path);
if (r < 0)
return r;
}
- r = cg_set_task_access(controller, path, 0644, s->user->uid, s->user->gid, -1);
+ r = cg_set_task_access(controller, path, 0644, s->user->uid, s->user->gid);
if (r >= 0)
r = cg_set_group_access(controller, path, 0755, s->user->uid, s->user->gid);
diff --git a/src/login/logind-user.c b/src/login/logind-user.c
index fb0c9b75d7..9f7b924a24 100644
--- a/src/login/logind-user.c
+++ b/src/login/logind-user.c
@@ -349,7 +349,7 @@ static int user_create_cgroup(User *u) {
return log_oom();
}
- r = cg_create(SYSTEMD_CGROUP_CONTROLLER, u->cgroup_path, NULL);
+ r = cg_create(SYSTEMD_CGROUP_CONTROLLER, u->cgroup_path);
if (r < 0) {
log_error("Failed to create cgroup "SYSTEMD_CGROUP_CONTROLLER":%s: %s", u->cgroup_path, strerror(-r));
return r;
@@ -360,7 +360,7 @@ static int user_create_cgroup(User *u) {
if (strv_contains(u->manager->reset_controllers, *k))
continue;
- r = cg_create(*k, u->cgroup_path, NULL);
+ r = cg_create(*k, u->cgroup_path);
if (r < 0)
log_warning("Failed to create cgroup %s:%s: %s", *k, u->cgroup_path, strerror(-r));
}