diff options
author | Lennart Poettering <lennart@poettering.net> | 2017-02-13 20:44:11 +0100 |
---|---|---|
committer | Lennart Poettering <lennart@poettering.net> | 2017-02-13 20:44:11 +0100 |
commit | 1a63fc5430d66ccd72b0dbe3f6709724a811df40 (patch) | |
tree | 425434c200abc98c8764f30eb35140ed2b810d2e /src/resolve/resolved-mdns.c | |
parent | bceaa99d49538fc24151abed9f9d40c950f626a2 (diff) |
resolved: let's propagate errors from dns_scope_announce() and elsewhere
We don't actually make use of the return value for now, but it matches
our coding style elsewhere, and it actually shortens our code quite a
bit.
Also, add a missing OOM check after dns_answer_new().
Diffstat (limited to 'src/resolve/resolved-mdns.c')
-rw-r--r-- | src/resolve/resolved-mdns.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/resolve/resolved-mdns.c b/src/resolve/resolved-mdns.c index f5cae6f682..aa7661b5ad 100644 --- a/src/resolve/resolved-mdns.c +++ b/src/resolve/resolved-mdns.c @@ -78,10 +78,8 @@ static int mdns_scope_process_query(DnsScope *s, DnsPacket *p) { assert(p); r = dns_packet_extract(p); - if (r < 0) { - log_debug_errno(r, "Failed to extract resource records from incoming packet: %m"); - return r; - } + if (r < 0) + return log_debug_errno(r, "Failed to extract resource records from incoming packet: %m"); /* TODO: there might be more than one question in mDNS queries. */ assert_return((dns_question_size(p->question) > 0), -EINVAL); @@ -182,7 +180,7 @@ static int on_mdns_packet(sd_event_source *s, int fd, uint32_t revents, void *us r = mdns_scope_process_query(scope, p); if (r < 0) { - log_debug("mDNS query processing failed."); + log_debug_errno(r, "mDNS query processing failed: %m"); return 0; } } else |