diff options
author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2016-08-21 09:10:51 -0400 |
---|---|---|
committer | Lennart Poettering <lennart@poettering.net> | 2016-08-21 15:10:51 +0200 |
commit | 047d91f9c8cf1bcf5a30f428668babd619533944 (patch) | |
tree | b393fde73a6f4d5cd1515d3a6da7d6b8369f7cb9 /src/shared/acpi-fpdt.h | |
parent | 47d2d30d83eb7494593181915967be38451d72f1 (diff) |
shared/install: do not enable masked instances (#4005)
When told to enable a template unit, and the DefaultInstance specified in that
unit was masked, we would do this. Such a unit cannot be started or loaded, so
reporting successful enabling is misleading and unexpected.
$ systemctl mask getty@tty1
Created symlink /etc/systemd/system/getty@tty1.service → /dev/null.
$ systemctl --root=/ enable getty@tty1
(unchanged)
Failed to enable unit, unit /etc/systemd/system/getty@tty1.service is masked.
$ systemctl --root=/ enable getty@
(before)
Created symlink /etc/systemd/system/getty.target.wants/getty@tty1.service → /usr/lib/systemd/system/getty@.service.
(now)
Failed to enable unit, unit /etc/systemd/system/getty@tty1.service is masked.
The same error is emitted for enable and preset. And an error is emmited, not a
warning, so the failure to enable DefaultInstance is treated the same as if the
instance was specified on the command line. I think that this makes most sense,
for most template units.
Fixes #2513.
Diffstat (limited to 'src/shared/acpi-fpdt.h')
0 files changed, 0 insertions, 0 deletions