diff options
author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2013-04-11 18:57:42 -0400 |
---|---|---|
committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2013-04-11 19:13:18 -0400 |
commit | bcb161b0230fdd1faf9176f95fee76a7db6afd59 (patch) | |
tree | c3ba8c1cf806c961842bd51b42c6e8f9b7b59c6e /src/shared/socket-util.c | |
parent | 0ad4e1a872e789c77828d4c4825a56241103650c (diff) |
errno is positive
Make sure we compare errno against positive error codes.
The ones in hwclock.c and install.c can have an impact, the
rest are unlikely to be hit or in code that isn't widely
used.
Also check that errno > 0, to help gcc know that we are
returning a negative error code.
Diffstat (limited to 'src/shared/socket-util.c')
-rw-r--r-- | src/shared/socket-util.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/shared/socket-util.c b/src/shared/socket-util.c index 53457886e2..4933fe08e2 100644 --- a/src/shared/socket-util.c +++ b/src/shared/socket-util.c @@ -204,7 +204,7 @@ int socket_address_parse_netlink(SocketAddress *a, const char *s) { errno = 0; if (sscanf(s, "%ms %u", &sfamily, &group) < 1) - return errno ? -errno : -EINVAL; + return errno > 0 ? -errno : -EINVAL; family = netlink_family_from_string(sfamily); if (family < 0) |