diff options
| author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2013-03-28 09:24:15 -0400 |
|---|---|---|
| committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2013-03-29 10:12:41 -0400 |
| commit | 8333c77edf8fd1654cd96f3f6ee0f078dd64b58b (patch) | |
| tree | 135da27f10763e512868c34155891864877f6622 /src/shared/util.c | |
| parent | 0db809489fd88a320ae1023ffe36a9965e9a91b2 (diff) | |
Always use errno > 0 to help gcc
gcc thinks that errno might be negative, and functions could return
something positive on error (-errno). Should not matter in practice,
but makes an -O4 build much quieter.
Diffstat (limited to 'src/shared/util.c')
| -rw-r--r-- | src/shared/util.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/shared/util.c b/src/shared/util.c index 2241b79859..7281cc8ab8 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -2265,7 +2265,7 @@ int parse_bytes(const char *t, off_t *bytes) { errno = 0; l = strtoll(p, &e, 10); - if (errno != 0) + if (errno > 0) return -errno; if (l < 0) @@ -4191,7 +4191,7 @@ int get_user_creds( } if (!p) - return errno != 0 ? -errno : -ESRCH; + return errno > 0 ? -errno : -ESRCH; if (uid) *uid = p->pw_uid; @@ -4272,7 +4272,7 @@ int get_group_creds(const char **groupname, gid_t *gid) { } if (!g) - return errno != 0 ? -errno : -ESRCH; + return errno > 0 ? -errno : -ESRCH; if (gid) *gid = g->gr_gid; |