summaryrefslogtreecommitdiff
path: root/src/shared
diff options
context:
space:
mode:
authorMatija Skala <mskala@gmx.com>2017-04-25 14:44:29 +0200
committerLennart Poettering <lennart@poettering.net>2017-04-25 14:44:29 +0200
commitcaf222104afe2d12f3a188a6bfee3a35f2d04fc6 (patch)
treecfcc151605fb24a485f9a90de7b7b2fef8ea41f5 /src/shared
parentc6c60780a485127543c0dca5938599e4386c5317 (diff)
fix parenthesis in pager.c (#5798)
- result of dup2 should be compared against 0 - making parenthesis around comparisons just to be sure
Diffstat (limited to 'src/shared')
-rw-r--r--src/shared/pager.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/shared/pager.c b/src/shared/pager.c
index 2501a53c19..22d7603ec6 100644
--- a/src/shared/pager.c
+++ b/src/shared/pager.c
@@ -176,11 +176,11 @@ void pager_close(void) {
/* Inform pager that we are done */
(void) fflush(stdout);
- if (stdout_redirected && (stored_stdout < 0 || dup2(stored_stdout, STDOUT_FILENO)) < 0)
+ if (stdout_redirected && ((stored_stdout < 0) || (dup2(stored_stdout, STDOUT_FILENO) < 0)))
(void) close(STDOUT_FILENO);
stored_stdout = safe_close(stored_stdout);
(void) fflush(stderr);
- if (stderr_redirected && (stored_stderr < 0 || dup2(stored_stderr, STDERR_FILENO)) < 0)
+ if (stderr_redirected && ((stored_stderr < 0) || (dup2(stored_stderr, STDERR_FILENO) < 0)))
(void) close(STDERR_FILENO);
stored_stderr = safe_close(stored_stderr);
stdout_redirected = stderr_redirected = false;