Modify mount_propagation_flags_from_string to return a normal int code

This means that callers can distiguish an error from flags==0,
and don't have to special-case the empty string.

1 files changed, 3 insertions, 9 deletions

diff --git a/src/shared/bus-unit-util.c b/src/shared/bus-unit-util.c
index b030b3b9d1..829be2c6da 100644
--- a/src/shared/bus-unit-util.c
+++ b/src/shared/bus-unit-util.c
@@ -579,15 +579,9 @@ int bus_append_unit_property_assignment(sd_bus_message *m, const char *assignmen
         else if (streq(field, "MountFlags")) {
                 unsigned long f;
 
-                if (isempty(eq))
-                        f = 0;
-                else {
-                        f = mount_propagation_flags_from_string(eq);
-                        if (f == 0) {
-                                log_error("Failed to parse mount propagation type: %s", eq);
-                                return -EINVAL;
-                        }
-                }
+                r = mount_propagation_flags_from_string(eq, &f);
+                if (r < 0)
+                        return log_error_errno(r, "Failed to parse mount propagation flags: %s", eq);
 
                 r = sd_bus_message_append(m, "v", "t", f);
         } else if (STR_IN_SET(field, "BindPaths", "BindReadOnlyPaths")) {