diff options
| author | Lennart Poettering <lennart@poettering.net> | 2016-06-15 22:41:56 +0200 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2016-06-21 13:20:48 +0200 |
| commit | 43dcc86a137b5c1192eca67c345b73a9ccc4dccb (patch) | |
| tree | 06f58aae378d181bfcb4915c67047eeaf731059f /src/shared | |
| parent | 943ef07ce0aacbee93c721e461c02d651ee9ef6a (diff) | |
sd-bus: make sure bus_map_all_properties() handle booleans right
sd-bus generally exposes bools as "int" instead of "bool" in the public API.
This is relevant when unmarshaling booleans, as the relevant functions expect
an int* pointer and no bool* pointer. Since sizeof(bool) is not necessarily the
same as sizeof(int) this is problematic and might result in memory corruption.
Let's fix this, and make sure bus_map_all_properties() handles booleans as
ints, as the rest of sd-bus, and make all users of it expect the right thing.
Diffstat (limited to 'src/shared')
| -rw-r--r-- | src/shared/bus-util.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/shared/bus-util.c b/src/shared/bus-util.c index 8e3307dc24..52410999cf 100644 --- a/src/shared/bus-util.c +++ b/src/shared/bus-util.c @@ -1048,7 +1048,7 @@ static int map_basic(sd_bus *bus, const char *member, sd_bus_message *m, sd_bus_ case SD_BUS_TYPE_BOOLEAN: { unsigned b; - bool *p = userdata; + int *p = userdata; r = sd_bus_message_read_basic(m, type, &b); if (r < 0) |