diff options
author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2014-12-16 23:53:23 -0500 |
---|---|---|
committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2014-12-18 00:52:41 -0500 |
commit | ee05e7795bb9ad7d1212dd49ad362f3e9603c4fd (patch) | |
tree | 54b417af3285979aef08af98d50e81b851c9b256 /src/test | |
parent | 503dbda6d94c16161762b7b489677a377f235590 (diff) |
core: use raw_clone instead of fork in signal handler
fork() is not async-signal-safe and calling it from the signal handler
could result in a deadlock when at_fork() handlers are called. Using
the raw clone() syscall sidesteps that problem.
The tricky part is that raise() does not work, since getpid() does not
work. Add raw_getpid() to get the real pid, and use kill() instead of
raise().
https://bugs.freedesktop.org/show_bug.cgi?id=86604
Diffstat (limited to 'src/test')
-rw-r--r-- | src/test/test-util.c | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/src/test/test-util.c b/src/test/test-util.c index 6c7d77b19b..bbf7512839 100644 --- a/src/test/test-util.c +++ b/src/test/test-util.c @@ -1312,6 +1312,25 @@ static void test_parse_proc_cmdline(void) { assert_se(parse_proc_cmdline(parse_item) >= 0); } +static void test_raw_clone(void) { + pid_t parent, pid, pid2; + + parent = getpid(); + log_info("before clone: getpid()→"PID_FMT, parent); + assert_se(raw_getpid() == parent); + + pid = raw_clone(0, NULL); + assert(pid >= 0); + + pid2 = raw_getpid(); + log_info("raw_clone: "PID_FMT" getpid()→"PID_FMT" raw_getpid()→"PID_FMT, + pid, getpid(), pid2); + if (pid == 0) + assert(pid2 != parent); + else + assert(pid2 == parent); +} + int main(int argc, char *argv[]) { log_parse_environment(); log_open(); @@ -1384,6 +1403,7 @@ int main(int argc, char *argv[]) { test_unquote_first_word(); test_unquote_many_words(); test_parse_proc_cmdline(); + test_raw_clone(); return 0; } |