diff options
| author | Tom Gundersen <teg@jklm.no> | 2014-09-17 20:12:41 -0400 |
|---|---|---|
| committer | Anthony G. Basile <blueness@gentoo.org> | 2014-09-17 20:12:41 -0400 |
| commit | cb6d2d864c2b588b4efed51c9935e97f9ba86d5d (patch) | |
| tree | 7edf12045a9623b3ddc87f6ead409a316431b41c /src/udev | |
| parent | 39f24db770b55348f3056871429d0af6ed2405ec (diff) | |
udevd: use safe_ato*() in place of strto*()
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Diffstat (limited to 'src/udev')
| -rw-r--r-- | src/udev/udevd.c | 25 |
1 files changed, 19 insertions, 6 deletions
diff --git a/src/udev/udevd.c b/src/udev/udevd.c index f1aa75adfd..5b0db0a0b1 100644 --- a/src/udev/udevd.c +++ b/src/udev/udevd.c @@ -1013,11 +1013,20 @@ static void kernel_cmdline_options(struct udev *udev) { log_set_max_level(prio); udev_set_log_priority(udev, prio); } else if (startswith(opt, "udev.children-max=")) { - arg_children_max = strtoul(opt + 18, NULL, 0); + r = safe_atoi(opt + 18, &arg_children_max); + if (r < 0) + log_warning("Invalid udev.children-max ignored: %s", opt + 18); } else if (startswith(opt, "udev.exec-delay=")) { - arg_exec_delay = strtoul(opt + 16, NULL, 0); + r = safe_atoi(opt + 16, &arg_exec_delay); + if (r < 0) + log_warning("Invalid udev.exec-delay ignored: %s", opt + 16); } else if (startswith(opt, "udev.event-timeout=")) { - arg_event_timeout_usec = strtoul(opt + 16, NULL, 0) * USEC_PER_SEC; + r = safe_atou64(opt + 16, &arg_event_timeout_usec); + if (r < 0) { + log_warning("Invalid udev.event-timeout ignored: %s", opt + 16); + break; + } + arg_event_timeout_usec *= USEC_PER_SEC; arg_event_timeout_warn_usec = (arg_event_timeout_usec / 3) ? : 1; } @@ -1057,6 +1066,7 @@ static int parse_argv(int argc, char *argv[]) { assert(argv); while ((c = getopt_long(argc, argv, "c:de:DtN:hV", options, NULL)) >= 0) { + int r; switch (c) { @@ -1065,13 +1075,16 @@ static int parse_argv(int argc, char *argv[]) { arg_daemonize = true; break; case 'c': - arg_children_max = strtoul(optarg, NULL, 0); + safe_atoi(optarg, &arg_children_max); break; case 'e': - arg_exec_delay = strtoul(optarg, NULL, 0); + safe_atoi(optarg, &arg_exec_delay); break; case 't': - arg_event_timeout_usec = strtoul(optarg, NULL, 0) * USEC_PER_SEC; + r = safe_atou64(optarg, &arg_event_timeout_usec); + if (r < 0) + break; + arg_event_timeout_usec *= USEC_PER_SEC; arg_event_timeout_warn_usec = (arg_event_timeout_usec / 3) ? : 1; break; case 'D': |