diff options
| author | Thomas Hindoe Paaboel Andersen <phomes@gmail.com> | 2013-12-14 13:09:07 +0100 |
|---|---|---|
| committer | Thomas Hindoe Paaboel Andersen <phomes@gmail.com> | 2013-12-14 13:32:22 +0100 |
| commit | 9091e686f43184065381aa71929e3df36a4ea2e1 (patch) | |
| tree | 37fe0c888a655bcf2d976411f21c068c300abbae /src/udev | |
| parent | 8d35dae708ffbb88f1b023964913d3d53d4a7418 (diff) | |
Add more _printf_'s for format-nonliterals
Clang is a bit more strict wrt format-nonliterals:
http://clang.llvm.org/docs/LanguageExtensions.html#format-string-checking
Adding these extra printf attributes also makes gcc able to find more
problems. E.g. this patch uncovers a format issue in udev-builtin-path_id.c
Some parts looked intetional about breaking the format-nonliteral check.
I added some supression for warnings there.
Diffstat (limited to 'src/udev')
| -rw-r--r-- | src/udev/accelerometer/accelerometer.c | 1 | ||||
| -rw-r--r-- | src/udev/ata_id/ata_id.c | 1 | ||||
| -rw-r--r-- | src/udev/cdrom_id/cdrom_id.c | 1 | ||||
| -rw-r--r-- | src/udev/scsi_id/scsi_id.c | 1 | ||||
| -rw-r--r-- | src/udev/udev-builtin-kmod.c | 1 | ||||
| -rw-r--r-- | src/udev/udev-builtin-path_id.c | 1 |
6 files changed, 6 insertions, 0 deletions
diff --git a/src/udev/accelerometer/accelerometer.c b/src/udev/accelerometer/accelerometer.c index e611b48a42..86966fbd5f 100644 --- a/src/udev/accelerometer/accelerometer.c +++ b/src/udev/accelerometer/accelerometer.c @@ -71,6 +71,7 @@ static int debug = 0; +_printf_(6,0) static void log_fn(struct udev *udev, int priority, const char *file, int line, const char *fn, const char *format, va_list args) diff --git a/src/udev/ata_id/ata_id.c b/src/udev/ata_id/ata_id.c index d375d43491..28e9acb296 100644 --- a/src/udev/ata_id/ata_id.c +++ b/src/udev/ata_id/ata_id.c @@ -405,6 +405,7 @@ out: return ret; } +_printf_(6,0) static void log_fn(struct udev *udev, int priority, const char *file, int line, const char *fn, const char *format, va_list args) diff --git a/src/udev/cdrom_id/cdrom_id.c b/src/udev/cdrom_id/cdrom_id.c index 1ad0459236..09d2d69755 100644 --- a/src/udev/cdrom_id/cdrom_id.c +++ b/src/udev/cdrom_id/cdrom_id.c @@ -39,6 +39,7 @@ static bool debug; +_printf_(6,0) static void log_fn(struct udev *udev, int priority, const char *file, int line, const char *fn, const char *format, va_list args) diff --git a/src/udev/scsi_id/scsi_id.c b/src/udev/scsi_id/scsi_id.c index c2cc2ea48d..ae36b9e356 100644 --- a/src/udev/scsi_id/scsi_id.c +++ b/src/udev/scsi_id/scsi_id.c @@ -67,6 +67,7 @@ static char model_enc_str[256]; static char revision_str[16]; static char type_str[16]; +_printf_(6,0) static void log_fn(struct udev *udev, int priority, const char *file, int line, const char *fn, const char *format, va_list args) diff --git a/src/udev/udev-builtin-kmod.c b/src/udev/udev-builtin-kmod.c index fc28121267..63dbf30727 100644 --- a/src/udev/udev-builtin-kmod.c +++ b/src/udev/udev-builtin-kmod.c @@ -64,6 +64,7 @@ static int load_module(struct udev *udev, const char *alias) return err; } +_printf_(6,0) static void udev_kmod_log(void *data, int priority, const char *file, int line, const char *fn, const char *format, va_list args) { diff --git a/src/udev/udev-builtin-path_id.c b/src/udev/udev-builtin-path_id.c index 763f3c3113..7476330196 100644 --- a/src/udev/udev-builtin-path_id.c +++ b/src/udev/udev-builtin-path_id.c @@ -32,6 +32,7 @@ #include "udev.h" +_printf_(2,3) static int path_prepend(char **path, const char *fmt, ...) { va_list va; |