summaryrefslogtreecommitdiff
path: root/src/verify/verify.c
diff options
context:
space:
mode:
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2014-07-20 18:23:53 -0400
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2014-07-20 19:48:16 -0400
commit78002a678106a9a4e0e9d747f54458ba84322f1a (patch)
treec25747b7ae2cd0c8ebed0a01ab5a880df61e7064 /src/verify/verify.c
parent8b835fccdad78d89f9cc64f9b02059fb75ffbab1 (diff)
systemd-verify: check man pages
Diffstat (limited to 'src/verify/verify.c')
-rw-r--r--src/verify/verify.c47
1 files changed, 45 insertions, 2 deletions
diff --git a/src/verify/verify.c b/src/verify/verify.c
index fc513b1b69..cad79ecf48 100644
--- a/src/verify/verify.c
+++ b/src/verify/verify.c
@@ -27,8 +27,10 @@
#include "log.h"
#include "strv.h"
#include "build.h"
+#include "pager.h"
SystemdRunningAs arg_running_as = SYSTEMD_SYSTEM;
+bool arg_no_man = false;
static int generate_path(char **var, char **filenames) {
char **filename;
@@ -140,6 +142,37 @@ static int verify_executables(Unit *u) {
return r;
}
+static int verify_documentation(Unit *u) {
+ char **p;
+ int r = 0, k;
+
+ if (arg_no_man)
+ return 0;
+
+ STRV_FOREACH(p, u->documentation) {
+ log_debug_unit(u->id, "%s: found documentation item %s.", u->id, *p);
+ if (startswith(*p, "man:")) {
+ k = show_man_page(*p + 4, true);
+ if (k != 0) {
+ if (k < 0)
+ log_error_unit(u->id, "%s: can't show %s: %s",
+ u->id, *p, strerror(-r));
+ else {
+ log_error_unit(u->id, "%s: man %s command failed with code %d",
+ u->id, *p + 4, k);
+ k = -ENOEXEC;
+ }
+ if (r == 0)
+ r = k;
+ }
+ }
+ }
+
+ /* Check remote URLs? */
+
+ return r;
+}
+
static int test_unit(Unit *u) {
_cleanup_bus_error_free_ sd_bus_error err = SD_BUS_ERROR_NULL;
Job *j;
@@ -167,6 +200,10 @@ static int test_unit(Unit *u) {
if (k < 0 && r == 0)
r = k;
+ k = verify_documentation(u);
+ if (k < 0 && r == 0)
+ r = k;
+
return r;
}
@@ -242,8 +279,9 @@ static void help(void) {
" -h --help Show this help\n"
" --version Show package version\n"
" --system Connect to system manager\n"
- " --user Connect to user service manager\n",
- program_invocation_short_name);
+ " --user Connect to user service manager\n"
+ " --no-man Do not check for existence of man pages\n"
+ , program_invocation_short_name);
}
static int parse_argv(int argc, char *argv[]) {
@@ -251,6 +289,7 @@ static int parse_argv(int argc, char *argv[]) {
ARG_VERSION = 0x100,
ARG_USER,
ARG_SYSTEM,
+ ARG_NO_MAN,
};
static const struct option options[] = {
@@ -288,6 +327,10 @@ static int parse_argv(int argc, char *argv[]) {
arg_running_as = SYSTEMD_SYSTEM;
break;
+ case ARG_NO_MAN:
+ arg_no_man = true;
+ break;
+
case '?':
log_error("Unknown option %s.", argv[optind-1]);
return -EINVAL;