summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2015-10-26 20:07:55 +0100
committerLennart Poettering <lennart@poettering.net>2015-10-27 13:25:56 +0100
commita09561746f15b84da9471b5c4be74e53d19e4f3f (patch)
treee99301f014ab8d150891d936ca061e369f7bae33 /src
parent78f22b973fa2c9b09bd974680836df17163d9ee0 (diff)
util-lib: introduce dirent-util.[ch] for directory entry calls
Also, move a couple of more path-related functions to path-util.c.
Diffstat (limited to 'src')
-rw-r--r--src/basic/cgroup-util.c1
-rw-r--r--src/basic/conf-files.c1
-rw-r--r--src/basic/copy.c1
-rw-r--r--src/basic/dirent-util.c81
-rw-r--r--src/basic/dirent-util.h51
-rw-r--r--src/basic/fd-util.c1
-rw-r--r--src/basic/fdset.c1
-rw-r--r--src/basic/locale-util.c1
-rw-r--r--src/basic/path-util.c67
-rw-r--r--src/basic/path-util.h7
-rw-r--r--src/basic/util.c121
-rw-r--r--src/basic/util.h32
-rw-r--r--src/bootchart/store.c1
-rw-r--r--src/core/smack-setup.c1
-rw-r--r--src/dbus1-generator/dbus1-generator.c1
-rw-r--r--src/delta/delta.c1
-rw-r--r--src/gpt-auto-generator/gpt-auto-generator.c1
-rw-r--r--src/import/pull-common.c1
-rw-r--r--src/journal/coredump-vacuum.c1
-rw-r--r--src/journal/coredump.c1
-rw-r--r--src/journal/journal-vacuum.c1
-rw-r--r--src/journal/journald-server.c1
-rw-r--r--src/journal/journald-stream.c1
-rw-r--r--src/journal/sd-journal.c1
-rw-r--r--src/libsystemd/sd-device/device-enumerator.c1
-rw-r--r--src/libsystemd/sd-login/sd-login.c1
-rw-r--r--src/login/logind-acl.c1
-rw-r--r--src/login/logind-dbus.c1
-rw-r--r--src/login/logind.c1
-rw-r--r--src/machine/machined.c1
-rw-r--r--src/shared/clean-ipc.c1
-rw-r--r--src/shared/efivars.c1
-rw-r--r--src/shared/install.c5
-rw-r--r--src/shared/machine-image.c1
-rw-r--r--src/test/test-cgroup-util.c1
-rw-r--r--src/tty-ask-password-agent/tty-ask-password-agent.c1
36 files changed, 239 insertions, 154 deletions
diff --git a/src/basic/cgroup-util.c b/src/basic/cgroup-util.c
index 232d6e8fe2..67dc291192 100644
--- a/src/basic/cgroup-util.c
+++ b/src/basic/cgroup-util.c
@@ -30,6 +30,7 @@
#include <unistd.h>
#include "cgroup-util.h"
+#include "dirent-util.h"
#include "extract-word.h"
#include "fd-util.h"
#include "fileio.h"
diff --git a/src/basic/conf-files.c b/src/basic/conf-files.c
index 3af3fe392c..be9972ffff 100644
--- a/src/basic/conf-files.c
+++ b/src/basic/conf-files.c
@@ -26,6 +26,7 @@
#include <string.h>
#include "conf-files.h"
+#include "dirent-util.h"
#include "fd-util.h"
#include "hashmap.h"
#include "log.h"
diff --git a/src/basic/copy.c b/src/basic/copy.c
index 4b410a74e5..2d2d7ade34 100644
--- a/src/basic/copy.c
+++ b/src/basic/copy.c
@@ -24,6 +24,7 @@
#include "btrfs-util.h"
#include "copy.h"
+#include "dirent-util.h"
#include "fd-util.h"
#include "fileio.h"
#include "io-util.h"
diff --git a/src/basic/dirent-util.c b/src/basic/dirent-util.c
new file mode 100644
index 0000000000..c433d5844a
--- /dev/null
+++ b/src/basic/dirent-util.c
@@ -0,0 +1,81 @@
+/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/
+
+/***
+ This file is part of systemd.
+
+ Copyright 2010-2012 Lennart Poettering
+
+ systemd is free software; you can redistribute it and/or modify it
+ under the terms of the GNU Lesser General Public License as published by
+ the Free Software Foundation; either version 2.1 of the License, or
+ (at your option) any later version.
+
+ systemd is distributed in the hope that it will be useful, but
+ WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public License
+ along with systemd; If not, see <http://www.gnu.org/licenses/>.
+***/
+
+#include <fcntl.h>
+#include <sys/stat.h>
+#include <sys/types.h>
+#include <unistd.h>
+
+#include "dirent-util.h"
+#include "string-util.h"
+
+int dirent_ensure_type(DIR *d, struct dirent *de) {
+ struct stat st;
+
+ assert(d);
+ assert(de);
+
+ if (de->d_type != DT_UNKNOWN)
+ return 0;
+
+ if (fstatat(dirfd(d), de->d_name, &st, AT_SYMLINK_NOFOLLOW) < 0)
+ return -errno;
+
+ de->d_type =
+ S_ISREG(st.st_mode) ? DT_REG :
+ S_ISDIR(st.st_mode) ? DT_DIR :
+ S_ISLNK(st.st_mode) ? DT_LNK :
+ S_ISFIFO(st.st_mode) ? DT_FIFO :
+ S_ISSOCK(st.st_mode) ? DT_SOCK :
+ S_ISCHR(st.st_mode) ? DT_CHR :
+ S_ISBLK(st.st_mode) ? DT_BLK :
+ DT_UNKNOWN;
+
+ return 0;
+}
+
+bool dirent_is_file(const struct dirent *de) {
+ assert(de);
+
+ if (hidden_file(de->d_name))
+ return false;
+
+ if (de->d_type != DT_REG &&
+ de->d_type != DT_LNK &&
+ de->d_type != DT_UNKNOWN)
+ return false;
+
+ return true;
+}
+
+bool dirent_is_file_with_suffix(const struct dirent *de, const char *suffix) {
+ assert(de);
+
+ if (de->d_type != DT_REG &&
+ de->d_type != DT_LNK &&
+ de->d_type != DT_UNKNOWN)
+ return false;
+
+ if (hidden_file_allow_backup(de->d_name))
+ return false;
+
+ return endswith(de->d_name, suffix);
+}
diff --git a/src/basic/dirent-util.h b/src/basic/dirent-util.h
new file mode 100644
index 0000000000..5866a755f4
--- /dev/null
+++ b/src/basic/dirent-util.h
@@ -0,0 +1,51 @@
+/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/
+
+#pragma once
+
+/***
+ This file is part of systemd.
+
+ Copyright 2010 Lennart Poettering
+
+ systemd is free software; you can redistribute it and/or modify it
+ under the terms of the GNU Lesser General Public License as published by
+ the Free Software Foundation; either version 2.1 of the License, or
+ (at your option) any later version.
+
+ systemd is distributed in the hope that it will be useful, but
+ WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public License
+ along with systemd; If not, see <http://www.gnu.org/licenses/>.
+***/
+
+#include <dirent.h>
+
+#include "path-util.h"
+
+int dirent_ensure_type(DIR *d, struct dirent *de);
+
+bool dirent_is_file(const struct dirent *de) _pure_;
+bool dirent_is_file_with_suffix(const struct dirent *de, const char *suffix) _pure_;
+
+#define FOREACH_DIRENT(de, d, on_error) \
+ for (errno = 0, de = readdir(d);; errno = 0, de = readdir(d)) \
+ if (!de) { \
+ if (errno > 0) { \
+ on_error; \
+ } \
+ break; \
+ } else if (hidden_file((de)->d_name)) \
+ continue; \
+ else
+
+#define FOREACH_DIRENT_ALL(de, d, on_error) \
+ for (errno = 0, de = readdir(d);; errno = 0, de = readdir(d)) \
+ if (!de) { \
+ if (errno > 0) { \
+ on_error; \
+ } \
+ break; \
+ } else
diff --git a/src/basic/fd-util.c b/src/basic/fd-util.c
index 76d7e32bfa..f40365ce97 100644
--- a/src/basic/fd-util.c
+++ b/src/basic/fd-util.c
@@ -22,6 +22,7 @@
#include "fd-util.h"
#include "parse-util.h"
#include "util.h"
+#include "dirent-util.h"
int close_nointr(int fd) {
assert(fd >= 0);
diff --git a/src/basic/fdset.c b/src/basic/fdset.c
index ef60f66431..4b11e4ea09 100644
--- a/src/basic/fdset.c
+++ b/src/basic/fdset.c
@@ -25,6 +25,7 @@
#include "sd-daemon.h"
+#include "dirent-util.h"
#include "fd-util.h"
#include "fdset.h"
#include "macro.h"
diff --git a/src/basic/locale-util.c b/src/basic/locale-util.c
index ccbc147931..08da4b98c5 100644
--- a/src/basic/locale-util.c
+++ b/src/basic/locale-util.c
@@ -21,6 +21,7 @@
#include <sys/mman.h>
+#include "dirent-util.h"
#include "fd-util.h"
#include "locale-util.h"
#include "path-util.h"
diff --git a/src/basic/path-util.c b/src/basic/path-util.c
index d581f85707..ed30c3d92d 100644
--- a/src/basic/path-util.c
+++ b/src/basic/path-util.c
@@ -766,3 +766,70 @@ bool path_is_safe(const char *p) {
return true;
}
+
+char *file_in_same_dir(const char *path, const char *filename) {
+ char *e, *ret;
+ size_t k;
+
+ assert(path);
+ assert(filename);
+
+ /* This removes the last component of path and appends
+ * filename, unless the latter is absolute anyway or the
+ * former isn't */
+
+ if (path_is_absolute(filename))
+ return strdup(filename);
+
+ e = strrchr(path, '/');
+ if (!e)
+ return strdup(filename);
+
+ k = strlen(filename);
+ ret = new(char, (e + 1 - path) + k + 1);
+ if (!ret)
+ return NULL;
+
+ memcpy(mempcpy(ret, path, e + 1 - path), filename, k + 1);
+ return ret;
+}
+
+bool hidden_file_allow_backup(const char *filename) {
+ assert(filename);
+
+ return
+ filename[0] == '.' ||
+ streq(filename, "lost+found") ||
+ streq(filename, "aquota.user") ||
+ streq(filename, "aquota.group") ||
+ endswith(filename, ".rpmnew") ||
+ endswith(filename, ".rpmsave") ||
+ endswith(filename, ".rpmorig") ||
+ endswith(filename, ".dpkg-old") ||
+ endswith(filename, ".dpkg-new") ||
+ endswith(filename, ".dpkg-tmp") ||
+ endswith(filename, ".dpkg-dist") ||
+ endswith(filename, ".dpkg-bak") ||
+ endswith(filename, ".dpkg-backup") ||
+ endswith(filename, ".dpkg-remove") ||
+ endswith(filename, ".swp");
+}
+
+bool hidden_file(const char *filename) {
+ assert(filename);
+
+ if (endswith(filename, "~"))
+ return true;
+
+ return hidden_file_allow_backup(filename);
+}
+
+bool is_device_path(const char *path) {
+
+ /* Returns true on paths that refer to a device, either in
+ * sysfs or in /dev */
+
+ return
+ path_startswith(path, "/dev/") ||
+ path_startswith(path, "/sys/");
+}
diff --git a/src/basic/path-util.h b/src/basic/path-util.h
index b2acca05fe..193bf72468 100644
--- a/src/basic/path-util.h
+++ b/src/basic/path-util.h
@@ -105,3 +105,10 @@ char* dirname_malloc(const char *path);
bool filename_is_valid(const char *p) _pure_;
bool path_is_safe(const char *p) _pure_;
+
+char *file_in_same_dir(const char *path, const char *filename);
+
+bool hidden_file_allow_backup(const char *filename);
+bool hidden_file(const char *filename) _pure_;
+
+bool is_device_path(const char *path);
diff --git a/src/basic/util.c b/src/basic/util.c
index 121ca3376e..e214c6f3dc 100644
--- a/src/basic/util.c
+++ b/src/basic/util.c
@@ -102,6 +102,7 @@
#include "utf8.h"
#include "util.h"
#include "virt.h"
+#include "dirent-util.h"
/* Put this test here for a lack of better place */
assert_cc(EAGAIN == EWOULDBLOCK);
@@ -247,33 +248,6 @@ int readlink_and_canonicalize(const char *p, char **r) {
return 0;
}
-char *file_in_same_dir(const char *path, const char *filename) {
- char *e, *ret;
- size_t k;
-
- assert(path);
- assert(filename);
-
- /* This removes the last component of path and appends
- * filename, unless the latter is absolute anyway or the
- * former isn't */
-
- if (path_is_absolute(filename))
- return strdup(filename);
-
- e = strrchr(path, '/');
- if (!e)
- return strdup(filename);
-
- k = strlen(filename);
- ret = new(char, (e + 1 - path) + k + 1);
- if (!ret)
- return NULL;
-
- memcpy(mempcpy(ret, path, e + 1 - path), filename, k + 1);
- return ret;
-}
-
int rmdir_parents(const char *path, const char *stop) {
size_t l;
int r = 0;
@@ -320,36 +294,6 @@ int rmdir_parents(const char *path, const char *stop) {
return 0;
}
-_pure_ static bool hidden_file_allow_backup(const char *filename) {
- assert(filename);
-
- return
- filename[0] == '.' ||
- streq(filename, "lost+found") ||
- streq(filename, "aquota.user") ||
- streq(filename, "aquota.group") ||
- endswith(filename, ".rpmnew") ||
- endswith(filename, ".rpmsave") ||
- endswith(filename, ".rpmorig") ||
- endswith(filename, ".dpkg-old") ||
- endswith(filename, ".dpkg-new") ||
- endswith(filename, ".dpkg-tmp") ||
- endswith(filename, ".dpkg-dist") ||
- endswith(filename, ".dpkg-bak") ||
- endswith(filename, ".dpkg-backup") ||
- endswith(filename, ".dpkg-remove") ||
- endswith(filename, ".swp");
-}
-
-bool hidden_file(const char *filename) {
- assert(filename);
-
- if (endswith(filename, "~"))
- return true;
-
- return hidden_file_allow_backup(filename);
-}
-
bool fstype_is_network(const char *fstype) {
static const char table[] =
"afs\0"
@@ -373,16 +317,6 @@ bool fstype_is_network(const char *fstype) {
return nulstr_contains(table, fstype);
}
-bool is_device_path(const char *path) {
-
- /* Returns true on paths that refer to a device, either in
- * sysfs or in /dev */
-
- return
- path_startswith(path, "/dev/") ||
- path_startswith(path, "/sys/");
-}
-
int dir_is_empty(const char *path) {
_cleanup_closedir_ DIR *d;
struct dirent *de;
@@ -615,34 +549,6 @@ int null_or_empty_fd(int fd) {
return null_or_empty(&st);
}
-bool dirent_is_file(const struct dirent *de) {
- assert(de);
-
- if (hidden_file(de->d_name))
- return false;
-
- if (de->d_type != DT_REG &&
- de->d_type != DT_LNK &&
- de->d_type != DT_UNKNOWN)
- return false;
-
- return true;
-}
-
-bool dirent_is_file_with_suffix(const struct dirent *de, const char *suffix) {
- assert(de);
-
- if (de->d_type != DT_REG &&
- de->d_type != DT_LNK &&
- de->d_type != DT_UNKNOWN)
- return false;
-
- if (hidden_file_allow_backup(de->d_name))
- return false;
-
- return endswith(de->d_name, suffix);
-}
-
static int do_execute(char **directories, usec_t timeout, char *argv[]) {
_cleanup_hashmap_free_free_ Hashmap *pids = NULL;
_cleanup_set_free_free_ Set *seen = NULL;
@@ -950,31 +856,6 @@ int glob_extend(char ***strv, const char *path) {
return k;
}
-int dirent_ensure_type(DIR *d, struct dirent *de) {
- struct stat st;
-
- assert(d);
- assert(de);
-
- if (de->d_type != DT_UNKNOWN)
- return 0;
-
- if (fstatat(dirfd(d), de->d_name, &st, AT_SYMLINK_NOFOLLOW) < 0)
- return -errno;
-
- de->d_type =
- S_ISREG(st.st_mode) ? DT_REG :
- S_ISDIR(st.st_mode) ? DT_DIR :
- S_ISLNK(st.st_mode) ? DT_LNK :
- S_ISFIFO(st.st_mode) ? DT_FIFO :
- S_ISSOCK(st.st_mode) ? DT_SOCK :
- S_ISCHR(st.st_mode) ? DT_CHR :
- S_ISBLK(st.st_mode) ? DT_BLK :
- DT_UNKNOWN;
-
- return 0;
-}
-
int get_files_in_directory(const char *path, char ***list) {
_cleanup_closedir_ DIR *d = NULL;
size_t bufsize = 0, n = 0;
diff --git a/src/basic/util.h b/src/basic/util.h
index 6e5df01450..190d4f5edb 100644
--- a/src/basic/util.h
+++ b/src/basic/util.h
@@ -22,7 +22,6 @@
***/
#include <alloca.h>
-#include <dirent.h>
#include <fcntl.h>
#include <inttypes.h>
#include <limits.h>
@@ -90,15 +89,8 @@ int readlink_value(const char *p, char **ret);
int readlink_and_make_absolute(const char *p, char **r);
int readlink_and_canonicalize(const char *p, char **r);
-char *file_in_same_dir(const char *path, const char *filename);
-
int rmdir_parents(const char *path, const char *stop);
-bool dirent_is_file(const struct dirent *de) _pure_;
-bool dirent_is_file_with_suffix(const struct dirent *de, const char *suffix) _pure_;
-
-bool hidden_file(const char *filename) _pure_;
-
/* For basic lookup tables with strictly enumerated entries */
#define _DEFINE_STRING_TABLE_LOOKUP_TO_STRING(name,type,scope) \
scope const char *name##_to_string(type i) { \
@@ -157,8 +149,6 @@ ssize_t string_table_lookup(const char * const *table, size_t len, const char *k
bool fstype_is_network(const char *fstype);
-bool is_device_path(const char *path);
-
int dir_is_empty(const char *path);
static inline int dir_is_populated(const char *path) {
@@ -216,8 +206,6 @@ int socket_from_display(const char *display, char **path);
int glob_exists(const char *path);
int glob_extend(char ***strv, const char *path);
-int dirent_ensure_type(DIR *d, struct dirent *de);
-
int get_files_in_directory(const char *path, char ***list);
bool is_main_thread(void);
@@ -332,26 +320,6 @@ const char *draw_special_char(DrawSpecialChar ch);
int on_ac_power(void);
-#define FOREACH_DIRENT(de, d, on_error) \
- for (errno = 0, de = readdir(d);; errno = 0, de = readdir(d)) \
- if (!de) { \
- if (errno > 0) { \
- on_error; \
- } \
- break; \
- } else if (hidden_file((de)->d_name)) \
- continue; \
- else
-
-#define FOREACH_DIRENT_ALL(de, d, on_error) \
- for (errno = 0, de = readdir(d);; errno = 0, de = readdir(d)) \
- if (!de) { \
- if (errno > 0) { \
- on_error; \
- } \
- break; \
- } else
-
static inline void *mempset(void *s, int c, size_t n) {
memset(s, c, n);
return (uint8_t*)s + n;
diff --git a/src/bootchart/store.c b/src/bootchart/store.c
index 50b69637ef..e488c94b3b 100644
--- a/src/bootchart/store.c
+++ b/src/bootchart/store.c
@@ -33,6 +33,7 @@
#include "bootchart.h"
#include "cgroup-util.h"
+#include "dirent-util.h"
#include "fd-util.h"
#include "fileio.h"
#include "parse-util.h"
diff --git a/src/core/smack-setup.c b/src/core/smack-setup.c
index 34df392184..b8cb9964a6 100644
--- a/src/core/smack-setup.c
+++ b/src/core/smack-setup.c
@@ -28,6 +28,7 @@
#include <stdlib.h>
#include <string.h>
+#include "dirent-util.h"
#include "fd-util.h"
#include "fileio.h"
#include "log.h"
diff --git a/src/dbus1-generator/dbus1-generator.c b/src/dbus1-generator/dbus1-generator.c
index b9683a7ee1..66a0fe9ea2 100644
--- a/src/dbus1-generator/dbus1-generator.c
+++ b/src/dbus1-generator/dbus1-generator.c
@@ -23,6 +23,7 @@
#include "bus-util.h"
#include "cgroup-util.h"
#include "conf-parser.h"
+#include "dirent-util.h"
#include "fd-util.h"
#include "fileio.h"
#include "mkdir.h"
diff --git a/src/delta/delta.c b/src/delta/delta.c
index bb2e6195b9..590ab86515 100644
--- a/src/delta/delta.c
+++ b/src/delta/delta.c
@@ -26,6 +26,7 @@
#include <sys/prctl.h>
#include <unistd.h>
+#include "dirent-util.h"
#include "fd-util.h"
#include "hashmap.h"
#include "log.h"
diff --git a/src/gpt-auto-generator/gpt-auto-generator.c b/src/gpt-auto-generator/gpt-auto-generator.c
index 6440fd654e..f315d5ff6e 100644
--- a/src/gpt-auto-generator/gpt-auto-generator.c
+++ b/src/gpt-auto-generator/gpt-auto-generator.c
@@ -29,6 +29,7 @@
#include "blkid-util.h"
#include "btrfs-util.h"
+#include "dirent-util.h"
#include "efivars.h"
#include "fd-util.h"
#include "fileio.h"
diff --git a/src/import/pull-common.c b/src/import/pull-common.c
index 0e918d6416..17283a4a24 100644
--- a/src/import/pull-common.c
+++ b/src/import/pull-common.c
@@ -24,6 +24,7 @@
#include "btrfs-util.h"
#include "capability.h"
#include "copy.h"
+#include "dirent-util.h"
#include "escape.h"
#include "fd-util.h"
#include "io-util.h"
diff --git a/src/journal/coredump-vacuum.c b/src/journal/coredump-vacuum.c
index bad6ea4242..9635db19e1 100644
--- a/src/journal/coredump-vacuum.c
+++ b/src/journal/coredump-vacuum.c
@@ -22,6 +22,7 @@
#include <sys/statvfs.h>
#include "coredump-vacuum.h"
+#include "dirent-util.h"
#include "fd-util.h"
#include "hashmap.h"
#include "macro.h"
diff --git a/src/journal/coredump.c b/src/journal/coredump.c
index 92f598464a..ec57920d2e 100644
--- a/src/journal/coredump.c
+++ b/src/journal/coredump.c
@@ -40,6 +40,7 @@
#include "conf-parser.h"
#include "copy.h"
#include "coredump-vacuum.h"
+#include "dirent-util.h"
#include "escape.h"
#include "fd-util.h"
#include "fileio.h"
diff --git a/src/journal/journal-vacuum.c b/src/journal/journal-vacuum.c
index 026dca4901..d3add065d2 100644
--- a/src/journal/journal-vacuum.c
+++ b/src/journal/journal-vacuum.c
@@ -25,6 +25,7 @@
#include "sd-id128.h"
+#include "dirent-util.h"
#include "fd-util.h"
#include "journal-def.h"
#include "journal-file.h"
diff --git a/src/journal/journald-server.c b/src/journal/journald-server.c
index f286e3030f..6e6d9c1c4a 100644
--- a/src/journal/journald-server.c
+++ b/src/journal/journald-server.c
@@ -36,6 +36,7 @@
#include "acl-util.h"
#include "cgroup-util.h"
#include "conf-parser.h"
+#include "dirent-util.h"
#include "extract-word.h"
#include "fd-util.h"
#include "formats-util.h"
diff --git a/src/journal/journald-stream.c b/src/journal/journald-stream.c
index 6745864da1..a9c940690f 100644
--- a/src/journal/journald-stream.c
+++ b/src/journal/journald-stream.c
@@ -29,6 +29,7 @@
#include "sd-daemon.h"
#include "sd-event.h"
+#include "dirent-util.h"
#include "escape.h"
#include "fd-util.h"
#include "fileio.h"
diff --git a/src/journal/sd-journal.c b/src/journal/sd-journal.c
index 9dcfc726ea..cfe1623e5b 100644
--- a/src/journal/sd-journal.c
+++ b/src/journal/sd-journal.c
@@ -32,6 +32,7 @@
#include "catalog.h"
#include "compress.h"
+#include "dirent-util.h"
#include "fd-util.h"
#include "fileio.h"
#include "formats-util.h"
diff --git a/src/libsystemd/sd-device/device-enumerator.c b/src/libsystemd/sd-device/device-enumerator.c
index c98053220c..e1eb5b26b3 100644
--- a/src/libsystemd/sd-device/device-enumerator.c
+++ b/src/libsystemd/sd-device/device-enumerator.c
@@ -22,6 +22,7 @@
#include "device-enumerator-private.h"
#include "device-util.h"
+#include "dirent-util.h"
#include "fd-util.h"
#include "prioq.h"
#include "set.h"
diff --git a/src/libsystemd/sd-login/sd-login.c b/src/libsystemd/sd-login/sd-login.c
index 879838601c..90ee263079 100644
--- a/src/libsystemd/sd-login/sd-login.c
+++ b/src/libsystemd/sd-login/sd-login.c
@@ -43,6 +43,7 @@
#include "strv.h"
#include "user-util.h"
#include "util.h"
+#include "dirent-util.h"
/* Error codes:
*
diff --git a/src/login/logind-acl.c b/src/login/logind-acl.c
index 4d7bda3ee0..acb2bd5765 100644
--- a/src/login/logind-acl.c
+++ b/src/login/logind-acl.c
@@ -23,6 +23,7 @@
#include <string.h>
#include "acl-util.h"
+#include "dirent-util.h"
#include "escape.h"
#include "fd-util.h"
#include "formats-util.h"
diff --git a/src/login/logind-dbus.c b/src/login/logind-dbus.c
index 61c2c9ba40..2fcf4900d3 100644
--- a/src/login/logind-dbus.c
+++ b/src/login/logind-dbus.c
@@ -30,6 +30,7 @@
#include "bus-common-errors.h"
#include "bus-error.h"
#include "bus-util.h"
+#include "dirent-util.h"
#include "efivars.h"
#include "escape.h"
#include "fd-util.h"
diff --git a/src/login/logind.c b/src/login/logind.c
index 02c87ca58e..957ea1fd7e 100644
--- a/src/login/logind.c
+++ b/src/login/logind.c
@@ -30,6 +30,7 @@
#include "bus-error.h"
#include "bus-util.h"
#include "conf-parser.h"
+#include "dirent-util.h"
#include "fd-util.h"
#include "formats-util.h"
#include "logind.h"
diff --git a/src/machine/machined.c b/src/machine/machined.c
index fe229c88a8..1a61da041d 100644
--- a/src/machine/machined.c
+++ b/src/machine/machined.c
@@ -28,6 +28,7 @@
#include "bus-error.h"
#include "bus-util.h"
#include "cgroup-util.h"
+#include "dirent-util.h"
#include "fd-util.h"
#include "formats-util.h"
#include "hostname-util.h"
diff --git a/src/shared/clean-ipc.c b/src/shared/clean-ipc.c
index 2be1bc3fc0..c60f605997 100644
--- a/src/shared/clean-ipc.c
+++ b/src/shared/clean-ipc.c
@@ -35,6 +35,7 @@
#include "string-util.h"
#include "strv.h"
#include "util.h"
+#include "dirent-util.h"
static int clean_sysvipc_shm(uid_t delete_uid) {
_cleanup_fclose_ FILE *f = NULL;
diff --git a/src/shared/efivars.c b/src/shared/efivars.c
index 771bc9458c..6e8f156a68 100644
--- a/src/shared/efivars.c
+++ b/src/shared/efivars.c
@@ -23,6 +23,7 @@
#include <string.h>
#include <fcntl.h>
+#include "dirent-util.h"
#include "efivars.h"
#include "fd-util.h"
#include "io-util.h"
diff --git a/src/shared/install.c b/src/shared/install.c
index a1720488e8..bfafb59008 100644
--- a/src/shared/install.c
+++ b/src/shared/install.c
@@ -27,8 +27,11 @@
#include "conf-files.h"
#include "conf-parser.h"
+#include "dirent-util.h"
+#include "fd-util.h"
#include "hashmap.h"
#include "install-printf.h"
+#include "install.h"
#include "mkdir.h"
#include "path-lookup.h"
#include "path-util.h"
@@ -38,8 +41,6 @@
#include "strv.h"
#include "unit-name.h"
#include "util.h"
-#include "install.h"
-#include "fd-util.h"
typedef struct {
OrderedHashmap *will_install;
diff --git a/src/shared/machine-image.c b/src/shared/machine-image.c
index 415d939fc6..485793ed5d 100644
--- a/src/shared/machine-image.c
+++ b/src/shared/machine-image.c
@@ -25,6 +25,7 @@
#include "btrfs-util.h"
#include "copy.h"
+#include "dirent-util.h"
#include "fd-util.h"
#include "machine-image.h"
#include "mkdir.h"
diff --git a/src/test/test-cgroup-util.c b/src/test/test-cgroup-util.c
index af8d478fa9..104f6327be 100644
--- a/src/test/test-cgroup-util.c
+++ b/src/test/test-cgroup-util.c
@@ -20,6 +20,7 @@
***/
#include "cgroup-util.h"
+#include "dirent-util.h"
#include "fd-util.h"
#include "formats-util.h"
#include "parse-util.h"
diff --git a/src/tty-ask-password-agent/tty-ask-password-agent.c b/src/tty-ask-password-agent/tty-ask-password-agent.c
index 33419f6962..a6240ae89a 100644
--- a/src/tty-ask-password-agent/tty-ask-password-agent.c
+++ b/src/tty-ask-password-agent/tty-ask-password-agent.c
@@ -35,6 +35,7 @@
#include "ask-password-api.h"
#include "conf-parser.h"
#include "def.h"
+#include "dirent-util.h"
#include "fd-util.h"
#include "io-util.h"
#include "mkdir.h"