diff options
author | Stefan Beller <stefanbeller@googlemail.com> | 2013-12-30 00:09:56 +0100 |
---|---|---|
committer | Kay Sievers <kay@vrfy.org> | 2013-12-30 19:10:22 +0100 |
commit | 226b735a745c1e9bbab24b47460d7304def9d38f (patch) | |
tree | 7cc3e19eff70cf7e32883208b6270fdbfef917ef /src | |
parent | 818156512411835a4a7f070e6fec3d7b80e1f629 (diff) |
bootchart: Remove unneeded check for NULL
Directly before the changed line there is:
while ((parent->next_ps && parent->pid != ps->ppid))
parent = parent->next_ps;
which looks one element ahead of the list, hence we can rely on parent
being non null here.
If 'parent' were NULL at that while loop already, it would crash as we're
dereferencing 'parent' when checking for next_ps already.
Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
Diffstat (limited to 'src')
-rw-r--r-- | src/bootchart/store.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/bootchart/store.c b/src/bootchart/store.c index 7f86cfe976..b6ba113561 100644 --- a/src/bootchart/store.c +++ b/src/bootchart/store.c @@ -345,7 +345,7 @@ schedstat_next: while ((parent->next_ps && parent->pid != ps->ppid)) parent = parent->next_ps; - if ((!parent) || (parent->pid != ps->ppid)) { + if (parent->pid != ps->ppid) { /* orphan */ ps->ppid = 1; parent = ps_first->next_ps; |