summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorTom Gundersen <teg@jklm.no>2015-04-27 11:43:31 +0200
committerAnthony G. Basile <blueness@gentoo.org>2015-05-26 13:10:27 -0400
commit1fc303749c2fdab0444a6771defcee8b7401952c (patch)
treee20a1d688f76f1ae0632b7f2a80ca809d3689dd7 /src
parentadf171757dc1bcf2c5e8b1918e057b9440f43d0e (diff)
udevd: worker - drop reference counting
Make the worker context have the same life-span as the worker process. It is created on fork() and free'd on SIGCHLD. The change means that we can get worker_returned() for a worker context that is no longer around, this is not a problem and we can just drop the message. The only use for worker_returned() is to know to reschedule events to workers that are still around, so if the worker has already exited it is not important to keep track of. We still print a debug statement in this case to be on the safe side. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Diffstat (limited to 'src')
-rw-r--r--src/udev/udevd.c62
1 files changed, 32 insertions, 30 deletions
diff --git a/src/udev/udevd.c b/src/udev/udevd.c
index 2b2b4aaf81..b7ac0ba737 100644
--- a/src/udev/udevd.c
+++ b/src/udev/udevd.c
@@ -88,6 +88,7 @@ struct event {
struct udev *udev;
struct udev_device *dev;
struct udev_device *dev_kernel;
+ struct worker *worker;
enum event_state state;
unsigned long long int delaying_seqnum;
unsigned long long int seqnum;
@@ -132,31 +133,32 @@ static inline struct worker *node_to_worker(struct udev_list_node *node) {
return container_of(node, struct worker, node);
}
-static void event_queue_delete(struct event *event) {
+static void event_free(struct event *event) {
+ if (!event)
+ return;
+
udev_list_node_remove(&event->node);
udev_device_unref(event->dev);
udev_device_unref(event->dev_kernel);
+
+ if (event->worker)
+ event->worker->event = NULL;
+
free(event);
}
-static struct worker *worker_ref(struct worker *worker) {
- worker->refcount++;
- return worker;
-}
+static void worker_free(struct worker *worker) {
+ if (!worker)
+ return;
-static void worker_cleanup(struct worker *worker) {
udev_list_node_remove(&worker->node);
udev_monitor_unref(worker->monitor);
udev_unref(worker->udev);
+ event_free(worker->event);
+
children--;
- free(worker);
-}
-static void worker_unref(struct worker *worker) {
- if (!worker || --worker->refcount > 0)
- return;
- log_debug("worker ["PID_FMT"] cleaned up", worker->pid);
- worker_cleanup(worker);
+ free(worker);
}
static void worker_list_cleanup(struct udev *udev) {
@@ -165,7 +167,7 @@ static void worker_list_cleanup(struct udev *udev) {
udev_list_node_foreach_safe(loop, tmp, &worker_list) {
struct worker *worker = node_to_worker(loop);
- worker_cleanup(worker);
+ worker_free(worker);
}
}
@@ -196,12 +198,17 @@ static int worker_new(struct worker **ret, struct udev *udev, struct udev_monito
}
static void worker_attach_event(struct worker *worker, struct event *event) {
+ assert(worker);
+ assert(event);
+ assert(!event->worker);
+ assert(!worker->event);
+
worker->state = WORKER_RUNNING;
worker->event = event;
event->state = EVENT_RUNNING;
event->start_usec = now(CLOCK_MONOTONIC);
event->warned = false;
- worker_ref(worker);
+ event->worker = worker;
}
static void worker_spawn(struct event *event) {
@@ -597,7 +604,7 @@ static void event_queue_cleanup(struct udev *udev, enum event_state match_type)
if (match_type != EVENT_UNDEF && match_type != event->state)
continue;
- event_queue_delete(event);
+ event_free(event);
}
}
@@ -659,19 +666,17 @@ static void worker_returned(int fd_worker) {
else
found = true;
- /* worker returned */
- if (worker->event) {
- event_queue_delete(worker->event);
- worker->event = NULL;
- }
if (worker->state != WORKER_KILLED)
worker->state = WORKER_IDLE;
- worker_unref(worker);
+
+ /* worker returned */
+ event_free(worker->event);
+
break;
}
if (!found)
- log_warning("unknown worker ["PID_FMT"] returned", ucred->pid);
+ log_debug("worker ["PID_FMT"] returned, but is no longer tracked", ucred->pid);
}
}
@@ -941,20 +946,17 @@ static void handle_signal(struct udev *udev, int signo) {
if (!WIFEXITED(status) || WEXITSTATUS(status) != 0) {
if (worker->event) {
- log_error("worker ["PID_FMT"] failed while handling '%s'",
- pid, worker->event->devpath);
+ log_error("worker ["PID_FMT"] failed while handling '%s'", pid, worker->event->devpath);
/* delete state from disk */
udev_device_delete_db(worker->event->dev);
udev_device_tag_index(worker->event->dev, NULL, false);
/* forward kernel event without amending it */
udev_monitor_send_device(monitor, NULL, worker->event->dev_kernel);
- event_queue_delete(worker->event);
-
- /* drop reference taken for state 'running' */
- worker_unref(worker);
}
}
- worker_unref(worker);
+
+ worker_free(worker);
+
break;
}