diff options
| author | Alan Jenkins <alan-jenkins@tuffmail.co.uk> | 2008-09-29 16:01:32 +0100 |
|---|---|---|
| committer | Kay Sievers <kay.sievers@vrfy.org> | 2008-09-29 17:06:00 +0200 |
| commit | 659353f5a9a52336c41cf595d933311b8dc48937 (patch) | |
| tree | 1a12cc4fd2ec90db52a0f586e08a2f49a6ca8306 /udev/udev_rules_parse.c | |
| parent | 5c0f595d91a21b1fba2b9edd89511a072036d0e8 (diff) | |
replace strerror() usage with threadsafe "%m" format string
strerror() is not threadsafe. It uses a buffer to build messages of the form
"Unknown error 387689".
syslog() provides a %m format which is equivalent to strerror(errno).
As a GNU extension, this is also accepted by printf and friends.
At least in the current implementation, it is correctly threadsafe.
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Diffstat (limited to 'udev/udev_rules_parse.c')
| -rw-r--r-- | udev/udev_rules_parse.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/udev/udev_rules_parse.c b/udev/udev_rules_parse.c index 5a76889c84..81ba51fe0f 100644 --- a/udev/udev_rules_parse.c +++ b/udev/udev_rules_parse.c @@ -692,7 +692,7 @@ static int parse_file(struct udev_rules *rules, const char *filename) start = rules->bufsize; if (file_map(filename, &buf, &bufsize) != 0) { - err(rules->udev, "can't open '%s' as rules file: %s\n", filename, strerror(errno)); + err(rules->udev, "can't open '%s' as rules file: %m\n", filename); return -1; } info(rules->udev, "reading '%s' as rules file\n", filename); @@ -831,7 +831,7 @@ int udev_rules_init(struct udev *udev, struct udev_rules *rules, int resolve_nam else dbg(udev, "empty rules file '%s'\n", name_loop->name); } else - err(udev, "could not read '%s': %s\n", name_loop->name, strerror(errno)); + err(udev, "could not read '%s': %m\n", name_loop->name); list_del(&name_loop->node); free(name_loop); } |