summaryrefslogtreecommitdiff
path: root/udevtest.c
diff options
context:
space:
mode:
authorkay.sievers@vrfy.org <kay.sievers@vrfy.org>2004-09-10 21:09:25 -0700
committerGreg KH <gregkh@suse.de>2005-04-26 21:37:00 -0700
commitaee380b6d8f849c21a5cc54e5d8f2a43fb88b2f2 (patch)
treecc143c641911a944e59859e38ff140202e0bbcee /udevtest.c
parent0a8dd7f37c6f788c74aa528949c45aca66638e5a (diff)
[PATCH] Fix naming ethernet devices in udevstart
On Tue, Sep 07, 2004 at 12:46:43PM +0200, Kay Sievers wrote: > On Mon, 2004-09-06 at 20:18 -0700, Tom Rini wrote: > > I noticed somewhat recently that my enet devices weren't being renamed > > on boot anymore. I don't quite know when this got broken (or rather, if > > it was supposed to be working. I swear it worked for me once..), but > > the following seems to do it. > > I think it never worked in the udevstart case. It worked only with the > hotplug-event-udev, I expect. > > > In udev_scan_class(), look for not just > > %s/%s/dev (which everything with a dev node has), but %s/%s/dev* (both > > of my enet devices, sis900 & 3c59x only have device) and if that > > exists, pass this along to udev. > > Yeah, network devices don't have a devnode and therefore no "dev", but > they are all in /sys/class/net/. We may just test if we are there > instead of the "device" match. How about something like this. It adds all the net devices without looking at the attributes and keeps the remaining logic like it is. It also removes certain levels of indirection and much simplifies the udevstart process. We surely don't need to open and close the udevdb for every node while iterating over the list. (We are about 5% faster on my box) It's not well tested, so it would be nice if someone can have a look at it, before a broken udevstart renders any system unbootable.
Diffstat (limited to 'udevtest.c')
-rw-r--r--udevtest.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/udevtest.c b/udevtest.c
index 36f223e1e5..f24c7e4ba5 100644
--- a/udevtest.c
+++ b/udevtest.c
@@ -102,7 +102,7 @@ int main(int argc, char *argv[], char *envp[])
subsystem = argv[2];
/* simulate node creation with fake flag */
- udev_add_device(devpath, subsystem, fake);
+ udev_add_device(devpath, subsystem, FAKE);
exit:
return 0;