diff options
author | David Herrmann <dh.herrmann@gmail.com> | 2015-10-28 19:11:36 +0100 |
---|---|---|
committer | David Herrmann <dh.herrmann@gmail.com> | 2015-10-28 19:11:36 +0100 |
commit | b215b0ede11c0dda90009c8412609d2416150075 (patch) | |
tree | 43eb98447bc9cd3f0ff624b2b94f34a8d1806126 /units/machines.target | |
parent | df5b3e1840a373dca1e3da5b81540b7862994ab4 (diff) |
core: fix priority ordering in notify-handling
Currently, we dispatch NOTIFY messages in a tight loop. Regardless how
much data is incoming, we always dispatch everything that is queued.
This, however, completely breaks priority event-handling of sd-event.
When dispatching one NOTIFY event, another completely different event
might fire, or might be queued by the NOTIFY handling. However, this
event will not get dispatched until all other further NOTIFY messages are
handled. Those might even arrive _after_ the other event fired, and as
such completely break priority ordering of sd-event (which several code
paths rely on).
Break this by never dispatching multiple messages. Just return after each
message that was read and let sd-event handle everything else.
(The patch looks scarier that it is. It basically just drops the for(;;)
loop and re-indents the loop-content.)
Diffstat (limited to 'units/machines.target')
0 files changed, 0 insertions, 0 deletions