diff options
author | David Herrmann <dh.herrmann@gmail.com> | 2015-06-24 13:27:34 +0200 |
---|---|---|
committer | David Herrmann <dh.herrmann@gmail.com> | 2015-06-24 13:46:15 +0200 |
commit | dd906398dd0aa8582bdba519a2026278359c2888 (patch) | |
tree | 46af83a85fdbe052f8a86fcceac6f253f534424e /units/proc-sys-fs-binfmt_misc.mount | |
parent | 846a6b3d89aaf4ee2cece0f10148f675c4796841 (diff) |
sd-netlink: don't export internal type-system details
The kernel bonding layer allows passing an array of ARP IP targets as
bond-configuration. Due to the weird implementation of arrays in netlink
(which we haven't figure out a generic way to support, yet), we usually
hard-code the supported array-sizes. However, this should not be exported
from sd-netlink.
Instead, make sure the caller just uses it's current hack of enumerating
the types, and the sd-netlink core will have it's own list of supported
array-sizes (to be removed in future extensions, btw!). If either does not
match, we will just return a normal error.
Note that we provide 2 constants for ARP_IP_TARGETS_MAX now. However, both
have very different reasons:
- the constant in netdev-bond.c is used to warn the user that the given
number of targets might not be supported by the kernel (even though the
kernel might increase that number at _any_ time)
- the constant in sd-netlink is solely used due to us missing a proper
array implementation. Once that's supported in the type-system, it can
be removed without notice
Last but not least, this patch turns the log_error() into a log_warning().
Given that the previous condition was off-by-one, anyway, it never hit at
the right time. Thus, it was probably of no real use.
Diffstat (limited to 'units/proc-sys-fs-binfmt_misc.mount')
0 files changed, 0 insertions, 0 deletions