summaryrefslogtreecommitdiff
path: root/units/sound.target
diff options
context:
space:
mode:
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2013-03-26 19:37:14 -0400
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2013-03-26 23:49:44 -0400
commit3baed19327663d012c3313b72cc5b3d02a58720a (patch)
tree6a55c48aa5c3a9b5cfb277f235ff8e97d7af2b10 /units/sound.target
parenta63a5c4687d192d89eea9715db2a56c810111de8 (diff)
Simplify the meaning of %s
The rules governing %s where just too complicated. First of all, looking at $SHELL is dangerous. For systemd --system, it usually wouldn't be set. But it could be set if the admin first started a debug shell, let's say /sbin/sash, and then launched systemd from it. This shouldn't influence how daemons are started later on, so is better ignored. Similar reasoning holds for session mode. Some shells set $SHELL, while other set it only when it wasn't set previously (e.g. zsh). This results in fragility that is better avoided by ignoring $SHELL totally. With $SHELL out of the way, simplify things by saying that %s==/bin/sh for root, and the configured shell otherwise. get_shell() is the only caller, so it can be inlined. Fixes one issue seen with 'make check'.
Diffstat (limited to 'units/sound.target')
0 files changed, 0 insertions, 0 deletions