diff options
author | Michal Schmidt <mschmidt@redhat.com> | 2014-12-19 14:42:55 +0100 |
---|---|---|
committer | Michal Schmidt <mschmidt@redhat.com> | 2014-12-19 16:15:21 +0100 |
commit | b29ddfcb389127cf00ab41447a721e479fe15713 (patch) | |
tree | 53f8001eeadf23229b54cb1c7f91618f065ac6b6 /units | |
parent | 487d37209b30a536636c95479cfeba931fea25c5 (diff) |
journal: make next_with_matches() always use f->current_offset
next_with_matches() is odd in that its "unit64_t *offset" parameter is
both input and output. In other it's purely for output.
The function is called from two places in next_beyond_location(). In
both of them "&cp" is used as the argument and in both cases cp is
guaranteed to equal f->current_offset.
Let's just have next_with_matches() ignore "*offset" on input and
operate with f->current_offset.
I did not investigate why it is, but it makes my usual benchmark run
reproducibly faster:
$ time ./journalctl --since=2014-06-01 --until=2014-07-01 > /dev/null
real 0m4.032s
user 0m3.896s
sys 0m0.135s
(Compare to preceding commit, where real was 4.4s.)
Diffstat (limited to 'units')
0 files changed, 0 insertions, 0 deletions