diff options
| -rw-r--r-- | TODO | 12 | ||||
| -rw-r--r-- | src/shared/unit-name.c | 35 | ||||
| -rw-r--r-- | src/test/test-unit-name.c | 24 |
3 files changed, 50 insertions, 21 deletions
@@ -49,6 +49,18 @@ Bugfixes: Features: +* perfomance messages for selinux are gone from debug log? + +* http://lists.freedesktop.org/archives/systemd-devel/2012-September/006502.html + +* don't use writev() in tmpfiles for sake of compat with sysfs? + +* come up with a nice way to write queue/read_ahead_kb for a block device without interfering with readahead + +* journald: add kernel cmdline option to disable ratelimiting for debug purposes + +* Add a way to reference the machine/boot ID from ExecStart= and similar command lines + * move PID 1 segfaults to /var/lib/systemd/coredump? * Document word splitting syntax for ExecStart= and friends diff --git a/src/shared/unit-name.c b/src/shared/unit-name.c index 7193718792..d6391228f2 100644 --- a/src/shared/unit-name.c +++ b/src/shared/unit-name.c @@ -357,36 +357,29 @@ bool unit_name_is_instance(const char *n) { char *unit_name_replace_instance(const char *f, const char *i) { const char *p, *e; char *r, *k; - size_t a; + size_t a, b; assert(f); p = strchr(f, '@'); - assert_se(e = strrchr(f, '.')); - - a = p - f; - - if (p) { - size_t b; - - b = strlen(i); - - r = new(char, a + 1 + b + strlen(e) + 1); - if (!r) - return NULL; + if (!p) + return strdup(f); - k = mempcpy(r, f, a + 1); - k = mempcpy(k, i, b); - } else { + e = strrchr(f, '.'); + if (!e) + assert_se(e = strchr(f, 0)); - r = new(char, a + strlen(e) + 1); - if (!r) - return NULL; + a = p - f; + b = strlen(i); - k = mempcpy(r, f, a); - } + r = new(char, a + 1 + b + strlen(e) + 1); + if (!r) + return NULL; + k = mempcpy(r, f, a + 1); + k = mempcpy(k, i, b); strcpy(k, e); + return r; } diff --git a/src/test/test-unit-name.c b/src/test/test-unit-name.c index 392e358ac2..cf434558c3 100644 --- a/src/test/test-unit-name.c +++ b/src/test/test-unit-name.c @@ -29,6 +29,30 @@ int main(int argc, char* argv[]) { char *t, *k; + t = unit_name_replace_instance("foo@.service", "waldo"); + puts(t); + free(t); + + t = unit_name_replace_instance("foo@xyz.service", "waldo"); + puts(t); + free(t); + + t = unit_name_replace_instance("xyz", "waldo"); + puts(t); + free(t); + + t = unit_name_replace_instance("", "waldo"); + puts(t); + free(t); + + t = unit_name_replace_instance("", ""); + puts(t); + free(t); + + t = unit_name_replace_instance("foo.service", "waldo"); + puts(t); + free(t); + t = unit_name_from_path("/waldo", ".mount"); puts(t); k = unit_name_to_path(t); |