diff options
-rw-r--r-- | man/coredump.conf.xml | 2 | ||||
-rw-r--r-- | man/custom-html.xsl | 2 | ||||
-rw-r--r-- | man/machinectl.xml | 4 | ||||
-rw-r--r-- | man/sd-bus-errors.xml | 4 | ||||
-rw-r--r-- | man/sd_bus_message_append_array.xml | 8 | ||||
-rw-r--r-- | man/sd_bus_negotiate_fds.xml | 2 | ||||
-rw-r--r-- | man/systemd-coredump.xml | 4 | ||||
-rw-r--r-- | man/systemd-journald.service.xml | 2 | ||||
-rw-r--r-- | man/systemd.journal-fields.xml | 2 | ||||
-rw-r--r-- | man/systemd.link.xml | 9 | ||||
-rw-r--r-- | man/systemd.netdev.xml | 27 | ||||
-rw-r--r-- | man/systemd.network.xml | 61 | ||||
-rw-r--r-- | man/systemd.socket.xml | 2 | ||||
-rw-r--r-- | src/boot/bootctl.c | 2 | ||||
-rw-r--r-- | src/boot/efi/boot.c | 17 | ||||
-rw-r--r-- | src/bus-proxyd/proxy.c | 2 | ||||
-rw-r--r-- | src/libsystemd/sd-netlink/netlink-types.c | 20 | ||||
-rw-r--r-- | src/network/networkd-link.c | 4 | ||||
-rw-r--r-- | src/network/networkd-netdev-gperf.gperf | 2 | ||||
-rw-r--r-- | src/network/networkd-netdev-tunnel.c | 2 | ||||
-rw-r--r-- | src/network/networkd-netdev-tunnel.h | 2 | ||||
-rw-r--r-- | src/network/networkd-network-gperf.gperf | 4 | ||||
-rw-r--r-- | src/network/networkd-network.c | 4 | ||||
-rw-r--r-- | src/network/networkd.h | 4 | ||||
-rw-r--r-- | src/udev/ata_id/ata_id.c | 1 |
25 files changed, 104 insertions, 89 deletions
diff --git a/man/coredump.conf.xml b/man/coredump.conf.xml index fd54c59e6b..8e71f7d4ec 100644 --- a/man/coredump.conf.xml +++ b/man/coredump.conf.xml @@ -58,7 +58,7 @@ <refsect1> <title>Description</title> - <para>These files configure the behaviour of + <para>These files configure the behavior of <citerefentry><refentrytitle>systemd-coredump</refentrytitle><manvolnum>8</manvolnum></citerefentry>, a handler for core dumps invoked by the kernel.</para> </refsect1> diff --git a/man/custom-html.xsl b/man/custom-html.xsl index 151276362c..3e266e4a7f 100644 --- a/man/custom-html.xsl +++ b/man/custom-html.xsl @@ -125,7 +125,7 @@ <!-- - helper template to do conflict resolution between various headings with the same inferred ID attribute/tag from the headerlink template - - this conflict resolution is necessary to prevent malformed HTML ouput (multiple id attributes with the same value) + - this conflict resolution is necessary to prevent malformed HTML output (multiple id attributes with the same value) - and it fixes xsltproc warnings during compilation of HTML man pages - - A simple top-to-bottom numbering scheme is implemented for nodes with the same ID value to derive unique ID values for HTML output. diff --git a/man/machinectl.xml b/man/machinectl.xml index 4b87870853..a5eb3f08e4 100644 --- a/man/machinectl.xml +++ b/man/machinectl.xml @@ -593,7 +593,7 @@ <filename>/var/lib/machines/</filename>, that is named after the specified URL and its HTTP etag. A writable snapshot is then taken from this subvolume, and named after the specified - local name. This behaviour ensures that creating multiple + local name. This behavior ensures that creating multiple container instances of the same URL is efficient, as multiple downloads are not necessary. In order to create only the read-only image, and avoid creating its writable snapshot, @@ -639,7 +639,7 @@ machine name. To omit creation of the local, writable copy pass <literal>-</literal> as local machine name.</para> - <para>Similar to the behaviour of <command>pull-tar</command>, + <para>Similar to the behavior of <command>pull-tar</command>, the read-only image is prefixed with <filename>.raw-</filename>, and thus not shown by <command>list-images</command>, unless <option>--all</option> diff --git a/man/sd-bus-errors.xml b/man/sd-bus-errors.xml index d6bbd7fbb2..a1e8462858 100644 --- a/man/sd-bus-errors.xml +++ b/man/sd-bus-errors.xml @@ -138,7 +138,7 @@ <term><varname>SD_BUS_ERROR_FAILED</varname></term> <listitem><para>A generic error indication. See the error message for further details. This error name should be - avoided, in favour of a more expressive error + avoided, in favor of a more expressive error name.</para></listitem> </varlistentry> @@ -186,7 +186,7 @@ </varlistentry> <varlistentry> <term><varname>SD_BUS_ERROR_ACCESS_DENIED</varname></term> - <listitem><para>Access to a resource has bee denied, due to security restrictions.</para></listitem> + <listitem><para>Access to a resource has been denied, due to security restrictions.</para></listitem> </varlistentry> <varlistentry> <term><varname>SD_BUS_ERROR_AUTH_FAILED</varname></term> diff --git a/man/sd_bus_message_append_array.xml b/man/sd_bus_message_append_array.xml index 034466bf9c..37cadb9d0f 100644 --- a/man/sd_bus_message_append_array.xml +++ b/man/sd_bus_message_append_array.xml @@ -49,7 +49,7 @@ <refname>sd_bus_message_append_array_iovec</refname> <refname>sd_bus_message_append_array_space</refname> - <refpurpose>Appaned an array of fields to a D-Bus + <refpurpose>Append an array of fields to a D-Bus message</refpurpose> </refnamediv> @@ -125,7 +125,7 @@ <parameter>m</parameter>, similar to <function>sd_bus_message_append_array()</function>. The contents of the memory file descriptor <parameter>memfd</parameter> - starting at the specified offset and and of the specified size is + starting at the specified offset and of the specified size is used as the contents of the array. The offset and size must be a multiple of the size of the type <parameter>type</parameter>. However, as a special exception, if @@ -173,7 +173,7 @@ <parameter>p</parameter>. The caller should subsequently write the array contents to this memory. Modifications of the memory pointed to should only occur until the next operation on the bus - message is invoked, most imporantly the memory should not be + message is invoked, most importantly the memory should not be altered anymore when another field has been added to the message or the message has been sealed.</para> </refsect1> @@ -182,7 +182,7 @@ <title>Return Value</title> <para>On success, these calls return 0 or a positive integer. On - failure, they returns a negative errno-style error code.</para> + failure, they return a negative errno-style error code.</para> </refsect1> <xi:include href="sd_bus_message_append_basic.xml" xpointer="errors" /> diff --git a/man/sd_bus_negotiate_fds.xml b/man/sd_bus_negotiate_fds.xml index 1be44e2785..f53ea9e41a 100644 --- a/man/sd_bus_negotiate_fds.xml +++ b/man/sd_bus_negotiate_fds.xml @@ -152,7 +152,7 @@ <refsect1> <title>Return Value</title> - <para>On success, these functions returns 0 or a + <para>On success, these functions return 0 or a positive integer. On failure, they return a negative errno-style error code.</para> </refsect1> diff --git a/man/systemd-coredump.xml b/man/systemd-coredump.xml index 5da3857c08..cb46d41902 100644 --- a/man/systemd-coredump.xml +++ b/man/systemd-coredump.xml @@ -67,7 +67,7 @@ overridden to use a different setting following normal <citerefentry><refentrytitle>sysctl.d</refentrytitle><manvolnum>5</manvolnum></citerefentry> rules.</para> - <para>The behaviour of a specific program upon reception of a + <para>The behavior of a specific program upon reception of a signal is governed by a few factors which are described in detail in <citerefentry project='man-pages'><refentrytitle>core</refentrytitle><manvolnum>5</manvolnum></citerefentry>. In particular, the coredump will only be processed when the @@ -81,7 +81,7 @@ including a backtrace if possible, and store the core (contents of process' memory contents) in an external file on disk in <filename>/var/lib/systemd/coredump</filename>, or directly in - the journal. This behaviour may be modified using + the journal. This behavior may be modified using <citerefentry><refentrytitle>coredump.conf</refentrytitle><manvolnum>5</manvolnum></citerefentry>.</para> <para>Apart from the diff --git a/man/systemd-journald.service.xml b/man/systemd-journald.service.xml index 8280d6c874..dae6ee6042 100644 --- a/man/systemd-journald.service.xml +++ b/man/systemd-journald.service.xml @@ -203,7 +203,7 @@ <listitem><para>Configure <command>systemd-journald</command> - behaviour. See + behavior. See <citerefentry><refentrytitle>journald.conf</refentrytitle><manvolnum>5</manvolnum></citerefentry>. </para></listitem> </varlistentry> diff --git a/man/systemd.journal-fields.xml b/man/systemd.journal-fields.xml index afe1200d7e..49f44d2922 100644 --- a/man/systemd.journal-fields.xml +++ b/man/systemd.journal-fields.xml @@ -73,7 +73,7 @@ <para>The human-readable message string for this entry. This is supposed to be the primary text shown to the user. It is usually not translated (but might be in some cases), and is - not supposed to be parsed for meta data.</para> + not supposed to be parsed for metadata.</para> </listitem> </varlistentry> diff --git a/man/systemd.link.xml b/man/systemd.link.xml index d9b1879c59..b630ef7a17 100644 --- a/man/systemd.link.xml +++ b/man/systemd.link.xml @@ -68,11 +68,10 @@ in <filename>/etc</filename> have the highest priority, files in <filename>/run</filename> take precedence over files with the same name in <filename>/usr/lib</filename>. This can be used to - override a system-supplied link file with a local file if needed; - a symlink in <filename>/etc</filename> with the same name as a - link file in <filename>/usr/lib</filename>, pointing to - <filename>/dev/null</filename>, disables the link file - entirely.</para> + override a system-supplied link file with a local file if needed. + As a special case, an empty file (file size 0) or symlink with the + same name pointing to <filename>/dev/null</filename>, disable the + configuration file entirely (it is "masked").</para> <para>The link file contains a <literal>[Match]</literal> section, which determines if a given link file may be applied to a given diff --git a/man/systemd.netdev.xml b/man/systemd.netdev.xml index b100f96b85..6287a00f9d 100644 --- a/man/systemd.netdev.xml +++ b/man/systemd.netdev.xml @@ -80,11 +80,9 @@ <filename>/run</filename> take precedence over files with the same name in <filename>/usr/lib</filename>. This can be used to override a system-supplied configuration file with a local file if - needed; a symlink in <filename>/etc</filename> with the same name - as a configuration file in <filename>/usr/lib</filename>, pointing - to <filename>/dev/null</filename>, disables the configuration file - entirely.</para> - + needed. As a special case, an empty file (file size 0) or symlink + with the same name pointing to <filename>/dev/null</filename>, + disable the configuration file entirely (it is "masked").</para> </refsect1> <refsect1> @@ -500,17 +498,18 @@ A Flow Label of zero is used to indicate packets that have not been labeled. Takes following values. When <literal>inherit</literal> it uses the original flowlabel, - or can be configured to any value betwen 0 to 0xFFFFF.</para> + or can be configured to any value between 0 to 0xFFFFF.</para> </listitem> </varlistentry> <varlistentry> - <term><varname>DiffServiceCodePoint=</varname></term> + <term><varname>CopyDSCP=</varname></term> <listitem> - <para>A boolean. When true, inherits the Differentiated - Service Code Point (DSCP) field between inner and outer - header for ip6_tunnel. DSCP is a field in an IP packet - that enables different levels of service to be assigned - to network traffic. Defaults to <literal>no</literal>. + <para>A boolean. When true, the Differentiated Service Code + Point (DSCP) field will be copied to the inner header from + outer header during the decapsulation of an IPv6 tunnel + packet. DSCP is a field in an IP packet that enables different + levels of service to be assigned to network traffic. + Defaults to <literal>no</literal>. </para> </listitem> </varlistentry> @@ -678,7 +677,7 @@ <listitem> <para>Specifies the frequency that Media Independent Interface link monitoring will occur. A value of zero - disables MII link monitoring. This values is rounded down to + disables MII link monitoring. This value is rounded down to the nearest millisecond. The default value is 0.</para> </listitem> </varlistentry> @@ -822,7 +821,7 @@ <listitem> <para> Specify the number of packets to transmit through a slave before moving to the next one. When set to 0 then a slave is chosen at - random.The valid range is (0 - 65535). Defaults to 1. This option + random. The valid range is (0 - 65535). Defaults to 1. This option has effect only in balance-rr mode. </para> </listitem> diff --git a/man/systemd.network.xml b/man/systemd.network.xml index d654db4993..e44491cc2e 100644 --- a/man/systemd.network.xml +++ b/man/systemd.network.xml @@ -76,11 +76,9 @@ <filename>/run</filename> take precedence over files with the same name in <filename>/usr/lib</filename>. This can be used to override a system-supplied configuration file with a local file if - needed; a symlink in <filename>/etc</filename> with the same name - as a configuration file in <filename>/usr/lib</filename>, pointing - to <filename>/dev/null</filename>, disables the configuration file - entirely.</para> - + needed. As a special case, an empty file (file size 0) or symlink + with the same name pointing to <filename>/dev/null</filename>, + disable the configuration file entirely (it is "masked").</para> </refsect1> <refsect1> @@ -288,7 +286,7 @@ <term><varname>BindCarrier=</varname></term> <listitem> <para>A port or a list of ports. When set, controls the - behaviour of the current interface. When all ports in the list + behavior of the current interface. When all ports in the list are in an operational down state, the current interface is brought down. When at least one port has carrier, the current interface is brought up. @@ -576,22 +574,23 @@ <varlistentry> <term><varname>SendHostname=</varname></term> <listitem> - <para>When true (the default), the machine's hostname will be sent to the DHCP - server</para> + <para>When true (the default), the machine's hostname will + be sent to the DHCP server.</para> </listitem> </varlistentry> <varlistentry> <term><varname>UseHostname=</varname></term> <listitem> <para>When true (the default), the hostname received from - the DHCP server will be used as the transient - hostname.</para> + the DHCP server will be used as the transient hostname. + </para> </listitem> </varlistentry> <varlistentry> <term><varname>Hostname=</varname></term> <listitem> - <para>Hostname is a option to override the machine's hostname that will be sent to the DHCP server</para> + <para>Use this value for the hostname which is sent to the + DHCP server, instead of machine's hostname.</para> </listitem> </varlistentry> <varlistentry> @@ -671,51 +670,51 @@ <varlistentry> <term><varname>UnicastFlood=</varname></term> <listitem> - <para>A boolean. UnicastFlood configures whether a given port will flood - unicast traffic for which there is no FDB entry. By default this - flag is off.</para> + <para>A boolean. Controls whether the bridge should flood + traffic for which an FDB entry is missing and the destination + is unknown through this port. Defaults to on. + </para> </listitem> </varlistentry> <varlistentry> <term><varname>HairPin=</varname></term> <listitem> - <para> A boolean. Configures whether traffic may be send back - out of the port on which it was received. By default, this - flag is false. and the bridge will not forward traffic back - out of the receiving port. By default the flag is off.</para> + <para>A boolean. Configures whether traffic may be sent back + out of the port on which it was received. By default, this + flag is false, and the bridge will not forward traffic back + out of the receiving port.</para> </listitem> </varlistentry> <varlistentry> - <term><varname>BPDUGuard=</varname></term> + <term><varname>UseBPDU=</varname></term> <listitem> - <para> A boolean. Configures whether STP Bridge Protocol Data Units will be - processed by the bridge port. By default, the flag is false allowing BPDU - processing. Turning this flag on will cause the port to stop processing - STP Bridge Protocol Data Units. By default the flag is off.</para> + <para>A boolean. Configures whether STP Bridge Protocol Data Units will be + processed by the bridge port. Defaults to yes.</para> </listitem> </varlistentry> <varlistentry> <term><varname>FastLeave=</varname></term> <listitem> - <para> A boolean. This flag allows the bridge to immediately stop multicast + <para>A boolean. This flag allows the bridge to immediately stop multicast traffic on a port that receives IGMP Leave message. It is only used with - IGMP snooping if enabled on the bridge. By default the flag is off.</para> + IGMP snooping if enabled on the bridge. Defaults to off.</para> </listitem> </varlistentry> <varlistentry> - <term><varname>RootBlock=</varname></term> + <term><varname>AllowPortToBeRoot=</varname></term> <listitem> - <para> A boolean. Configures whether a given port is allowed to - become root port or not. Only used when STP is enabled on the bridge. - By default the flag is off.</para> + <para>A boolean. Configures whether a given port is allowed to + become a root port. Only used when STP is enabled on the bridge. + Defaults to on.</para> </listitem> </varlistentry> <varlistentry> <term><varname>Cost=</varname></term> <listitem> - <para>Each port in a bridge may have different speed. Cost + <para>Sets the "cost" of sending packets of this interface. + Each port in a bridge may have different speed and the cost is used to decide which link to use. Faster interfaces - should have lower costs</para> + should have lower costs.</para> </listitem> </varlistentry> </variablelist> diff --git a/man/systemd.socket.xml b/man/systemd.socket.xml index 1e9778bc2a..36fa3a86be 100644 --- a/man/systemd.socket.xml +++ b/man/systemd.socket.xml @@ -462,7 +462,7 @@ and the kernel will ignore initial ACK packets without any data. The argument specifies the approximate amount of time the kernel should wait for incoming data before falling back - to the normal behaviour of honouring empty ACK packets. This + to the normal behavior of honouring empty ACK packets. This option is beneficial for protocols where the client sends the data first (e.g. HTTP, in contrast to SMTP), because the server process will not be woken up unnecessarily before it diff --git a/src/boot/bootctl.c b/src/boot/bootctl.c index faab82dbb8..091ea375d3 100644 --- a/src/boot/bootctl.c +++ b/src/boot/bootctl.c @@ -294,6 +294,8 @@ static int status_binaries(const char *esp_path, sd_id128_t partition) { else if (r < 0) return r; + printf("\n"); + return 0; } diff --git a/src/boot/efi/boot.c b/src/boot/efi/boot.c index 827c11844c..e8cd8abd26 100644 --- a/src/boot/efi/boot.c +++ b/src/boot/efi/boot.c @@ -1495,6 +1495,7 @@ static VOID config_entry_add_osx(Config *config) { static VOID config_entry_add_linux( Config *config, EFI_LOADED_IMAGE *loaded_image, EFI_FILE *root_dir) { EFI_FILE_HANDLE linux_dir; EFI_STATUS err; + ConfigEntry *entry; err = uefi_call_wrapper(root_dir->Open, 5, root_dir, &linux_dir, L"\\EFI\\Linux", EFI_FILE_MODE_READ, 0ULL); if (!EFI_ERROR(err)) { @@ -1504,6 +1505,7 @@ static VOID config_entry_add_linux( Config *config, EFI_LOADED_IMAGE *loaded_ima EFI_FILE_INFO *f; CHAR8 *sections[] = { (UINT8 *)".osrel", + (UINT8 *)".cmdline", NULL }; UINTN offs[ELEMENTSOF(sections)-1] = {}; @@ -1535,7 +1537,7 @@ static VOID config_entry_add_linux( Config *config, EFI_LOADED_IMAGE *loaded_ima if (StriCmp(f->FileName + len - 4, L".efi") != 0) continue; - /* look for an .osrel section in the .efi binary */ + /* look for .osrel and .cmdline sections in the .efi binary */ err = pefile_locate_sections(linux_dir, f->FileName, sections, addrs, offs, szs); if (EFI_ERROR(err)) continue; @@ -1575,10 +1577,21 @@ static VOID config_entry_add_linux( Config *config, EFI_LOADED_IMAGE *loaded_ima if (os_name && os_id && (os_version || os_build)) { CHAR16 *conf; CHAR16 *path; + CHAR16 *cmdline; conf = PoolPrint(L"%s-%s", os_id, os_version ? : os_build); path = PoolPrint(L"\\EFI\\Linux\\%s", f->FileName); - config_entry_add_loader(config, loaded_image->DeviceHandle, LOADER_LINUX, conf, 'l', os_name, path); + entry = config_entry_add_loader(config, loaded_image->DeviceHandle, LOADER_LINUX, conf, 'l', os_name, path); + + FreePool(content); + /* read the embedded cmdline file */ + len = file_read(linux_dir, f->FileName, offs[1], szs[1] - 1 , &content); + if (len > 0) { + cmdline = stra_to_str(content); + entry->options = cmdline; + cmdline = NULL; + } + FreePool(cmdline); FreePool(conf); FreePool(path); } diff --git a/src/bus-proxyd/proxy.c b/src/bus-proxyd/proxy.c index 89c68134fc..7163d6daef 100644 --- a/src/bus-proxyd/proxy.c +++ b/src/bus-proxyd/proxy.c @@ -733,7 +733,7 @@ static int proxy_process_destination_to_local(Proxy *p) { /* discard broadcasts that were not matched by any MATCH rule */ if (!matched && !sd_bus_message_get_destination(m)) { if (!matched_synthetic) - log_warning("Dropped unmatched broadcast: uid=" UID_FMT " gid=" GID_FMT" message=%s path=%s interface=%s member=%s", + log_debug("Dropped unmatched broadcast: uid=" UID_FMT " gid=" GID_FMT" message=%s path=%s interface=%s member=%s", p->local_creds.uid, p->local_creds.gid, bus_message_type_to_string(m->header->type), strna(m->path), strna(m->interface), strna(m->member)); return 1; diff --git a/src/libsystemd/sd-netlink/netlink-types.c b/src/libsystemd/sd-netlink/netlink-types.c index ff1b8a260f..9b68935245 100644 --- a/src/libsystemd/sd-netlink/netlink-types.c +++ b/src/libsystemd/sd-netlink/netlink-types.c @@ -196,10 +196,10 @@ static const NLType rtnl_link_info_data_iptun_types[IFLA_IPTUN_MAX + 1] = { [IFLA_IPTUN_6RD_RELAY_PREFIX] = { .type = NETLINK_TYPE_U32 }, [IFLA_IPTUN_6RD_PREFIXLEN] = { .type = NETLINK_TYPE_U16 }, [IFLA_IPTUN_6RD_RELAY_PREFIXLEN] = { .type = NETLINK_TYPE_U16 }, - [IFLA_IPTUN_ENCAP_TYPE] = { .type = NETLINK_TYPE_U16}, - [IFLA_IPTUN_ENCAP_FLAGS] = { .type = NETLINK_TYPE_U16}, - [IFLA_IPTUN_ENCAP_SPORT] = { .type = NETLINK_TYPE_U16}, - [IFLA_IPTUN_ENCAP_DPORT] = { .type = NETLINK_TYPE_U16}, + [IFLA_IPTUN_ENCAP_TYPE] = { .type = NETLINK_TYPE_U16 }, + [IFLA_IPTUN_ENCAP_FLAGS] = { .type = NETLINK_TYPE_U16 }, + [IFLA_IPTUN_ENCAP_SPORT] = { .type = NETLINK_TYPE_U16 }, + [IFLA_IPTUN_ENCAP_DPORT] = { .type = NETLINK_TYPE_U16 }, }; static const NLType rtnl_link_info_data_ipgre_types[IFLA_GRE_MAX + 1] = { @@ -225,8 +225,8 @@ static const NLType rtnl_link_info_data_ipvti_types[IFLA_VTI_MAX + 1] = { [IFLA_VTI_LINK] = { .type = NETLINK_TYPE_U32 }, [IFLA_VTI_IKEY] = { .type = NETLINK_TYPE_U32 }, [IFLA_VTI_OKEY] = { .type = NETLINK_TYPE_U32 }, - [IFLA_VTI_LOCAL] = { .type = NETLINK_TYPE_IN_ADDR }, - [IFLA_VTI_REMOTE] = { .type = NETLINK_TYPE_IN_ADDR }, + [IFLA_VTI_LOCAL] = { .type = NETLINK_TYPE_IN_ADDR }, + [IFLA_VTI_REMOTE] = { .type = NETLINK_TYPE_IN_ADDR }, }; static const NLType rtnl_link_info_data_ip6tnl_types[IFLA_IPTUN_MAX + 1] = { @@ -237,7 +237,7 @@ static const NLType rtnl_link_info_data_ip6tnl_types[IFLA_IPTUN_MAX + 1] = { [IFLA_IPTUN_FLAGS] = { .type = NETLINK_TYPE_U32 }, [IFLA_IPTUN_PROTO] = { .type = NETLINK_TYPE_U8 }, [IFLA_IPTUN_ENCAP_LIMIT] = { .type = NETLINK_TYPE_U8 }, - [IFLA_IPTUN_FLOWINFO] = { .type = NETLINK_TYPE_U32}, + [IFLA_IPTUN_FLOWINFO] = { .type = NETLINK_TYPE_U32 }, }; /* these strings must match the .kind entries in the kernel */ @@ -375,9 +375,9 @@ static const NLTypeSystem rtnl_af_spec_type_system = { }; static const NLType rtnl_link_types[IFLA_MAX + 1 ] = { - [IFLA_ADDRESS] = { .type = NETLINK_TYPE_ETHER_ADDR, }, - [IFLA_BROADCAST] = { .type = NETLINK_TYPE_ETHER_ADDR, }, - [IFLA_IFNAME] = { .type = NETLINK_TYPE_STRING, .size = IFNAMSIZ - 1, }, + [IFLA_ADDRESS] = { .type = NETLINK_TYPE_ETHER_ADDR }, + [IFLA_BROADCAST] = { .type = NETLINK_TYPE_ETHER_ADDR }, + [IFLA_IFNAME] = { .type = NETLINK_TYPE_STRING, .size = IFNAMSIZ - 1 }, [IFLA_MTU] = { .type = NETLINK_TYPE_U32 }, [IFLA_LINK] = { .type = NETLINK_TYPE_U32 }, /* diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c index 55510b46e9..f20f68b482 100644 --- a/src/network/networkd-link.c +++ b/src/network/networkd-link.c @@ -858,7 +858,7 @@ static int link_set_bridge(Link *link) { if (r < 0) return log_link_error_errno(link, r, "Could not append IFLA_PROTINFO attribute: %m"); - r = sd_netlink_message_append_u8(req, IFLA_BRPORT_GUARD, link->network->bpdu_guard); + r = sd_netlink_message_append_u8(req, IFLA_BRPORT_GUARD, !link->network->use_bpdu); if (r < 0) return log_link_error_errno(link, r, "Could not append IFLA_BRPORT_GUARD attribute: %m"); @@ -870,7 +870,7 @@ static int link_set_bridge(Link *link) { if (r < 0) return log_link_error_errno(link, r, "Could not append IFLA_BRPORT_FAST_LEAVE attribute: %m"); - r = sd_netlink_message_append_u8(req, IFLA_BRPORT_PROTECT, link->network->root_block); + r = sd_netlink_message_append_u8(req, IFLA_BRPORT_PROTECT, !link->network->allow_port_to_be_root); if (r < 0) return log_link_error_errno(link, r, "Could not append IFLA_BRPORT_PROTECT attribute: %m"); diff --git a/src/network/networkd-netdev-gperf.gperf b/src/network/networkd-netdev-gperf.gperf index bdc43e87f6..be76022bc7 100644 --- a/src/network/networkd-netdev-gperf.gperf +++ b/src/network/networkd-netdev-gperf.gperf @@ -37,7 +37,7 @@ Tunnel.TTL, config_parse_unsigned, 0, Tunnel.DiscoverPathMTU, config_parse_bool, 0, offsetof(Tunnel, pmtudisc) Tunnel.Mode, config_parse_ip6tnl_mode, 0, offsetof(Tunnel, ip6tnl_mode) Tunnel.IPv6FlowLabel, config_parse_ipv6_flowlabel, 0, offsetof(Tunnel, ipv6_flowlabel) -Tunnel.DiffServiceCodePoint, config_parse_bool, 0, offsetof(Tunnel, dscp) +Tunnel.CopyDSCP, config_parse_bool, 0, offsetof(Tunnel, copy_dscp) Peer.Name, config_parse_ifname, 0, offsetof(Veth, ifname_peer) Peer.MACAddress, config_parse_hwaddr, 0, offsetof(Veth, mac_peer) VXLAN.Id, config_parse_uint64, 0, offsetof(VxLan, id) diff --git a/src/network/networkd-netdev-tunnel.c b/src/network/networkd-netdev-tunnel.c index 1af234aba3..7fd9ef584b 100644 --- a/src/network/networkd-netdev-tunnel.c +++ b/src/network/networkd-netdev-tunnel.c @@ -281,7 +281,7 @@ static int netdev_ip6tnl_fill_message_create(NetDev *netdev, Link *link, sd_netl return log_netdev_error_errno(netdev, r, "Could not append IFLA_IPTUN_FLOWINFO attribute: %m"); } - if (t->dscp) + if (t->copy_dscp) t->flags |= IP6_TNL_F_RCV_DSCP_COPY; r = sd_netlink_message_append_u32(m, IFLA_IPTUN_FLAGS, t->flags); diff --git a/src/network/networkd-netdev-tunnel.h b/src/network/networkd-netdev-tunnel.h index e08e2891e7..1fd2b94ae1 100644 --- a/src/network/networkd-netdev-tunnel.h +++ b/src/network/networkd-netdev-tunnel.h @@ -57,7 +57,7 @@ struct Tunnel { IPv6FlowLabel ipv6_flowlabel; bool pmtudisc; - bool dscp; + bool copy_dscp; }; extern const NetDevVTable ipip_vtable; diff --git a/src/network/networkd-network-gperf.gperf b/src/network/networkd-network-gperf.gperf index 720f6b9d0b..83224d7109 100644 --- a/src/network/networkd-network-gperf.gperf +++ b/src/network/networkd-network-gperf.gperf @@ -73,10 +73,10 @@ DHCP.CriticalConnection, config_parse_bool, 0 DHCP.VendorClassIdentifier, config_parse_string, 0, offsetof(Network, dhcp_vendor_class_identifier) DHCP.RouteMetric, config_parse_unsigned, 0, offsetof(Network, dhcp_route_metric) Bridge.Cost, config_parse_unsigned, 0, offsetof(Network, cost) -Bridge.BPDUGuard, config_parse_bool, 0, offsetof(Network, bpdu_guard) +Bridge.UseBPDU, config_parse_bool, 0, offsetof(Network, use_bpdu) Bridge.HairPin, config_parse_bool, 0, offsetof(Network, hairpin) Bridge.FastLeave, config_parse_bool, 0, offsetof(Network, fast_leave) -Bridge.RootBlock, config_parse_bool, 0, offsetof(Network, root_block) +Bridge.AllowPortToBeRoot, config_parse_bool, 0, offsetof(Network, allow_port_to_be_root) Bridge.UnicastFlood, config_parse_bool, 0, offsetof(Network, unicast_flood) BridgeFDB.MACAddress, config_parse_fdb_hwaddr, 0, 0 BridgeFDB.VLANId, config_parse_fdb_vlan_id, 0, 0 diff --git a/src/network/networkd-network.c b/src/network/networkd-network.c index 55e735e6bf..d8f42621af 100644 --- a/src/network/networkd-network.c +++ b/src/network/networkd-network.c @@ -107,6 +107,10 @@ static int network_load_one(Manager *manager, const char *filename) { network->dhcp_route_metric = DHCP_ROUTE_METRIC; network->dhcp_client_identifier = DHCP_CLIENT_ID_DUID; + network->use_bpdu = true; + network->allow_port_to_be_root = true; + network->unicast_flood = true; + network->llmnr = LLMNR_SUPPORT_YES; network->link_local = ADDRESS_FAMILY_IPV6; diff --git a/src/network/networkd.h b/src/network/networkd.h index 6418c0a536..a285a4b08f 100644 --- a/src/network/networkd.h +++ b/src/network/networkd.h @@ -150,10 +150,10 @@ struct Network { bool dhcp_server; - bool bpdu_guard; + bool use_bpdu; bool hairpin; bool fast_leave; - bool root_block; + bool allow_port_to_be_root; bool unicast_flood; unsigned cost; diff --git a/src/udev/ata_id/ata_id.c b/src/udev/ata_id/ata_id.c index a59d4c6d50..c6a2c56e77 100644 --- a/src/udev/ata_id/ata_id.c +++ b/src/udev/ata_id/ata_id.c @@ -409,7 +409,6 @@ int main(int argc, char *argv[]) union { uint8_t byte[512]; uint16_t wyde[256]; - uint64_t octa[64]; } identify; char model[41]; char model_enc[256]; |