summaryrefslogtreecommitdiff
path: root/src/util.c
diff options
context:
space:
mode:
Diffstat (limited to 'src/util.c')
-rw-r--r--src/util.c40
1 files changed, 32 insertions, 8 deletions
diff --git a/src/util.c b/src/util.c
index 9b43c21d08..f0051ee285 100644
--- a/src/util.c
+++ b/src/util.c
@@ -4576,17 +4576,25 @@ static int files_add(Hashmap *h, const char *path, const char *suffix) {
}
for (de = readdir(dir); de; de = readdir(dir)) {
- char *f;
+ char *p, *f;
const char *base;
if (!file_is_conf(de, suffix))
continue;
- if (asprintf(&f, "%s/%s", path, de->d_name) < 0) {
+ if (asprintf(&p, "%s/%s", path, de->d_name) < 0) {
r = -ENOMEM;
goto finish;
}
+ f = canonicalize_file_name(p);
+ if (!f) {
+ log_error("Failed to canonicalize file name '%s': %m", p);
+ free(p);
+ continue;
+ }
+ free(p);
+
log_debug("found: %s\n", f);
base = f + strlen(path) + 1;
if (hashmap_put(h, base, f) <= 0)
@@ -4607,27 +4615,42 @@ static int base_cmp(const void *a, const void *b) {
}
int conf_files_list(char ***strv, const char *suffix, const char *dir, ...) {
- Hashmap *fh;
+ Hashmap *fh = NULL;
+ char **dirs = NULL;
char **files = NULL;
+ char **p;
va_list ap;
int r = 0;
+ va_start(ap, dir);
+ dirs = strv_new_ap(dir, ap);
+ va_end(ap);
+ if (!dirs) {
+ r = -ENOMEM;
+ goto finish;
+ }
+ if (!strv_path_canonicalize(dirs)) {
+ r = -ENOMEM;
+ goto finish;
+ }
+ if (!strv_uniq(dirs)) {
+ r = -ENOMEM;
+ goto finish;
+ }
+
fh = hashmap_new(string_hash_func, string_compare_func);
if (!fh) {
r = -ENOMEM;
goto finish;
}
- va_start(ap, dir);
- while (dir) {
- if (files_add(fh, dir, suffix) < 0) {
+ STRV_FOREACH(p, dirs) {
+ if (files_add(fh, *p, suffix) < 0) {
log_error("Failed to search for files.");
r = -EINVAL;
goto finish;
}
- dir = va_arg(ap, const char *);
}
- va_end(ap);
files = hashmap_get_strv(fh);
if (files == NULL) {
@@ -4638,6 +4661,7 @@ int conf_files_list(char ***strv, const char *suffix, const char *dir, ...) {
qsort(files, hashmap_size(fh), sizeof(char *), base_cmp);
finish:
+ strv_free(dirs);
hashmap_free(fh);
*strv = files;
return r;