summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2012-03-14journal: Don't hold pointers to journal while remappingMarti Raudsepp
Hi! I was trying out the journal and the journalctl utility sometimes crashed on me. After some debugging, I tracked it down to the fact that next_with_matches() holds the "c" object pointer through the journal_file_next_entry_for_data() call -- which apparently may re-map the journal file, invalidating the pointer. The attached patch fixes this crash for me, but being unfamiliar with the code, I don't know if I'm doing the right thing. This patch is also available from my github repository: git://github.com/intgr/systemd.git https://github.com/intgr/systemd Regards, Marti For the record, here's the original stack trace at the time of remapping: ret=0x7fff1d5cdec0) at src/journal/journal-file.c:330 ret=0x7fff1d5cdf28) at src/journal/journal-file.c:414 ret=0x7fff1d5ce0a0, offset=0x7fff1d5ce098) at src/journal/journal-file.c:1101 i=5705, ret=0x7fff1d5ce0a0, offset=0x7fff1d5ce098) at src/journal/journal-file.c:1147 p=6413608, data_offset=66600, direction=DIRECTION_DOWN, ret=0x7fff1d5ce0a0, offset=0x7fff1d5ce098) at src/journal/journal-file.c:1626 direction=DIRECTION_DOWN, ret=0x7fff1d5ce120, offset=0x7fff1d5ce128) at src/journal/sd-journal.c:533 direction=DIRECTION_DOWN, ret=0x7fff1d5ce170, offset=0x7fff1d5ce178) at src/journal/sd-journal.c:595 src/journal/sd-journal.c:651 From 9266fc6a58065a7c5dab67430fd78925e519dce9 Mon Sep 17 00:00:00 2001 From: Marti Raudsepp <marti@juffo.org> Date: Fri, 9 Mar 2012 16:23:00 +0200 Subject: [PATCH] journal: Don't hold pointers to journal while remapping This would cause a segfault otherwise.
2012-03-14update TODOLennart Poettering
2012-03-14log: introduce log_metavLennart Poettering
2012-03-14update TODOLennart Poettering
2012-03-14pkg-config: bring unit search path order in sync with the codeLennart Poettering
2012-03-14path-lookup: rearrange things so that the system path order follows the user ↵Lennart Poettering
path order
2012-03-14conf: when looking for configurations look in /etc first, in /run secondLennart Poettering
After long consideration we came to the conclusion that user configuration in /etc should always override the (generally computer generated) configuration in /run. User configuration should always be what matters over anything else. Hence rearrange the search orders accordingly. In general this should change very little as overriding like this is seldomn done so far, and the order between /etc and /usr stays the same.
2012-03-14man: document where we read kernel cmdline options fromLennart Poettering
2012-03-14machine-id: initialize from $container_uuid if not set otherwiseLennart Poettering
This is a result of the discussions on https://bugs.freedesktop.org/show_bug.cgi?id=46894
2012-03-14journald: allocate PAGE_SIZE bytes for selinux label lengthLennart Poettering
As suggested in https://bugzilla.redhat.com/show_bug.cgi?id=798760
2012-03-14socket: make sure that the name for per-connection services are uniqueLennart Poettering
If a client connects to us repeatedly always using the same source port and we instantiate a service for the incoming connection this might clash with an old instance. Hence, include the connection number, the same way we do it for AF_UNIX to make connections unique. https://bugs.freedesktop.org/show_bug.cgi?id=45297
2012-03-14socket: if we fail to create an instantiated service for a socket, don't put ↵Lennart Poettering
the socket in failure mode An incoming connection that is immediately terminated might result in getpeername() or a similar call failing. Hence it is quite possible that while we are setting up an instantiated service for a socket we might get an error and we shouldn't take this as hint to take the listening socket down. https://bugs.freedesktop.org/show_bug.cgi?id=45297 https://bugzilla.novell.com/show_bug.cgi?id=741590
2012-03-13update TODOLennart Poettering
2012-03-13mount: fix assertionLennart Poettering
https://bugzilla.redhat.com/show_bug.cgi?id=768523
2012-03-13conf-parser: warn if an assignment is place outside of a sectionLennart Poettering
https://bugzilla.redhat.com/show_bug.cgi?id=783134
2012-03-13util: add brute-force fallback for close_all_fds()Lennart Poettering
If /proc is not available (i.e. in chroot envs) let's fall back to brute forcing our way through the fd table. https://bugzilla.redhat.com/show_bug.cgi?id=784921
2012-03-13journald: use SCM_SECURITY to race-freely determine peer SELinux labelLennart Poettering
https://bugzilla.redhat.com/show_bug.cgi?id=798760
2012-03-13socket: add option for SO_PASSECLennart Poettering
https://bugzilla.redhat.com/show_bug.cgi?id=798760 (Note that this work is not complete yet, as the kernel seems to send us useless data with SCM_SECURITY enabled)
2012-03-12login: tag the Mimo 720 ID_AUTOSEATShawn Landden
This device is a combination USB hub, displaylink graphics, and e2i touchscreen Bus 001 Device 005: ID 058f:6254 Alcor Micro Corp. USB Hub Bus 001 Device 006: ID 17e9:401a Newnham Research Bus 001 Device 007: ID 1ac7:0001 |__ Port 1: Dev 5, If 0, Class=hub, Driver=hub/4p, 480M |__ Port 2: Dev 6, If 0, Class=vend., Driver=udlfb, 480M |__ Port 2: Dev 6, If 1, Class=HID, Driver=usbhid, 480M |__ Port 3: Dev 7, If 0, Class=vend., Driver=usbtouchscreen, 12M
2012-03-12conf: enforce UTF8 validty everywhereLennart Poettering
we need to make sure that configuration data we expose via the bus ends up in using getting an assert(). Even though configuration data is only parsed from trusted sources we should be more careful with what we read.
2012-03-12man: reword tmpfiles selinux bitsLennart Poettering
2012-03-12update TODOLennart Poettering
2012-03-06man: clarify that applications must ignore unknown fieldsLennart Poettering
2012-03-06man: document how os-release(5) may be extended by OS vendorsLennart Poettering
2012-03-06man: fix typoLennart Poettering
2012-03-06man: allow that /etc/os-release is a symlinkLennart Poettering
2012-03-06man: add URL field definitions to os-release(5)Lennart Poettering
As requested by Raphaël Hertzog from the Debian project, include information about the home page and support/bug report pages in /etc/os-release.
2012-03-06man: add ID_LIKE definition to os-release(5)Lennart Poettering
As requested by Raphaël Hertzog from the Debian project, encode derivative information in /etc/os-release.
2012-03-06update TODOLennart Poettering
2012-03-06journal: make sure to refresh window position and pointer after we linked up ↵Lennart Poettering
a data object
2012-03-06mount: properly check return for mount_add_*Dave Reisner
Previously, mount_load_etc_fstab() could never fail for reasons other than a setmntent() or allocation failure.
2012-03-06bash-completion: get rid of awk, sed and grepHarald Hoyer
Get rid of "awk", "sed" and "grep" calls. This can be done entirely in bash! With help from Dave Reisner
2012-03-06nspawn: be less cryptic when clone() failsLennart Poettering
Based on a patch suggested by Shawn Landden.
2012-03-06update TODOLennart Poettering
2012-03-06update TODOLennart Poettering
2012-03-06socket: rename 'broken' failure result to 'failed-permanent' on order not to ↵Lennart Poettering
introduce new terminology
2012-03-06umount: don't try to umount /usr, if we are running from itLennart Poettering
2012-03-05update TODOLennart Poettering
2012-03-05socket: fail the socket if the service keeps dying on startMichal Schmidt
If the service reaches the start limit, mark the sockets that activate it as failed (with the result code 'service-broken'). This way the sockets won't act as tarpits for clients connecting to them.
2012-03-05configure.ac: fix typo in distro help stringThierry Reding
2012-03-05sd-login: c++ compatibilityLennart Poettering
2012-03-05systemd-analyze: call os.uname() onceDave Reisner
Uses a format string, which is dependent on python 2.6.
2012-03-05fix sparse warningsFrederic Crozat
2012-03-05journal: fix endianness errorsFrederic Crozat
2012-03-05man: corrected machine-info(5) man page to be in line with sourceShawn Landden
change conflicting man/machine-info.xml documentation to match functionality in src/hostname/hostnamed.c 114-119
2012-03-05update TODOLennart Poettering
2012-02-29man: fix systemd.special build failureKay Sievers
2012-02-29systemctl: forward untrusted user reboot, poweroff requests to logindKay Sievers
2012-02-29systemd-journald: fix endianess bugDirk Eibach
2012-02-21systemd-analyze: read /etc/os-releaseKay Sievers
generated by cgit v1.2.3-54-g00ecf (git 2.45.2) at 2024-11-05 00:15:40 +0000