Age | Commit message (Collapse) | Author |
|
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
|
|
`udevadm info --run` no longer returns the correct run directory
so we hard code it as "/run/udev/"
X-Gentoo-Bug: 475276
X-Gentoo-Bug-URL: https://bugs.gentoo.org/475276
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
This code was accidentally removed in commit
601c4e8ce69338652b3c9178386cbc05de8bae8d
We restore it here. Since most modern systems have accept4()
this code will seldom be triggered. You can test by configuring
as follows:
ac_cv_have_decl_accept4="no" ./configure
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Onboard network controllers are not always on PCI domain 0.
[Kay: use int instead of long, add [P] to slot naming, remove sysname var]
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
https://launchpad.net/bugs/1193147
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
When manpages are displayed on a terminal, <literal>s are indistinguishable
from surrounding text. Add quotes everywhere, remove duplicate quotes,
and tweak a few lists for consistent formatting.
https://bugzilla.redhat.com/show_bug.cgi?id=874631
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
This header is unnecessary and causes a buildtime error on musl.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Remove the following unused DECLS:
IOPRIO_BITS
IOPRIO_CLASS_SHIFT
IOPRIO_PRIO_MASK
IOPRIO_PRIO_CLASS
IOPRIO_PRIO_DATA
IOPRIO_PRIO_VALUE
ioprio_valid
IOPRIO_BE_NR
IOPRIO_WHO_PROCESS
IOPRIO_WHO_PGRP
IOPRIO_WHO_USER
MESSAGE_ID
EXIT_TEST_SKIP
XSTRINGIFY
STRINGIFY
ALIGN_PTR
ALIGN4_PTR
ALIGN8_PTR
MAX
MAX3
MIN
CLAMP
zero
CHAR_TO_STR
VA_FORMAT_ADVANCE
SET_FLAG
SET_FOREACH
SET_FOREACH_BACKWARDS
STRV_FOREACH_BACKWARDS
STRV_FOREACH_PAIR
_unused_
_destructor_
_deprecated_
_weak_
_hidden_
_weakref_
_introspect_
_alignas_
Remove the following unused static inline functions:
static inline int ioprio_set
static inline int ioprio_get
static inline const char* STRV_IFNOTNULL
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
The following unused DECLS are removed:
DEFAULT_TIMEOUT_USEC
DEFAULT_RESTART_USEC
DEFAULT_CONFIRM_USEC
DEFAULT_EXIT_USEC
SIGNALS_CRASH_HANDLER
SIGNALS_IGNORE
EXIT_INVALIDARGUMENT
EXIT_NOTIMPLEMENTED
EXIT_NOPERMISSION
EXIT_NOTINSTALLED
EXIT_NOTCONFIGURED
EXIT_NOTRUNNING
EXIT_CHDIR
EXIT_NICE
EXIT_FDS
EXIT_EXEC
EXIT_MEMORY
EXIT_LIMITS
EXIT_OOM_ADJUST
EXIT_SIGNAL_MASK
EXIT_STDIN
EXIT_STDOUT
EXIT_CHROOT
EXIT_IOPRI
EXIT_TIMERSLACK
EXIT_SECUREBITS
EXIT_SETSCHEDULER
EXIT_CPUAFFINITY
EXIT_GROUP
EXIT_USER
EXIT_CAPABILITIES
EXIT_CGROUP
EXIT_SETSID
EXIT_CONFIRM
EXIT_STDERR
EXIT_TCPWRAP
EXIT_PAM
EXIT_NETWORK
EXIT_NAMESPACE
EXIT_NO_NEW_PRIVILEGES
EXIT_SECCOMP
EXIT_STATUS_MINIMAL
EXIT_STATUS_SYSTEMD
EXIT_STATUS_LSB
EXIT_STATUS_FULL
HASHMAP_FOREACH_KEY
HASHMAP_FOREACH_BACKWARDS
FORMAT_TIMESTAMP_MAX
FORMAT_TIMESTAMP_PRETTY_MAX
FORMAT_TIMESPAN_MAX
FORMAT_BYTES_MAX
ANSI_HIGHLIGHT_ON
ANSI_RED_ON
ANSI_HIGHLIGHT_RED_ON
dual_timestamp_is_set
newa
newdup
FOREACH_WORD
FOREACH_WORD_SEPARATOR
NULSTR_FOREACH
_cleanup_pclose_
_cleanup_umask_
_cleanup_globfree_
DRAW_TREE_VERT
DRAW_TREE_BRANCH
DRAW_TREE_RIGHT
DRAW_TREE_SPACE
DRAW_TRIANGULAR_BULLET
_DRAW_SPECIAL_CHAR_MAX
FOREACH_LINE
procfs_file_alloca
The following unused struct defs were removed:
struct ExitStatusSet
The following unused static inline funcs were remvoed:
static inline int safe_atolu
static inline int safe_atoli
static inline int safe_atolu
static inline int safe_atoli
static inline int safe_atou32
static inline int safe_atoi32
static inline int safe_atou64
static inline int safe_atoi64
static inline const char* yes_no
static inline const char* strempty
static inline const char* strnull
static inline const char *strna
static inline void pclosep
static inline void umaskp
NOTE: Some unused DECLS were retained if they formed part of a logical
series, eg. definition of time units.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
We removed the following functions:
hashmap_merge
path_is_read_only_fs
set_free_free
set_free_freep
readlink_malloc
hexchar
unhexchar
octchar
unoctchar
format_timespan
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
The following functions were removed:
strv_env_get_n
strv_env_get
conf_files_list
hashmap_remove
hashmap_move
log_dump_internal
parse_uid
read_full_file
strstrip
file_in_same_dir
cunescape
cunescape_length
cunescape_length_with_prefix
xescape
dirent_is_file
close_all_fds
read_one_char
ask
reset_terminal_fd
reset_terminal
flush_fd
loop_read
get_ctty_devnr
get_ctty
rm_rf_children
rm_rf_children_dangerous
rm_rf
status_vprintf
fd_columns
columns
fd_lines
lines
on_tty
ellipsize
ellipsize_mem
touch
unquote
resolve_dev_console
tty_is_vc
vtnr_from_tty
terminal_vhangup_fd
terminal_vhangup
file_is_priv_sticky
signal_from_string
fd_wait_for_event
memdup
memdup_multiply
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
src/libudev/{hashmap,log,path-util,set,strv,util}
We remove the following functions:
cleanup_pool
uint64_hash_func
hashmap_ensure_allocated
hashmap_clear_free_free
hashmap_replace
hashmap_remove_and_put
hashmap_iterate_skip
hashmap_first
hashmap_first_key
hashmap_last
hashmap_isempty
hashmap_move_one
hashmap_copy
log_metav_object
log_show_color
log_show_location
path_strv_make_absolute_cwd
path_startswith
set_remove
set_move
set_clear
strv_find
strv_contains
strv_merge
strv_split
strv_split_quoted
strv_append
strv_extend
strv_push
strv_split_nulstr
str_compare
dual_timestamp_get
dual_timestamp_from_realtime
timespec_store
timeval_load
timeval_store
parse_boolean
fchmod_umask
parse_env_file
get_process_comm
get_process_id
readlink_and_make_absolute
bus_path_unescape
format_timestamp
acquire_terminal
loop_write
parse_usec
make_stdio
random_ull
lookup_uid
getttyname_malloc
status_printf
replace_env
normalize_env_assignment
wait_for_terminate
freeze
tag_to_udev_node
tty_is_vc_resolve
nulstr_contains
strshorten
hostname_valid_char
display_is_local
get_group_creds
in_gid
dirent_ensure_type
is_locale_utf8
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
We remove the following unused functions:
label_socket_set
label_socket_clear
label_free
label_get_create_label_from_exe
label_retest_selinux
label_bind
mkdir_label
mkdir_safe
mkdir_safe_label
mkdir_p_label
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
We remove the following unused functions:
ascii_strlower
block_get_whole_disk
bus_path_escape
can_sleep
can_sleep_disk
cescape
chars_intersect
chvt
close_many
close_pipe
columns_lines_cache_reset
copy_file
cpu_set_malloc
decchar
default_signals
default_term_for_tty
delete_chars
dir_is_empty
draw_special_char
dual_timestamp_deserialize
dual_timestamp_serialize
execute_directory
fchmod_and_fchown
fd_cloexec
fd_inc_rcvbuf
fd_nonblock
filename_is_safe
first_word
fork_agent
format_bytes
format_timestamp_pretty
fstab_node_to_udev_node
fstype_is_network
getenv_for_pid
get_files_in_directory
get_home_dir
gethostname_malloc
getlogname_malloc
get_parent_of_pid
get_process_cmdline
get_process_exe
get_process_gid
get_process_uid
get_starttime_of_pid
getttyname_harder
get_user_creds
getusername_malloc
glob_exists
hostname_cleanup
hostname_is_set
hostname_is_valid
ignore_signals
in_charset
in_group
in_search_path
is_device_path
is_kernel_thread
is_valid_documentation_url
kexec_loaded
kill_and_sigcont
load_env_file
make_console_stdio
make_null_stdio
parse_bytes
parse_nsec
parse_pid
parse_timestamp
pipe_eof
plymouth_running
prot_from_flags
readlink_and_canonicalize
release_terminal
rename_process
replace_env_argv
reset_all_signal_handlers
rmdir_parents
rm_rf_dangerous
running_in_chroot
setrlimit_closest
sigaction_many
signal_from_string_try_harder
sigset_add_many
socket_from_display
startswith_no_case
status_welcome
strdup_or_null
string_is_safe
strreplace
symlink_atomic
tty_is_console
undecchar
vt_disallocate
wait_for_terminate_and_warn
warn_melody
write_env_file
write_one_line_file_atomic
xopendirat
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
src/libudev/{conf-files,exit-status,hashmap,log,path-util,set,strv}.c
A lot of upstream commits cross many boundaries between systemd code
and udev code. The point of intersection is upstreams src/shared
folder. The best way we find to track them is to apply their commits
to udev and libudev and then just pick remove functions from the
shared folder. Its timely but it gives us the best control over what
gets in and what doesnt.
In this commit we removed the following functions:
conf_files_list_nulstr
exit_status_to_string
is_clean_exit_lsb
uint64_hash_func
uint64_compare_func
hashmap_free_free_free
hashmap_update
hashmap_get2
hashmap_remove_and_replace
hashmap_remove_value
hashmap_steal_first_key
hashmap_next
log_forget_fds
log_set_facility
log_meta_object
log_struct_internal
log_set_target_from_string
log_set_max_level_from_string
log_get_target
log_get_max_level
log_show_color_from_string
log_show_location_from_string
log_on_console
is_path
path_split_and_make_absolute
set_ensure_allocated
set_replace
set_remove_and_put
set_size
set_isempty
set_iterate_skip
set_steal_first
set_first
set_last
set_merge
set_move_one
set_copy
set_clear_free
set_get_strv
strv_find_prefix
strv_merge_concat
strv_split_newlines
strv_join
strv_remove_prefix
strv_parse_nulstr
strv_overlap
strv_sort
strv_print
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
|
|
|
|
In doing so, we better alined util.{c,h} by movig the definitions
of freep, fclosep, closep, closedirp, umaskp from util.c to util.h
as static inline. We also add strv_env_get to env-util.{c,h} which
we forgot to do earlier.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
To bring this in line with upstream, we had to add in env-util.c.
The approach we will take is to slim down upstream's "shared" code
so that it only contains functions and macros for what we need.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
https://launchpad.net/bugs/1157334
|
|
https://launchpad.net/bugs/727139
|
|
https://launchpad.net/bugs/1012365
|
|
|
|
|
|
gcc (and other compilers) sometimes generate spurious warnings, and
thus users of public headers must be able to disable warnings.
Printf format attributes can be disabled by setting
#define _sd_printf_attr_
before including the header file.
Also, add similar logic for sentinel attribute:
#define _sd_sentinel_attr_
before including the header file disables the attribute.
|
|
It's polite to print the name of the link that wasn't created,
and it makes little sense to print the target.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
b8a2b0f76 'use initalization instead of explicit zeroing'
introduced a bug where only the first sizeof(uint_t*) bytes
would be zeroed out, instead of the whole array.
|
|
|
|
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Avoid "sender uid=65534, message ignored" case, where no credentials can
be read on the sender side.
Seems, the server socket does not enable credential receiving fast
enough, and the message from the client (without credential) sometimes
is queued before the credential passing was active.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
Before, we would initialize many fields twice: first
by filling the structure with zeros, and then a second
time with the real values. We can let the compiler do
the job for us, avoiding one copy.
A downside of this patch is that text gets slightly
bigger. This is because all zero() calls are effectively
inlined:
$ size build/.libs/systemd
text data bss dec hex filename
before 897737 107300 2560 1007597 f5fed build/.libs/systemd
after 897873 107300 2560 1007733 f6075 build/.libs/systemd
… actually less than 1‰.
A few asserts that the parameter is not null had to be removed. I
don't think this changes much, because first, it is quite unlikely
for the assert to fail, and second, an immediate SEGV is almost as
good as an assert.
NOTE by Basile: the above analysis is for all systemd. This commit
is just a sliver of the commit for all of system and so we can't
expect size to be the same.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
|
A fix for ff03aed06a422.
|
|
For some reason this shows up on i686 only:
src/udev/udev-builtin-usb_id.c:192:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
|