summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-11-09treewide: apply errno.cocciMichal Schmidt
with small manual cleanups for style.
2015-11-09coccinelle: additional errno.cocci hunkMichal Schmidt
rewrites: log_error_errno(errno, ...); return -errno; into: return log_error_errno(errno, ...);
2015-11-09coccinelle: errno.cocci improvementsMichal Schmidt
Apply to all log_*_errno loglevels.
2015-11-09Merge pull request #1798 from evverx/fix-test-udevLennart Poettering
test-udev: small fixes
2015-11-09Merge pull request #1799 from jengelh/docLennart Poettering
doc: typo and ortho fixes
2015-11-09Merge pull request #1807 from michich/boot-timerLennart Poettering
core/timer: in containers OnBootSec should count from container startup
2015-11-09Merge pull request #1794 from karelzak/size_limitLennart Poettering
core: support IEC suffixes for RLIMIT stuff
2015-11-09Merge pull request #1817 from iaguis/nspawn-custom-service-3Lennart Poettering
nspawn: support custom container service name
2015-11-09detect-virt: add rkt app container runtimeIago López Galeiras
2015-11-09nspawn: support custom container service nameIago López Galeiras
We were hardcoding "systemd-nspawn" as the value of the $container env variable and "nspawn" as the service string in machined registration. This commit allows the user to configure it by setting the $SYSTEMD_NSPAWN_CONTAINER_SERVICE env variable when calling systemd-nspawn. If $SYSTEMD_NSPAWN_CONTAINER_SERVICE is not set, we use the string "systemd-nspawn" for both, fixing the previous inconsistency.
2015-11-09Merge pull request #1796 from michaelolbrich/journal-sizeLennart Poettering
journal: reduce minimum journal file size to 512 KiB
2015-11-07core/timer: in containers OnBootSec should count from container startupMichal Schmidt
In Fedora dnf-makecache.timer specifies OnBootSec=10min, but it fired during boot in systemd-nspawn, because the clock ticks since the host's boot. Fix it by treating OnBootSec the same as OnStartupSec when running in a container.
2015-11-07Merge pull request #1801 from chuyd/fix-typosDaniel Mack
test: Fix typo in TEST-03-JOBS/test-jobs.sh
2015-11-07Merge pull request #1803 from phomes/unused-varDaniel Mack
core: remove unused variable
2015-11-07core: remove unused variableThomas Hindoe Paaboel Andersen
unused since 7b2313f5
2015-11-06test: Fix typo in TEST-03-JOBS/test-jobs.shJesus Ornelas Aguayo
Fix typo s/enqueueing/enqueuing/ Signed-off-by: Jesus Ornelas Aguayo <jesus.ornelas.aguayo@intel.com>
2015-11-06Merge pull request #1795 from msekletar/networkd-forwardRonny Chevalier
networkd: fix option name in log message
2015-11-06Merge pull request #1800 from evverx/fix-test-executeRonny Chevalier
test-execute: don't use /usr/bin/uname. use sh and PATH
2015-11-06test-execute: don't use /usr/bin/uname. use sh and PATHEvgeny Vereshchagin
2015-11-06Fixed kernel-command-line linkskayrus
2015-11-06doc: use expanded forms for written styleJan Engelhardt
2015-11-06doc: correct orthography, word forms and missing/extraneous wordsJan Engelhardt
2015-11-06test-udev: small fixesEvgeny Vereshchagin
* print '\n' on error * use UDEVLIBEXECDIR (udev_rules_new uses it too)
2015-11-06doc: correct punctuation and improve typography in documentationJan Engelhardt
2015-11-06journal: reduce minimum journal file size to 512 KiBMichael Olbrich
For low end embedded systems 4 MiB for each journal file is a lot of memory. Journald will use at least 512 KiB even if JOURNAL_FILE_SIZE_MIN is set to less than that so just use 512 KiB.
2015-11-06core: support IEC suffixes for RLIMIT stuffKarel Zak
Let's make things more user-friendly and support for example LimitAS=16G rather than force users to always use LimitAS=16106127360. The change is relevant for options: [Default]Limit{FSIZE,DATA,STACK,CORE,RSS,AS,MEMLOCK,MSGQUEUE} The patch introduces config_parse_bytes_limit(), it's the same as config_parse_limit() but uses parse_size() tu support the suffixes. Addresses: https://github.com/systemd/systemd/issues/1772
2015-11-06networkd: fix option name in log messageMichal Sekletar
2015-11-05extract-word: Skip coalesced separators in placeFilipe Brandenburger
Just skip them in place, instead of setting separator=true. We only do that in a single place (while finding a separator outside of quote or backslash states) so we don't really need a separate state for it. Tested that no regressions were introduced in test-extract-word. Ran a full `make check` and also installed the binaries on a test system and did not see any issues related to parsing unit files or starting units after a reboot.
2015-11-05extract-word: Do not re-evaluate the state on each parsed characterFilipe Brandenburger
Use inner loops to keep processing the same state, except when there is a state change, then break back to the outer loop so that the correct branch can be selected again. Tested that no regressions were introduced in test-extract-word.
2015-11-05extract-word: increment pointer p and keep c in sync in for loopFilipe Brandenburger
This will make it easier to use inner loops to keep looping in the same state, by just updating p and c in the same way in the inner loops. Tested that no regressions were created in test-extract-word.
2015-11-05extract-word: Check for early bail out before inspecting separatorsFilipe Brandenburger
It's a pretty small optimization but doesn't hurt... Tested with test-extract-word.
2015-11-05extract-word: replace an use of `goto` with structured codeFilipe Brandenburger
Using `goto` might be appropriate for the "finish" cases but it was really not necessary at this point of the code... Just use if/else blocks to accomplish the same. Confirmed that the test cases in test-extract-word keep working as expected.
2015-11-05extract-word: move start block outside the for loopFilipe Brandenburger
This block runs once before all the other handling, so move it outside the main loop and put it in its own loop until it's finished doing its job. Tested by confirming `make check` (and particularly test-extract-word) still passes and by booting a system with binaries including this commit.
2015-11-05sd-resolve: simplify pthread_join() callMichal Schmidt
POSIX says: The pthread_join() function shall not return an error code of [EINTR].
2015-11-05timesync: return negative errno from manager_adjust_clock() on errorMichal Schmidt
2015-11-05nspawn: save errno before reopening log after exec failureMichal Schmidt
2015-11-05nspawn: no fake errnoMichal Schmidt
The S_ISREG test does not set errno, so don't use it in the error message.
2015-11-05nspawn: simplify error returnsMichal Schmidt
Use the "return log_error_errno(...)" idiom to have fewer curly braces. The last hunk also fixes the return value of setup_journal(), but the fix has no practical effect.
2015-11-05libsystemd-network: inet_pton does not set errno on parsing errorMichal Schmidt
it would set errno only for an invalid address family. Also fix a copy&paste error in one error string.
2015-11-05import: report error before losing errnoMichal Schmidt
unlink() may change errno, so report the error from rename() first, then unlink.
2015-11-05firstboot: fix errno signMichal Schmidt
2015-11-05journal: posix_fallocate() does not set errnoMichal Schmidt
manpage says: posix_fallocate() returns zero on success, or an error number on failure. Note that errno is not set.
2015-11-05treewide: use the negative error codes returned by our functionsMichal Schmidt
Our functions return negative error codes. Do not rely on errno being set after calling our own functions.
2015-11-05journal: fix incorrect errno reportingMichal Schmidt
pread() returns -1 on error and sets errno. Do not use the -1 as errno.
2015-11-05journal: use int64_t instead of long for catalog file sizeMichal Schmidt
This replaces the use of ftell() with ftello() for 64-bit size on all archs. Also drops a pointless check for NULL before calling strbuf_cleanup().
2015-11-05journal: drop unnecessary write_catalog() parameterMichal Schmidt
write_catalog() use the hashmap only to get its size. The size is already given in parameter 'n'.
2015-11-05log: whitespace style fixMichal Schmidt
2015-11-05tty-ask-password-agent: fix typo in error messageMichal Schmidt
2015-11-04core: still make progress when throttling the manager loopVito Caputo
Don't simply continue after sleeping, it potentially puts us in a state of spinning doing nothing slowly, if the ratelimit_test() keeps detecting the need for limiting. Observed in vms after the host had been suspended for a while, on resume systemd entered a loop of making zero progress spamming the console with: [431942.850090] systemd[1]: Looping too fast. Throttling execution a little. I see no reason to have a continue here, the intention should be to throttle execution, not circumvent it altogether.
2015-11-04Merge pull request #1761 from ssahani/wordLennart Poettering
core: parse socket port to extract_first_word