summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2009-09-24gudev: gir-scanner workaround for out of tree buildsMarco d'Itri
Workaround for https://bugzilla.gnome.org/show_bug.cgi?id=562885
2009-09-24fix wrong parameter size on ioctl FIONREADAndrew Church
On Wed, Sep 23, 2009 at 23:11, Matthias Schwarzott <zzam@gentoo.org> wrote: > It is about ioctl failures on amd64: > http://bugs.gentoo.org/show_bug.cgi?id=286041 > > A bad parameter type to an ioctl() call causes udev-146 to generate "error > getting buffer for inotify" messages in syslog. The offending code is > roughly: > > ssize_t nbytes, pos; > // ... > ioctl(fd, FIONREAD, &nbytes); > > where ssize_t is 64 bits on amd64, but the kernel code for FIONREAD (at least > through gentoo-sources-2.6.31) uses type int: > > p = (void __user *) arg; > switch (cmd) { > case FIONREAD: > // ... > ret = put_user(send_len, (int __user *) p); > > so the upper 32 bits of "nbytes" are left uninitialized, and the subsequent > malloc(nbytes) fails unless those 32 bits happen to be zero (or the system has > a LOT of memory).
2009-09-22util_run_program: *really* restore signal mask before executing event RUN ↵Scott James Remnant
commands The previous patch was almost, but not quite, correct. Rather than restoring the signal mask it actually tried to make an even more restrictive signal mask (had SIGALRM been blocked when udevd started, anyway). Fix it harder. Signed-off-by: Scott James Remnant <scott@ubuntu.com>
2009-09-20fix previous commit for CD detectionMartin Pitt
Do not run blkid twice. *brown paperbag*
2009-09-20fix single-session CD detectionMartin Pitt
ID_CDROM_MEDIA_SESSION_LAST_OFFSET is not set for CDs with only a single session (i. e. for the vast majority of CDs out there). The previous rules ran blkid with invalid arguments for these, causing CD detection to fail in DK-disks and gvfs. Now check whether we actually have ID_CDROM_MEDIA_SESSION_LAST_OFFSET, and if not, call blkid without -O for specifying the offset. Many thanks to Maxim Levitsky for tracking this down! https://launchpad.net/bugs/431055
2009-09-19rules: Gentoo updateMatthias Schwarzott
2009-09-18rename interfaces to <iface>_rename if rename failsHarald Hoyer
2009-09-17scsi_id: prevent buffer overflow in check_fill_0x83_prespc3()Harald Hoyer
see https://bugzilla.redhat.com/show_bug.cgi?id=516920
2009-09-16update TODO, NEWSKay Sievers
2009-09-16rules: drop almost all NAME= keysKay Sievers
The drivers in kernel 2.6.31 supply the names for custom node names if needed.
2009-09-16rules: remove remaining NAME="%k"Kay Sievers
2009-09-16fix SYMLINK{} option parsingKay Sievers
2009-09-14scsi_id: delete copy of bsg.hKay Sievers
It's provided by the kernel since 2.6.23.
2009-09-14udevadm: control - remove compat codeKay Sievers
2009-09-14udevadmi: control = exit with rc=2 if there is some system errorMarco d'Itri
2009-09-14udevadm: print all messages to stderr with priority higher or equal than LOG_ERRMarco d'Itri
It is needed to prevent errors in udev from going unnoticed (e.g. when udevd is not running).
2009-09-10put util_create_path() and file creastion in a retry loopKay Sievers
On 8/29/09, Florian Zumbiehl <florz@florz.de> wrote: > Could it happen that > util_create_path() and util_delete_path() > do run in parallel for > the same directory? After all, util_create_path() > does handle > the case where creation of the directory happens in parallel > to it running, so it doesn't seem all that unlikely to me ...
2009-09-10reorder create_path() and node/link creation to be called in a direct sequenceKay Sievers
2009-09-09sound: recognize saa7134 TV card sound devices as TV cardsLennart Poettering
2009-09-09simplify "symlink name stack"Kay Sievers
With well defined and kernel-supplied node names, we no longer need to support a possible stack of conflicting symlinks and node names. Only symlinks with identical names can be claimed by multiple devices. This shrinks the former /dev/.udev/names/ significantly. Also the /dev/{block,char}/MAJ:MIN" links are excluded from the name stack - they are unique and can not conflict.
2009-09-09extras/keymap: Rename KEY_COFFEE to KEY_SCREENLOCKMartin Pitt
Unfortunately KEY_COFFEE is the canonical name in linux/input.h, and the more sensible KEY_SCREENLOCK is an alias. Manually override this particular case, since it's better to have "screenlock" in keymaps. However, we still keep the automatic filtering for the general case, to avoid introducing this problem again when input.h changes.
2009-09-09extras/keymap: fix hash table collisionsMartin Pitt
More than one key name was mapped to the same key, due to linux/input.h defining some aliases (in particular, KEY_HANGUEL, KEY_SCREENLOCK, KEY_MIN_INTERESTING). These caused hash table collisions. Changed the generation of the tables to ignore these aliases, and updated all keymaps to use the canonical name. This was detected by llvm-clang-analyzer. Thanks to Lennart Poettering for doing these checks and pointing this out! https://launchpad.net/bugs/426647
2009-09-08fix randonm findings from llvm-clang-analyzerKay Sievers
Thanks to Lennart for the log file!
2009-09-08util_run_program(): fix possible buffer overflow #2Florian Zumbiehl
I'm not sure how likely it is for UTIL_PATH_SIZE to have an odd value (maybe it has right now? :-), but I guess making this universally correct doesn't hurt ...
2009-09-08require 2.6.27 for proper signalfd handlingKay Sievers
<zzam> kay: ping I found out why udev-145 fails on some systems with kernel 2.6.25 and 2.6.26 <zzam> kay: it is because glibc was compiled against linux-headers-2.6.27 or newer and issues signalfd4 syscall which was introduced in kernel 2.6.27 and not older signalfd syscall
2009-09-07modem-modeswitch rules: Match more devicesMartin Pitt
extras/modem-modeswitch/61-mobile-action.rules: Match on device class/subclass "00" as well, some devices like the Vodafone K3565-Z have that. https://launchpad.net/bugs/281335
2009-09-07fix whitespaceKay Sievers
2009-09-07util_run_program(): skip multiple spaces in argv creationKay Sievers
2009-09-07util_run_program: restore signal mask before executing event RUN commandsJeremy Kerr
External programs triggered by events (via RUN=) will inherit udev's signal mask, which is set to block all but SIGALRM. For most utilities, this is OK, but if we start daemons from RUN=, we run into trouble (especially as SIGCHLD is blocked). This change saves the original sigmask when udev starts, and restores it just before we exec() the external command. Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
2009-09-07udev_queue_get_seqnum_sequence_is_finished(): fix possible file handle leakFlorian Zumbiehl
2009-09-07udevadm: remove symlink support for old commandsKay Sievers
2009-09-07test: catch possible bug in GOTO resolvingKay Sievers
2009-09-07Revert "udev-rules.c: remove 'first_token' variable"Kay Sievers
That was a mistake. The variable is needed to be set before we parse the file. Thanks a lot to Alan Jenkins for spotting this. This reverts commit 710fdac1e49276683abe927472fe1b336960edd8.
2009-09-04make raw USB printer devices accessible for lpMartin Pitt
Starting from version 1.4, cups now uses libusb and printer USB devices instead of the usblp generated /dev/usb/lpX ones. In order to not require the cups USB backend to run as root now, change raw USB printer devices to be root:lp 0660, similar to usblpX devices. This might also enable the hplip backend to not run as root, since this has always used raw device nodes. https://launchpad.net/bugs/420015
2009-09-01udev-rules.c: parse_file() - fix possible buffer overflowFlorian Zumbiehl
2009-09-01udev-rules.c: remove 'first_token' variableKay Sievers
2009-09-01udev_util_encode_string(): fix possible buffer overflowFlorian Zumbiehl
2009-09-01libudev-util.c: get_sys_link() - return error for empty link targetKay Sievers
2009-09-01util_resolve_sys_link(): fix possible buffer overflowFlorian Zumbiehl
2009-09-01ude_rules.c: fix possible NULL pointer dereference in get_key()Florian Zumbiehl
2009-09-01rules: sound - do not use /usr/bin/envMarco d'Itri
The C version of path_id does not look at the environment anymore, so there is no reason to empty it.
2009-09-01pci-db: make sure we actually read the pci.ids file instead of usb.idsLennart Poettering
Since the recent Makefile.am rework both usb-db and pci-db were built to read the usb.ids database file. This fix makes sure pci-db properly reads pci.ids instead. Originally pointed out by Marco d'Itri.
2009-08-31rules: suse - use NAME for mapper/controlKay Sievers
2009-08-31update READMEKay Sievers
2009-08-30use nanosleep() instead of usleep()Daniel Mierswa
POSIX.1-2001 declares usleep() function obsolete and POSIX.1-2008 removes it. [Kay Sievers] - include time.h - use const for timespec - scsi_id: drop rand() in retry loop - modem-probe: rename msuspend() to msleep()
2009-08-30update TODOKay Sievers
2009-08-30util_create_path(): fix possible out of bounds array accessFlorian Zumbiehl
2009-08-30inotify_add_watch(): do not store watch, if it failedKay Sievers
On Sun, Aug 30, 2009 at 04:36, Marco d'Itri<md@linux.it> wrote: > inotify_add_watch may fail in udev_watch_begin, and then a link with > name -1 is created. > I do not know why, but it happened once on my system: > > lrwxrwxrwx 1 root root 27 Aug 4 11:27 -1 -> /devices/virtual/block/ram8
2009-08-29util_delete_path(): handle multiple leading slashesFlorian Zumbiehl
2009-08-29util_create_path(): fix errno usageKay Sievers
Based on a patch from: Florian Zumbiehl <florz@florz.de>