summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2013-03-23journald: remove unconditional log_*() use in the main loopKay Sievers
Setting MaxRetentionSec= caused the kernel log to overflow and the journal daemon to enter an endless loop. Logging from the journald main loop gets directed to /dev/kmsg, which wakes up journald again. We skip the import of this message by checking for our own PID, but this still causes the main loop to never go to sleep again because we never stopped logging from there.
2013-03-23TODO: add journal MaxRetentionSec= bugKay Sievers
2013-03-23hwdb: ID_PRODUCT_FROM_DATABASE --> ID_MODEL_FROM_DATABASEKay Sievers
With the conversion from pci-db + usb-db to hwdb, the property got accitentially renamed. Move the name back to the long established identifier *MODEL* instead of *PRODUCT*. $ git grep -l ID_MODEL_FROM_DATABASE hwdb/20-pci-vendor-model.hwdb hwdb/20-usb-vendor-model.hwdb hwdb/ids-update.pl man/systemd.device.xml rules/78-sound-card.rules src/core/device.c src/cryptsetup/cryptsetup.c
2013-03-23uaccess: remove needless usb_id call from udev rulesKay Sievers
2013-03-23udevd: ensure static nodes are created before local-fs mountFrederic Crozat
static nodes (like /dev/loop-control) are created when systemd-udevd is started and needed to mount loopback devices. Therefore, local-fs-pre.target should be only started after systemd-udevd is started.
2013-03-23TODO: add "dead" device node ACL handlingKay Sievers
2013-03-23TODO: updateKay Sievers
2013-03-22Update user session unit template.Auke Kok
While most folks will be using the derivative from user-session-units, I'm updating this one to reflect some of the fixes and things to note about user sessions: - cgroup should be set with "%u" - username instead of %I - set dbus path with %U explicitly too - hint to folks that wish to use MEM_CG features in user sessions - allow unit to be enabled for instances with systemctl enable
2013-03-23conf-parser: when we parse a string list, always fill in somethingLennart Poettering
Some code really wants to know whether there was a string list parsed, so don't take the shortcut here, and always allocate a string list, even if it is an empty one. https://bugs.freedesktop.org/show_bug.cgi?id=62558
2013-03-23journal: don't access j->files after useLennart Poettering
https://bugs.freedesktop.org/show_bug.cgi?id=62605
2013-03-22udevadm: place const in the right placeZbigniew Jędrzejewski-Szmek
Otherwise clang at least thinks that both consts apply to char.
2013-03-22bus: don't free an unallocated varZbigniew Jędrzejewski-Szmek
Also remove unused variable.
2013-03-22bus: move attribute to end of structure, so it is not ignoredZbigniew Jędrzejewski-Szmek
src/libsystemd-bus/bus-message.h:41:1: warning: attribute 'packed' is ignored, place it after "struct" to apply attribute to type declaration [-Wignored-attributes]
2013-03-23update TODOLennart Poettering
2013-03-23update TODOLennart Poettering
2013-03-23unit: never retroactively start requisitesLennart Poettering
Requesites are not supposed to be auto-started afterall, they are just checks, so don't try to be smarter here than appropriate. Based on a patch from Michal Schmidt.
2013-03-23Revert "units: ignore systemd-sysctl on shutdown"Lennart Poettering
This reverts commit faeffa73a81ab5b59acfadeb571431fb0e42af70. There isn't really much point in dropping the Conflicts= since shutting down this service is basically free as it doesn't have anything running. Also, the patch was incomplete, because shutdown.target was still listed in Before=.
2013-03-23add --with-telinit=PATH configure optionCristian Rodríguez
Distributions that never shipped upstart do not have "telinit" in /lib/upstart/.. Defaults to /lib/upstart/telinit so there is no change for systems existing installs.
2013-03-23journalctl: various fixes to the access check logicLennart Poettering
- Reword messages a bit - Correct check whether EACCES is in the set of errors - Don't complain if no journal files are found - allocate Set object for errors lazily since in the best case we don't need it at all. - don't consider it an error if /run/log/journal doesn't exist (because that's the usual case actually, if storage is enabled)
2013-03-22dbus: Do send out "replies" to signalsColin Walters
Some parts of systemd (at least the DBus activation codepath) "reply" to signals, which of course have the no-reply flag set. We will be defensive here and still send out a reply if we're passed a signal. Regression introduced by: c6a818c82035da91e Reported-by: Mantas Mikulėnas <grawity@gmail.com> Tested-by: Mantas Mikulėnas <grawity@gmail.com>
2013-03-22update TODOLennart Poettering
2013-03-22exec: Assigning the empty string to CapabilityBoundSet= should drop all capsLennart Poettering
Previously, it would set all caps, but it should drop them all, anything else makes little sense. Also, document that this works as it does, and what to do in order to assign all caps to the bounding set. https://bugzilla.redhat.com/show_bug.cgi?id=914705
2013-03-22Drop trailing whitespaceTollef Fog Heen
2013-03-22timedated: extra overflow safety check when doing relative time changesLennart Poettering
Ensure clients don't overflow usec_t when doing relative time changes. This is mostly just paranoia and protection against accidents, after all clients are already authenticated, and they can se the time to any value they wish anyway, but better be safe than sorry. https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1152187/comments/14
2013-03-22update TODOLennart Poettering
2013-03-22timedatectl: show CanNTP fieldLennart Poettering
2013-03-22udev: no need to output OOM, if we call log_oom() anywayLennart Poettering
2013-03-22main: minor simplificationLennart Poettering
2013-03-22udev/collect: avoid initalizing memory twiceZbigniew Jędrzejewski-Szmek
2013-03-22util: workaround two gcc warningsZbigniew Jędrzejewski-Szmek
gcc does not know that errno cannot be negative, and warns about unitialized variables later on. Kill the warnings by returning -errno only after checking that errno is positive.
2013-03-22journalctl: be smarter about journal error checksZbigniew Jędrzejewski-Szmek
There are many ways in which we can get those checks wrong, so it is better to warn and then error out on a real access failure. The error messages are wrapped to <80 lines, because their primary use is to be displayed in the terminal, and it is easier to read them this way. Reading them in the journal can be a bit trickier, but this is a bug in logs-show.c.
2013-03-22build-sys: move acl searching code into libsystemd-aclZbigniew Jędrzejewski-Szmek
This loop over acls is a bit too much to keep inside of another loop.
2013-03-22hostnamed: pretty_string_is_safe() already exists in string_has_cc(), so use ↵Lennart Poettering
that
2013-03-22util: be more picky when validating hostnamesLennart Poettering
No longer allow dots at the beginning or end of host names, Or double dots. https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1152187/comments/14
2013-03-22journalctl: give a nice hint about group membership based on ACLs of ↵Lennart Poettering
/var/log/journal If we notice that we unprivileged and not in any of the groups which have access to /var/log/journal, print a nice message about which groups do. This checks and prints all groups that are in the default ACL for /var/log/journal, which is not necessarily correct for all journal files, but pretty close.
2013-03-22cgroup: minor optimizationLennart Poettering
2013-03-22bus: implement object handler registryLennart Poettering
2013-03-22mount: mount all cgroup controllers in containers, tooLennart Poettering
2013-03-22main: use strv_find() where we canLennart Poettering
2013-03-22main: don't mount cgroup controller unless PID == 1Lennart Poettering
This completes c1dae1b3c9729fb8ab749dd4e2dad07e0fad7ed8 in a way.
2013-03-21Fix vacuum logic errorJan Alexander Steffens (heftig)
The vacuum code used to stop vacuuming after one deletion, even when max_use was still exceeded. Also make usage a uint64_t, as the code already pretends it is one. Signed-off-by: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
2013-03-21man/shutdown: /etc/nologin is called /run/nologin nowZbigniew Jędrzejewski-Szmek
2013-03-21systemd-python: allow retrieval of single fieldsZbigniew Jędrzejewski-Szmek
This can give huge efficiency gains, e.g. if only MESSAGE is required and all other fields can be ignored.
2013-03-21systemd-python: split out realtime and monotonic into separate functionsZbigniew Jędrzejewski-Szmek
This matches the C API more closely, and also enables the user to get just partial information, should she desire to do so. Functions names in error messages are modified to not include the class name, because Python uses just the function name into functions declared as METH_NOARGS, and error messages were inconsistent.
2013-03-21systemd-python: implement _Reader.test_cursorZbigniew Jędrzejewski-Szmek
Getting the cursor is split out from .get_next() into .get_cursor(). This mirrors the C API more closely, and also makes things a bit faster if the cursor is not needed.
2013-03-21systemd-python: cleanup up usec_t handlingZbigniew Jędrzejewski-Szmek
The behaviour wrt. seconds vs. microseconds was inconsistent. Now _Reader always uses native units (us), while Reader always uses seconds and accepts both floats and ints. This way the conversion is always done in the Python layer, and the lower level API allows access to the journal API without the potentially lossy conversion between double and uint64_t.
2013-03-21systemd-python: export sd_journal_get_usageZbigniew Jędrzejewski-Szmek
2013-03-21efivars: fix return codeZbigniew Jędrzejewski-Szmek
Was returning 1 on read error.
2013-03-21shutdownd: shut up bogus gcc warningZbigniew Jędrzejewski-Szmek
This one is fake. But let's kill it, avoiding two condition checks in the process. src/shutdownd/shutdownd.c: In function 'when_wall': src/shutdownd/shutdownd.c:182:44: warning: 'sub' may be used uninitialized in this function [-Wmaybe-uninitialized] return elapse > sub ? elapse - sub : 1; ^
2013-03-21bootchart: fix two unitialized memory freesZbigniew Jędrzejewski-Szmek
The new gcc isn't bad! In file included from src/bootchart/svg.c:36:0: src/bootchart/svg.c: In function 'svg_ps_bars': ./src/shared/util.h:524:13: warning: 'enc_name' may be used uninitialized in this function [-Wmaybe-uninitialized] free(*(void**) p); ^ src/bootchart/svg.c:821:37: note: 'enc_name' was declared here char _cleanup_free_*enc_name; ^ CC src/udev/mtd_probe/mtd_probe-probe_smartmedia.o XSLT man/systemd.unit.5 In file included from src/bootchart/svg.c:36:0: src/bootchart/svg.c: In function 'svg_pss_graph': ./src/shared/util.h:524:13: warning: 'enc_name' may be used uninitialized in this function [-Wmaybe-uninitialized] free(*(void**) p); ^ src/bootchart/svg.c:395:37: note: 'enc_name' was declared here char _cleanup_free_*enc_name; ^