Age | Commit message (Collapse) | Author |
|
On Wed, Mar 03, 2004 at 04:56:34PM -0800, Greg KH wrote:
> On Wed, Mar 03, 2004 at 03:57:04PM -0800, Patrick Mansfield wrote:
> >
> > Here is a patch for some new tests.
>
> Applied, thanks.
Here is a small improvement, which looks much better.
Hey Pat, thanks a lot for finding the recent bug, hope this one will
not break it again :)
|
|
remove extraneous word.
|
|
Here I try to make the style a bit more consistant in the different
files, so that new patches just copy the 'right' one :)
Some "magic" numbers are replaced and udevtest.c is catched up with udev.
|
|
Here is a patch for some new tests.
|
|
On Wed, Mar 03, 2004 at 02:43:34PM -0800, Patrick Mansfield wrote:
> Here is a fix and a new test for the problem Atul hit, where if we have a
> NAME based on a result of the form:
>
> NAME="foo-%c{7}"
>
> udev truncates the name. Without any prefix (the foo- in this example),
> the rule was working OK.
Here is a fix for the fix :)
Sorry, I broke it yesterday.
|
|
|
|
|
|
Here I try to cleanup our various multifield iteration over the strings.
Inspired by our nice list.h we now have a macro to iterate over the string
and process the parts of it:
It makes the code more readable and we don't change the string while we
process it like the former strsep() does.
Example:
foreach_strpart(dev->symlink, " ", pos, len) {
if (strncmp(&dev->symlink[pos], find_name, len) != 0)
continue;
...
}
For the callout part selector %c{2} we separate now not only by space but
also newline and return characters, cause some programs may give multiline
values back. A possible RESULT match must contain wildcards for these
characters.
Also a bug in the recent udevinfo symlink query feature is fixed.
|
|
|
|
|
|
Here we rename the former tiny $(HELPER) to $(INFO)
cause it's no longer only a helper :)
And install it in /usr/bin instead of /sbin cause any user
may want to call it and we don't need it on startup.
|
|
Is this something for the blacklist?
/sys/class/pcmcia_socket/
|-- pcmcia_socket0
| |-- device -> ../../../devices/pci0000:00/0000:00:1e.0/0000:02:00.0
| `-- driver -> ../../../bus/pci/drivers/yenta_cardbus
`-- pcmcia_socket1
|-- device -> ../../../devices/pci0000:00/0000:00:1e.0/0000:02:00.1
`-- driver -> ../../../bus/pci/drivers/yenta_cardbus
|
|
|
|
grrr...robert...
|
|
|
|
|
|
|
|
|
|
|
|
|
|
I just wanted to terminate the snprintf() strings, cause I can see a
overflow with closed eyes after all the audit :)
But then I changed a bit more to bring it in line with the style of the
other files. I replaced the exec_udev() function with the one from
udevd, cause we don't need to read the stdout from udev.
Please have a look if it still works for you too and not
only for usernames with 3 characters :)
|
|
On Mon, 2004-03-01 at 20:08, Robert Love wrote:
> Ack, I did not even see that! Thanks.
>
> Let's rip that out, and always use the new built-in logic to determine
> what initscript to install.
Hm, looks like we do not need the %{lsb} and USE_LSB logic at all,
anymore.
Here is the patch, updated, removing both completely.
|
|
While moving the local user logic in it's own function I missed to
change the "secure" string macro. We copy only the first 3 bytes
of the username. Guess why I didn't notice it :)
|
|
to want to share :(
|
|
|
|
Taken from udev-018-2.src.rpm from Fedora Devel.
|
|
<harald@redhat.com>
This can be used instead of the start_udev script for systems
that do not have a shell, or some other problem...
|
|
Fix for recent unlink patch.
|
|
I promise, that I will not take every item you put in the TODO list :)
|
|
It seems that the long attribute list can confuse the user.
Se here we print a few words on top the attributes.
|
|
Thanks to Olaf Hering <olh@suse.de> for this patch. It's possible now to
feed the -n option of udevinfo with a symlink.
I've also added a 'all' attribute, but no more text, it's all in the
included man page :)
|
|
Based on the patch in the Gentoo repo.
|
|
The endptr is never NULL, so here we hopefully do the right thing.
|
|
On Mon, 2004-03-01 at 17:44, Greg KH wrote:
> Hm, that should be Robert's job actually, he should do something for
> real... :)
Hey, I wrote the nifty local user detection snippet - but, I owe Kay, so
here is an updated man page.
|
|
|
|
|
|
Here is a small change to the udev man page:
- clarify the use of the NAME{all_partitions} syntax
and add a example to udev.rules.example
- mention the empty NAME field to ignore the device
- prepare a SYMLINK field for the addition of Andrey's
"multiple symlinks" documentation :)
|
|
no_error_on_enoent: do not exit with an error and delete all files
when a device or directory does not exist.
|
|
man-dashes.diff: escape dashes in man pages, helps with UTF-8 locales
(by Philipp Matthias Hahn).
|
|
fix_expr: remove usage of expr in ide-devfs.sh, because it may be in
/usr/bin and not available at early boot time.
|
|
On Sat, Feb 28, 2004 at 09:56:32PM +0100, Kay Sievers wrote:
> Andrey pointed out that we don't print the right filename in the debug
> output. Here is a fix for that. It applies on top of Andrey's symlink
> patch, cause we are touching the same part of the code.
The copy/paste devil catched me :)
Here is a fixed one.
|
|
We carried the the old callout part selector syntax for two releases
now after it was replaced by the new %c{1} syntax. So here we remove
the old syntax and use the code to possibly specify the maximum count
of chars to insert into the string. It will work with all of our format
chars.
I don't know if somebody will use it, but the code is already there :)
's%3s{vendor}' returns "IBM" now, instead of "IBM-ESXS".
Also added is a test for it and a few words in the man page.
|
|
|
|
|
|
We want to kill udevd after installing a new version, cause the event
contains a magic with the version number of udev.
|
|
Here is for now my last patch to the string handling for a rather
theorethical case, where the node is very very very long. :)
We have accordant to strfieldcat(to, from) now a strintcat(to, i) macro,
which appends the ascii representation of a integer to a string in a
safe way.
|
|
|
|
This patch syncs the scsi_id in the udev tree to version 0.4.
|
|
|
|
On Thu, Feb 12, 2004 at 05:26:37PM -0800, Greg KH wrote:
> On Fri, Feb 13, 2004 at 12:45:38AM +0100, Kay Sievers wrote:
> >
> > Here a few questions about my favorite file in the tree :)
> > - better permission handling
> >
> > What is missing here?
>
> I don't know for sure. Just a vague feeling that the way we currently
> handle permissions is pretty lousy. Anyone else feel this way too?
Seems that nobody cares and perhaps the recent klibc permission changes
and the multiple file config directory are enough to kill these lines? :)
|