summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-08-05Unify parse_argv styleZbigniew Jędrzejewski-Szmek
getopt is usually good at printing out a nice error message when commandline options are invalid. It distinguishes between an unknown option and a known option with a missing arg. It is better to let it do its job and not use opterr=0 unless we actually want to suppress messages. So remove opterr=0 in the few places where it wasn't really useful. When an error in options is encountered, we should not print a lengthy help() and overwhelm the user, when we know precisely what is wrong with the commandline. In addition, since help() prints to stdout, it should not be used except when requested with -h or --help. Also, simplify things here and there. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-08-05Include missing.h in udev-builtin-btrfs.c, and move BTRFS_IOC_DEVICES_READY ↵Anthony G. Basile
to missing.h This is a combination of upstream commits dced15575f7bf172e3c9d798c43477539525558c 7bed7f0e3b1f9596aedb64657e432e5b267adebb by Simon McVittie <simon.mcvittie@collabora.co.uk> 7bed7f0e3b1f9596aedb64657e432e5b267adebb Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-08-04man: add udev.conf(5)Zbigniew Jędrzejewski-Szmek
We generally have separate man pages for all configuration files. In this case udev.conf was already described in systemd-udevd.service(8), but it was hard to find. Docbook makes it hard to add a .so link from a different section, so describe udev.conf in its own page. Signedaoff-by: Anthony G. Basile <blueness@gentoo.org>
2014-08-04Reject invalid quoted stringsZbigniew Jędrzejewski-Szmek
String which ended in an unfinished quote were accepted, potentially with bad memory accesses. Reject anything which ends in a unfished quote, or contains non-whitespace characters right after the closing quote. _FOREACH_WORD now returns the invalid character in *state. But this return value is not checked anywhere yet. Also, make 'word' and 'state' variables const pointers, and rename 'w' to 'word' in various places. Things are easier to read if the same name is used consistently. mbiebl_> am I correct that something like this doesn't work mbiebl_> ExecStart=/usr/bin/encfs --extpass='/bin/systemd-ask-passwd "Unlock EncFS"' mbiebl_> systemd seems to strip of the quotes mbiebl_> systemctl status shows mbiebl_> ExecStart=/usr/bin/encfs --extpass='/bin/systemd-ask-password Unlock EncFS $RootDir $MountPoint mbiebl_> which is pretty weird Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-08-04Fix misuse of uint64_t as size_tZbigniew Jędrzejewski-Szmek
They have different size on 32 bit, so they are really not interchangable. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-08-04libudev: set errno when udev_device_new_from_* or udev_device_get_parent_* failTom Gundersen
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-08-04hwdb/ids-update.pl: bring up to date with upstream.Kay Sievers
This includes pieces of the following commits: d060b62fcb4746d3758c567e9379c6728a035b66 bd63a88fb0478da2e93c363849b73aed8be36ae7 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-08-04hwdb: updateKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-08-04keymap: Annotate all micmute workaroundsMartin Pitt
Add a comment to all assignments to f20 that this actually should be "micmute" in a future when we aren't limited by X.org's key code limiations any more. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-08-04keymap: Add microphone mute keymap for Dell LatitudeHui Wang
On the Dell Latitude, the mic mute key event is generated by wmi driver, the keycode assigned to this hotkey from kernel is KEY_MICMUTE (248), this keycode is too big for xorg to handle, in the xorg, the XF86AudioMicMute is assigned to F20. Please refer to 4e648ea0 of xkeyboard-config. BugLink: https://bugs.launchpad.net/bugs/1326684 BugLink: https://bugs.launchpad.net/bugs/1339998 Signed-off-by: Hui Wang <hui.wang@canonical.com> Signed-off-by: Martin Pitt <martin.pitt@ubuntu.com> Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-30udev: fixup commit dd5eddd28a74a49607a8fffcaf960040dba98479Hannes Reinecke
Commit dd5eddd28a74a49607a8fffcaf960040dba98479 accidentally removed one line too many. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-30udev: place opening { at the same line as the function declarationKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-30udev: unify event timeout handlingKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-30udevd: add --event-timeout commandline optionHannes Reinecke
Some events take longer than the default 30 seconds. Killing those events will leave the machine halfway configured. Add a commandline option '--event-timeout' to handle these cases. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-25udev: exclude MD from block device ownership event lockingKay Sievers
MD instantiates devices at open(). This is incomptible with the locking logic, as the "change" event emitted when stopping a device will bring it back. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-19Be more careful when checking for empty filesZbigniew Jędrzejewski-Szmek
If we want to avoid reading a totally empty file, it seems better to check after we have opened the file, not before. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-15src/libudev/Makefile.am: update libudev revisionAnthony G. Basile
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-10accelerometer: Don't wait for new data from the sensorBastien Nocera
Instead of waiting for new data from the sensor, which might be a long time coming, depending on the sensor device, ask the kernel for the last state for that particular input device. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-06configure.ac: bump to 1.9 = upstream 215eudev/v1.9Anthony G. Basile
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-06src/libudev/util.c: import flush_fd() from upstreamAnthony G. Basile
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-05hwdb: updateKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-05hwdb: Update database of Bluetooth company identifiersMarcel Holtmann
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-02rules: don't enable usb pm for Avocent devicesTom Hirst
The Avocent KVM over IP devices doesn't work correctly with USB power management enabled. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-01libudev: queue - watch entire directory to allow the re-use of the watch ↵Kay Sievers
descriptor Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-01libudev: queue provide file descriptor to watch busy event queueKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-07-01libudev: fix udev_queue_get_queue_is_empty() logicKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-24configure.ac: separate out rootlibdir and rootlibexecdirAnthony G. Basile
2014-06-24configure.ac: improve install paths for udevlibexecdir, udevkeymapdir, ↵Anthony G. Basile
udevkeymapforceredir, udevrulesdir
2014-06-24gudev: replace regex with sym fileKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-19configure.ac: bump to 1.8 = upstream 214eudev/v1.8Anthony G. Basile
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-19rules: add loop-control and btrfs-control to "disk" groupKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-19hwdb: Update database of Bluetooth company identifiersMarcel Holtmann
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-15udev: check the return value from udev_enumerate_scan_devicesThomas Hindoe Paaboel Andersen
The return value from udev_enumerate_scan_devices was stored but never used. I assume this was meant to be checked. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-15udev: really exclude device-mapper from block device ownership event lockingChristian Hesse
Arguments were wrong order, no? This fixes commits: e918a1b5a94f270186dca59156354acd2a596494 3d06f4183470d42361303086ed9dedd29c0ffc1b Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-15udev: assign group "input" to all input devicesKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-15udev: stop using "floppy" groupKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-07hwdb: fix case-sensitive matchKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-07keyboard: add Plantronics .Audio mute buttonZbigniew Jędrzejewski-Szmek
https://bugs.freedesktop.org/show_bug.cgi?id=79495 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-07keymap: Asus EeePC touchpad toggle keyMartin Pitt
Originally is KEY_TOUCHPAD_TOGGLE, but X.org can't handle the big key events, so use the F21 convention. https://bugs.freedesktop.org/show_bug.cgi?id=72807 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-07keymap: Add Lenovo Enhanced USB KeyboardMartin Pitt
https://bugs.freedesktop.org/show_bug.cgi?id=77234 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-07udev: guard REREADPT by exclusive lock instead of O_EXCLKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-07udev: make sure we always get "change" for the diskKay Sievers
The kernel will return 0 for REREADPT when no partition table is found, we have to send out "change" ourselves. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-07udev: guard REREADP logic with open(O_ECXL)Kay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-07[PATCH] udev: try first re-reading the partition tableAnthony G. Basile
mounted partitions: # dd if=/dev/zero of=/dev/sda bs=1 count=1 UDEV [4157.369250] change .../0:0:0:0/block/sda (block) UDEV [4157.375059] change .../0:0:0:0/block/sda/sda1 (block) UDEV [4157.397088] change .../0:0:0:0/block/sda/sda2 (block) UDEV [4157.404842] change .../0:0:0:0/block/sda/sda4 (block) unmounted partitions: # dd if=/dev/zero of=/dev/sdb bs=1 count=1 UDEV [4163.450217] remove .../target6:0:0/6:0:0:0/block/sdb/sdb1 (block) UDEV [4163.593167] change .../target6:0:0/6:0:0:0/block/sdb (block) UDEV [4163.713982] add .../target6:0:0/6:0:0:0/block/sdb/sdb1 (block) Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-07udev: synthesize "change' events for partitions when tools change the diskKay Sievers
This should make sure that fdisk-like programs will automatically cause an update of all partitions, just like mkfs-like programs cause an update of the partition. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-06udevd: inotify - modernizationsKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-06udev: exclude device-mapper from block device ownership event lockingKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-06udev: always close lock file descriptorKay Sievers
https://bugs.freedesktop.org/show_bug.cgi?id=79576 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-01udev-builtin-keyboard: do tell on which device EVIOCSKEYCODE failed.Cristian Rodríguez
I am getting "Error calling EVIOCSKEYCODE (scan code 0xc022d, key code 418): Invalid argument", the error message does not tell on which specific device the problem is, add that info. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2014-06-01configure.ac: bump to 1.7 = upstream 213eudev/v1.7Anthony G. Basile
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>