summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-08-04bus-proxy: add ExecReload=David Herrmann
Make sure we support ExecReload= for bus-proxyd to reload configuration during runtime. This is *really* handy when hacking on kdbus. Package-managers are still recommended to run `busctl --address=unix:path=` directly.
2015-07-31Merge pull request #813 from dvdhrm/bus-clientLennart Poettering
busctl: make sure --address connects as bus-client
2015-07-31Merge pull request #812 from zonque/testDavid Herrmann
Add some more tests
2015-07-31Merge pull request #814 from dvdhrm/mfreeDaniel Mack
tree-wide: introduce mfree()
2015-07-31Merge pull request #815 from poettering/coding-style-forDaniel Mack
CODING_STYLE: say that "for (;;)" is better than "while (1)"
2015-07-31busctl: make sure --address connects as bus-clientDavid Herrmann
There is really no reason to use `busctl` to connect to legacy private bus endpoints. Fix this and make sure `busctl --address=unix:path=/foo` works!
2015-07-31CODING_STYLE: say that "for (;;)" is better than "while (1)"Lennart Poettering
2015-07-31test-socket-util: add test for in_addr_is_null()Daniel Mack
2015-07-31test-util: add more testsDaniel Mack
Add tests for safe_ato[iu]16() and some more unbase32hexmem() torture.
2015-07-31test: add test for static listsDaniel Mack
Test af-list and arphdr-list.
2015-07-31tree-wide: introduce mfree()David Herrmann
Pretty trivial helper which wraps free() but returns NULL, so we can simplify this: free(foobar); foobar = NULL; to this: foobar = mfree(foobar);
2015-07-31Merge pull request #811 from namhyung/busctl-misc-v2Daniel Mack
busctl: Misc cleanups and a fix (v2)
2015-07-31Merge pull request #810 from mamikk/bitmap-fixes-v2Daniel Mack
Bitmap fixes v2
2015-08-01busctl: fix assertion failure on --size optionNamhyung Kim
Using --size option triggers an assert failure below because parse_size() requires the second argument, base, being either 1000 or 1024. As it's for a packet size, it'd be better using IEC binary suffix (base 1024) IMHO. $ busctl --size 2048 Assertion 'base == 1000 || base == 1024' failed at src/basic/util.c:2222, function parse_size(). Aborting. Aborted (core dumped)
2015-08-01busctl: add missing description of --size optionNamhyung Kim
The size option was to specify maximum captured patch length but was missing its description in the command line help. Add it.
2015-08-01busctl: add and use strcmp_ptr()Namhyung Kim
In member_compare_func(), it compares interface, type and name of members. But as it can contain NULL pointer, it needs to check them before calling strcmp(). So make it as a separate strcmp_ptr function (named after streq_ptr) so that it can be used by others. Also let streq_ptr() to use it in order to make the code simpler.
2015-07-31hwdb: Update database of Bluetooth company identifiersMarcel Holtmann
2015-07-31bitmap: make bitmap_clear free the bitmap arrayMartin Mikkelsen
Given two bitmaps and the following code: Bitmap *a = bitmap_new(), *b = bitmap_new(); bitmap_set(a, 1); bitmap_clear(a); bitmap_set(a, 0); bitmap_set(b, 0); These two bitmaps should now have the same bits set and they should be equal but bitmap_equal() will return false in this case because while bitmap_clear() resets the number of elements in the array it does not clear the array and bitmap_set() expects the array to be cleared. GREEDY_REALLOC0 looks at the allocated size and not the actual size so it does not clear any memory. Fix this by freeing the allocated memory and resetting the whole Bitmap to an initial state in bitmap_clear(). This also adds test code for this issue.
2015-07-31bitmap: fix bitmap_equal on bitmaps with unset bitsMartin Mikkelsen
Given two bitmaps and the following code: Bitmap *a = bitmap_new(), *b = bitmap_new(); bitmap_set(a, 0); bitmap_unset(a, 0); These two bitmaps should now have the same bits set and they should be equal but bitmap_equal() will return false in this case because the bitmaps array in a is larger because of the bit which was previously set. Fix this by comparing only the bits which exists in both bitmaps and then check that the rest of the bits (if any) is all zero. This also adds test code for this issue.
2015-07-31bus-proxy: allow empty arguments to UpdateActivationEnvironment()systemd/v224David Herrmann
There is no reason to prevent empty argument lists on UpdateActivationEnvironment(). Make sure we don't fail, but still skip the call to pid1.
2015-07-31NEWS: updateDavid Herrmann
Add new functionality and behavior changes to NEWS for the imminent bugfix release 224.
2015-07-31build: bump version to 224David Herrmann
Prepare for bug-fix release and bump versions.
2015-07-31hwdb: updateKay Sievers
2015-07-31Merge pull request #806 from dvdhrm/proxy-cookieLennart Poettering
bus-proxy: fix cookie namespacing
2015-07-31logind: release VT-positions when closing sessionsDavid Herrmann
Make sure we release VT-positions when a session is closed. Otherwise, lingering sessions will occupy VTs and prevent next logins from succeeding. Note that we already release session-devices when closing a session, so there cannot be anyone using the VT anymore.
2015-07-31bus-proxy: fix cookie namespacingDavid Herrmann
If we generate messages from within bus-proxyd, we really must make sure that we do not clutter the cookie-namespace of our client. The client has full control over it, so we cannot steal cookies from it. However, we can re-use the cookie the client used for our request. As long as we only send a single message, we're fine.
2015-07-31timesyncd: remove RLIMIT_NPROCKay Sievers
NSS plugins might create additional threads. Remove the limit, we cannot really make any assumptions here.
2015-07-31Merge pull request #803 from mixi/masterKay Sievers
build-sys: use 'test -f' instead of AC_CHECK_FILE
2015-07-31Merge pull request #804 from dvdhrm/proxy-directed2Daniel Mack
bus-proxy: make NameAcquired/Lost directed (v2)
2015-07-31Merge pull request #805 from dvdhrm/proxy-activationDaniel Mack
bus-proxy: make StartServiceByName synchronous
2015-07-31bus-proxy: make StartServiceByName synchronousDavid Herrmann
The StartServiceByName() call was provided by dbus-daemon to activate a service without sending a message. On receiption, dbus-daemon schedules an activation request (different modes are supported) and sends back the reply once activation is done. With kdbus, we marked StartServiceByName() as deprecated. There is no real reason to start services explicitly. Instead, applications should just *use* the service and rely on it being activated implicitly. However, we provide compatibility with dbus-daemon and implement StartServiceByName() on the proxy via a call to org.freedesktop.DBus.Peer.Ping() on the destination. This will activate the peer implicitly as part of the no-op Ping() method call (regardless whether the peer actually implements that call). Now, the problem is, StartServiceByName() was synchronous on dbus-daemon but isn't on bus-proxy. Hence, on return, there is no guarantee that ListNames includes the activated name. As this is required by some applications, we need to make this synchronous. This patch makes the proxy track the Ping() method call and send the reply of StartServiceByName() only once Ping() returned. We do not look at possible errors of Ping(), as there is no strict requirement for the peer to implement org.freedesktop.DBus.Peer. Furthermore, any interesting error should have already been caught by sd_bus_send() before. Note: This race was triggered by gdbus. The gdbus-proxy implementation relies on a name to be available after StartServiceByName() returns. This is highly fragile and should be dropped by gdbus. Even if the call is synchronous, there is no reason whatsoever to assume the service did not exit-on-idle before ListNames() returns. However, this race is much less likely than the startup race, so we try to be compatible to dbus-daemon now.
2015-07-31build-sys: use 'test -f' instead of AC_CHECK_FILEJohannes Nixdorf
AC_CHECK_FILE fails when cross-compiling. It is intended to be used to check for files that are used at runtime during build time (e.g. /etc/passwd, /dev/*) [1]. For files which are only used at build time 'test -f' is sufficient. [1]: https://lists.gnu.org/archive/html/autoconf/2000-10/msg00018.html
2015-07-31bus-proxy: don't filter directed signalsDavid Herrmann
NameAcquired and NameLost are directed signals. Never ever filter them on dbus1. On dbus1, filters *exclusively* apply to broadcasts! Hence, we must always forward directed signals unconditionally!
2015-07-31bus-proxy: fix NameAcquired and NameLost to be directedDavid Herrmann
The NameAcquired and NameLost signals are _directed_ signals. Make sure we properly set the destination correctly, and verify it in our proxy-test.
2015-07-31basic: fix error/memleak in socket-utilDavid Herrmann
Probably a typo, checking 'ret' instead of the return value 'p'. This might cause the function to return failure, even though it succeeded. Furthermore, it might leak resources.
2015-07-31Merge pull request #799 from andreaskem/hwdb-pullDaniel Mack
hwdb: DPI info for Logitech G402 mouse
2015-07-31hwdb: Add mouse DPI info for Logitech G402.Andreas Kempf
DPI information was taken from the device's setup guide. Additional (shortened) information from udevadm info: P: .../usb2/2-1/2-1:1.0/0003:046D:C07E.0002/input/input6/event2 N: input/event2 S: input/by-id/usb-Logitech_Gaming_Mouse_G402_6D93117D5049-event-mouse S: input/by-path/pci-0000:00:12.0-usb-0:1:1.0-event-mouse ... E: ID_BUS=usb E: ID_INPUT=1 E: ID_INPUT_MOUSE=1 E: ID_MODEL=Gaming_Mouse_G402 E: ID_MODEL_ENC=Gaming\x20Mouse\x20G402 E: ID_MODEL_ID=c07e E: ID_PATH=pci-0000:00:12.0-usb-0:1:1.0 E: ID_PATH_TAG=pci-0000_00_12_0-usb-0_1_1_0 E: ID_REVISION=9002 E: ID_SERIAL=Logitech_Gaming_Mouse_G402_6D93117D5049 E: ID_SERIAL_SHORT=6D93117D5049 E: ID_TYPE=hid E: ID_USB_DRIVER=usbhid E: ID_USB_INTERFACES=:030102:030000: E: ID_USB_INTERFACE_NUM=00 E: ID_VENDOR=Logitech E: ID_VENDOR_ENC=Logitech E: ID_VENDOR_ID=046d E: LIBINPUT_DEVICE_GROUP=3/46d/c07e/111:usb-0000:00:12.0-1 E: MAJOR=13 E: MINOR=66 E: SUBSYSTEM=input ...
2015-07-31hwdb: Update info for potential contributors.Andreas Kempf
Update the location of the bug tracker and mention that pull requests are preferred.
2015-07-30systemd-boot: sort /EFI/Linux/*.efi filesKay Sievers
2015-07-30unit-name: fix memory leakDaniel Mack
Fix a memory leak introduced by 2fc09a9c. 's' is used twice in this function, and if free_and_strdup() fails, the pointer is left untouched.
2015-07-30Merge pull request #787 from dvdhrm/bus-listDaniel Mack
sd-bus: fix parsing of KDBUS_CMD_LIST
2015-07-30sd-bus: fix parsing of KDBUS_CMD_LISTDavid Herrmann
We *must not* assume that an entry returned by KDBUS_CMD_LIST only carries a single KDBUS_ITEM_OWNED_NAME. Similarly, we already parse multiple such items for message-metadata, so make sure we support the same on KDBUS_CMD_LIST. By relying on the kernel to return all names separately, we limit the kernel API significantly. Stop this and let the kernel decide how to return its data.
2015-07-30Merge pull request #784 from eworm-de/typoDaniel Mack
man: fix typo in man systemd-machine-id-commit
2015-07-30Merge pull request #785 from zonque/free-and-strdupDavid Herrmann
tree-wide: use free_and_strdup()
2015-07-30tree-wide: use free_and_strdup()Daniel Mack
Use free_and_strdup() where appropriate and replace equivalent, open-coded versions.
2015-07-30man: fix typo in man systemd-machine-id-commitChristian Hesse
2015-07-30Merge pull request #783 from whot/hwdb-updatesDaniel Mack
Hwdb updates
2015-07-30hwdb: add min/max/resolution override for Appletouch one-button touchpadsPeter Hutterer
Macbook2,1, late 2006 model. https://bugzilla.redhat.com/show_bug.cgi?id=1246651
2015-07-30hwdb: add resolution values for Asus K52JT touchpadPeter Hutterer
https://bugs.freedesktop.org/show_bug.cgi?id=91364
2015-07-29Merge pull request #779 from poettering/fflush-and-checkDaniel Mack
tree-wide: port everything over to fflush_and_check()