summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-12-12Merge pull request #4867 from keszybz/catalog-messagesLennart Poettering
Catalog message improvements
2016-12-11basic/log: CODE_FUNCTION → CODE_FUNCZbigniew Jędrzejewski-Szmek
systemd.journal-fields(7) documents CODE_FUNC=. Internally, we were inconsistent: sd_journal_print uses CODE_FUNC=, log.h has CODE_FUNCTION=, python-systemd and bootchart also used CODE_FUNC=, when they were internal. Most external projects use sd_journal_* functions, so CODE_FUNC=, python-systemd still uses CODE_FUNC=, as does systemd-bootchart, and independent reimplementations in golang-github-coreos-go-systemd, qtbase, network manager, glib, pulseaudio. Hence, I don't think there's much choice.
2016-12-11share/log: change log_syntax from "[a:b] " to "a:b: "Zbigniew Jędrzejewski-Szmek
Those square brackets don't fit how our other messages look like; we use colons everywhere else. The "[a:b]" format was originally added in ed5bcfbe3c3b68e59242c03649eea03a9707d318, and remained unchanged for 7 years, but in the meantime other conventions evolved. The new version is also one character shorter. [/etc/systemd/system/systemd-networkd.service.d/override.conf:2] Failed to parse sec value, ignoring: ... ↓ /etc/systemd/system/systemd-networkd.service.d/override.conf:2: Failed to parse sec value, ignoring: ...
2016-12-11basic/log: merge two big log_struct_internal invocations into oneZbigniew Jędrzejewski-Szmek
We can take advantage of the fact a NULL argument terminates the list.
2016-12-11tools/catalog-report.py: a script to scour the journal for bad catalog entriesZbigniew Jędrzejewski-Szmek
I think it can be a useful tool to find such issues. SD_MESSAGE_UNIT_STARTING 7d4958e842da4a758f6c1cdc7b36dcc5: no field UNIT ../src/core/unit.c:1239 unit_status_log_starting_stopping_reloading Starting Paths. SYSLOG_FACILITY=3 SYSLOG_IDENTIFIER=systemd PRIORITY=6 USER_UNIT=paths.target SD_MESSAGE_UNIT_STARTED 39f53479d3a045ac8e11786248231fbf: no field UNIT ../src/core/job.c:721 job_log_status_message Reached target Paths. SYSLOG_FACILITY=3 SYSLOG_IDENTIFIER=systemd PRIORITY=6 RESULT=done USER_UNIT=paths.target SD_MESSAGE_STARTUP_FINISHED b07a249cd024414a82dd00cd181378ff: no field KERNEL_USEC ../src/core/manager.c:2532 manager_check_finished Startup finished in 19ms. SYSLOG_FACILITY=3 SYSLOG_IDENTIFIER=systemd PRIORITY=6 USERSPACE_USEC=19670 SD_MESSAGE_STARTUP_FINISHED b07a249cd024414a82dd00cd181378ff: no field INITRD_USEC ../src/core/manager.c:2532 manager_check_finished Startup finished in 19ms. SYSLOG_FACILITY=3 SYSLOG_IDENTIFIER=systemd PRIORITY=6 USERSPACE_USEC=19670 unknown 0ce153587afa4095832d233c17a88001: no catalog entry gsm-manager.c:1366 start_phase Entering running state SYSLOG_IDENTIFIER=gnome-session PRIORITY=5 SD_MESSAGE_UNIT_STOPPING de5b426a63be47a7b6ac3eaac82e2f6f: no field UNIT ../src/core/unit.c:1239 unit_status_log_starting_stopping_reloading Stopping Default. SYSLOG_FACILITY=3 SYSLOG_IDENTIFIER=systemd PRIORITY=6 USER_UNIT=default.target SD_MESSAGE_UNIT_STOPPED 9d1aaa27d60140bd96365438aad20286: no field UNIT ../src/core/job.c:729 job_log_status_message Stopped target Default. SYSLOG_FACILITY=3 SYSLOG_IDENTIFIER=systemd PRIORITY=6 RESULT=done USER_UNIT=default.target SD_MESSAGE_TIME_CHANGE c7a787079b354eaaa9e77b371893cd27: no field REALTIME src/core/manager.c:2049 manager_dispatch_time_change_fd Time has been changed SYSLOG_FACILITY=3 SYSLOG_IDENTIFIER=systemd PRIORITY=6 unknown f3ea493c22934e26811cd62abe8e203a: no catalog entry shell-global.c:1375 shell_global_log_structured GNOME Shell started at Sat Jun 11 2016 12:37:46 GMT-0400 (EDT) SYSLOG_IDENTIFIER=gnome-shell SD_MESSAGE_UNIT_FAILED be02cf6855d2428ba40df7e9d022f03d: no field UNIT src/core/job.c:803 job_log_status_message Failed to start GNOME Terminal Server. SYSLOG_FACILITY=3 SYSLOG_IDENTIFIER=systemd RESULT=failed PRIORITY=3 USER_UNIT=gnome-terminal-server.service SD_MESSAGE_LID_CLOSED b72ea4a2881545a0b50e200e55b9b070: no catalog entry src/login/logind-button.c:198 button_dispatch Lid closed. SYSLOG_FACILITY=4 SYSLOG_IDENTIFIER=systemd-logind PRIORITY=6 SD_MESSAGE_LID_OPENED b72ea4a2881545a0b50e200e55b9b06f: no catalog entry src/login/logind-button.c:219 button_dispatch Lid opened. SYSLOG_FACILITY=4 SYSLOG_IDENTIFIER=systemd-logind PRIORITY=6 SD_MESSAGE_SUSPEND_KEY b72ea4a2881545a0b50e200e55b9b072: no catalog entry src/login/logind-button.c:177 button_dispatch Suspend key pressed. SYSLOG_FACILITY=4 SYSLOG_IDENTIFIER=systemd-logind PRIORITY=6 SD_MESSAGE_CONFIG_ERROR c772d24e9a884cbeb9ea12625c306c01: no catalog entry src/shared/conf-parser.c:469 config_parse_sec [/etc/systemd/system/systemd-networkd.service.d/override.conf:2] Failed to parse sec value, ignoring: UNIT=systemd-networkd.service SYSLOG_FACILITY=3 ERRNO=22 SYSLOG_IDENTIFIER=systemd PRIORITY=3 CONFIG_LINE=2 CONFIG_FILE=/etc/systemd/system/systemd-networkd.service.d/override.conf unknown 10dd2dc188b54a5e98970f56499d1f73: no catalog entry gsm-manager.c:308 on_display_server_failure Unrecoverable failure in required component org.gnome.Shell.desktop PRIORITY=3 SYSLOG_IDENTIFIER=gnome-session-binary unknown 52fb62f99e2c49d89cfbf9d6de5e3555: no catalog entry src/journal/test-journal-send.c:85 main Hello World! PAGE_SIZE=4096 TERM=xterm-256color SYSLOG_IDENTIFIER=lt-test-journal-send PRIORITY=5 N_CPUS=2 HOME=/home/zbyszek unknown 9348174c5cc74001a71ef26bd79d302e: no catalog entry /usr/lib/python3.5/site-packages/dnf-plugins/system_upgrade.py:422 log_status Download finished. SYSLOG_IDENTIFIER=python3 DNF_VERSION=1.1.10 TARGET_RELEASEVER=25 SYSTEM_RELEASEVER=24 PRIORITY=5 unknown fef1cc509d5047268b83a3a553f54b43: no catalog entry /usr/lib/python3.5/site-packages/dnf-plugins/system_upgrade.py:422 log_status Rebooting to perform upgrade. SYSLOG_IDENTIFIER=python3 DNF_VERSION=1.1.10 TARGET_RELEASEVER=25 SYSTEM_RELEASEVER=24 PRIORITY=5 unknown 3e0a5636d16b4ca4bbe5321d06c6aa62: no catalog entry /usr/lib/python3.5/site-packages/dnf-plugins/system_upgrade.py:422 log_status Starting system upgrade. This will take a while. SYSLOG_IDENTIFIER=python3 DNF_VERSION=1.1.10 SYSTEM_RELEASEVER=24 PRIORITY=5 TARGET_RELEASEVER=25 unknown 0123456789abcdef0123456789abcdef: no catalog entry <doctest systemd.journal.JournalHandler[9]>:1 <module> Message with ID SYSLOG_IDENTIFIER=/usr/lib/python2.7/site-packages/py/test.py LOGGER=custom_logger_name PRIORITY=4 THREAD_NAME=MainThread
2016-12-11Merge pull request #4859 from keszybz/networkdLennart Poettering
Networkd man page update and fixes for the fallout
2016-12-11Merge pull request #4864 from keszybz/build-sysLennart Poettering
Fix some build issues and warnings
2016-12-11Merge pull request #4861 from keszybz/dissect-tweaksLennart Poettering
A prettification of the dissect code, mkosi and TODO updates
2016-12-11pid1,catalog: use a different MESSAGE_ID for user manager startupZbigniew Jędrzejewski-Szmek
This add a new message id for the end of user instance startup. User manager startup is a different beast then the system startup. Their descriptions are completely different too. Let's just separate them. Partially fixes #3351. Also remove "successful" from the description, since we don't know if the startup was successful or not.
2016-12-11basic/extract-word,man: clarify "correction" of invalid escapesZbigniew Jędrzejewski-Szmek
Our warning message was misleading, because we wouldn't "correct" anything, we'd just ignore unkown escapes. Update the message. Also, print just the extracted word (which contains the offending sequences) in the message, instead of the whole line. Fixes #4697.
2016-12-11pid1: remove unnecessary counterZbigniew Jędrzejewski-Szmek
The loop must terminate after at most three iterations anyway.
2016-12-11Added Debian config for mkosi (#4865)AsciiWolf
2016-12-10shared/firewall-util: remove warning about net/if.h workaroundZbigniew Jędrzejewski-Szmek
This is already fixed upstream, so warning is not useful. Let's keep the workaround until the fix has percolated downstream.
2016-12-10journal: fix warning about LZ4_compress_limitedOutputZbigniew Jędrzejewski-Szmek
2016-12-10dissect: assume GPT_ROOT_SECONDARY_VERITY is defined when GPT_ROOT_SECONDARY isZbigniew Jędrzejewski-Szmek
We define those macros, and there's no reason to have one without the other.
2016-12-10build-sys: define arm as secondary architecture for arm64Zbigniew Jędrzejewski-Szmek
Completely unstested. Fixes #4862.
2016-12-10Merge pull request #4844 from hadess/sensor-quirksLennart Poettering
udev: Add rules for accelerometer orientation quirks
2016-12-10hwdb_parser: make sure that our patterns match the full propertyZbigniew Jędrzejewski-Szmek
We would catch stuff like: ACCEL_MOUNT_MATRIX=0, -1, 0; -1, 0, 0; 0, 0.0., 0 but not ACCEL_MOUNT_MATRIX=0, -1, 0; -1, 0, 0; 0, 0, 0.0. because the match would stop at the next-to-last char. Fix that by requiring a line end.
2016-12-10hwdb_parser: add support for ACCEL_MOUNT_MATRIXZbigniew Jędrzejewski-Szmek
We test that we have exactly three rows of three reals separated by two semicolons.
2016-12-10udev: Add rules for accelerometer orientation quirksBastien Nocera
This commit adds a rules file to extract the properties from hwdb to set on i2c IIO devices. This is used to set the ACCEL_MOUNT_MATRIX property on IIO devices, to be consumed by iio-sensor-proxy or equivalent daemon. The hwdb file contains documentation on how to write quirks. Note however that mount information is usually exported in: - the device-tree for ARM devices - the ACPI DSDT for Intel-compatible devices but currently not extracted by the kernel. Also note that some devices have the framebuffer rotation that changes between the bootloader and the main system, which might mean that the accelerometer is then wrongly oriented. This is a missing feature in the i915 kernel driver: https://bugs.freedesktop.org/show_bug.cgi?id=94894 which needs to be fixed, and won't require quirks.
2016-12-10mkosi: we need diff to run ./configureZbigniew Jędrzejewski-Szmek
checking if gcc supports -fno-rtti -fno-exceptions... ./configure: line 10083: diff: command not found no
2016-12-10TODO: add dissect sectionZbigniew Jędrzejewski-Szmek
2016-12-10Merge pull request #4835 from poettering/unit-name-printfZbigniew Jędrzejewski-Szmek
Various specifier resolution fixes.
2016-12-10Merge pull request #4795 from poettering/dissectZbigniew Jędrzejewski-Szmek
Generalize image dissection logic of nspawn, and make it useful for other tools.
2016-12-10nspawn: add missing -E to getopt_long (#4860)Wim de With
2016-12-09man: make the examples in systemd.network(5) more usefulZbigniew Jędrzejewski-Szmek
We shouldn't just have snippets of configuration, but instead examples which show all the parts necessary to build a certain kind of setup, with short explanations.
2016-12-09networkd: check that VTI/VTI6 tunnels have a local addressZbigniew Jędrzejewski-Szmek
Otherwise we'd fail with an assertion: Assertion 't->family == AF_INET' failed at ../src/network/netdev/tunnel.c:244, function netdev_vti_fill_message_create(). Aborting.
2016-12-09networkd: tighten parsing of Tunnel addressesZbigniew Jędrzejewski-Szmek
When assigning addresses, we'd set the family, and later verify that the address on the other end has the same family. But when the address was specified as "any", we'd simply unset the family. Instead, only unset the family if both addresses are wiped. Also, don't bother setting family = AF_UNSPEC, since it's the default (0).
2016-12-09networkd: use log_netdev_error in a two more placesZbigniew Jędrzejewski-Szmek
2016-12-09networkd: do not print ": Success" in debug messageZbigniew Jędrzejewski-Szmek
%m isn't useful in success path.
2016-12-09pid1: simplify the logic in two statements related to killing processesZbigniew Jędrzejewski-Szmek
Generally non-inverted conditions are nicer, and ternary operators with complex conditions are a bit hard to read. No functional change.
2016-12-09tree-wide: replace all readdir cycles with FOREACH_DIRENT{,_ALL} (#4853)Reverend Homer
2016-12-08Merge pull request #4686 from poettering/machine-id-app-specificZbigniew Jędrzejewski-Szmek
Add new "khash" API and add new sd_id128_get_machine_app_specific() function
2016-12-07network: fix const qualifier (#4849)David Michael
Follow up for #4809.
2016-12-07nspawn: resolv.conf might not be created initially (#4799)Franck Bui
This might happen that resolv.conf is missing in a minimal rootfs and in this case the following warning is emitted: Failed to mount n/a on /mnt/etc/resolv.conf (MS_BIND ""): No such file or directory This patch fixes this case.
2016-12-07Merge pull request #4843 from joukewitteveen/protocolLennart Poettering
Go through stop_post on failure (#4770)
2016-12-07dissect: add DISSECT_IMAGE_DISCARD_ANY maskZbigniew Jędrzejewski-Szmek
This makes the code to set arg_flags much more readable.
2016-12-07network: support negation in matching patterns (#4809)David Michael
2016-12-07core: add a note clarifying that we should be careful when adding new specifiersLennart Poettering
2016-12-07core: deprecate %c, %r, %R specifiersLennart Poettering
%c and %r rely on settings made in the unit files themselves and hence resolve to different values depending on whether they are used before or after Slice=. Let's simply deprecate them and drop them from the documentation, as that's not really possible to fix. Moreover they are actually redundant, as the same information may always be queried from /proc/self/cgroup and /proc/1/cgroup. (Accurately speaking, %R is actually not broken like this as it is constant. However, let's remove all cgroup-related specifiers at once, as it is also redundant, and doesn't really make much sense alone.)
2016-12-07update TODOLennart Poettering
2016-12-07tests: let's make function tables static/constLennart Poettering
2016-12-07core: add specifier expansion to ReadOnlyPaths= and friendsLennart Poettering
Expanding specifiers here definitely makes sense. Also simplifies the loop a bit, as there's no reason to keep "prev" around...
2016-12-07core: add specifier expansion to RequiresMountsFor=Lennart Poettering
This might be useful for some people, for example to pull in mounts for paths including the machine ID or hostname.
2016-12-07core: turn on specifier expansion for more unit file settingsLennart Poettering
Let's permit specifier expansion at a numbre of additional fields, where arbitrary strings might be passed where this might be useful one day. (Or at least where there's no clear reason where it wouldn't make sense to have.)
2016-12-07core: use unit_full_printf() at a couple of locations we used ↵Lennart Poettering
unit_name_printf() before For settings that are not taking unit names there's no reason to use unit_name_printf(). Use unit_full_printf() instead, as the names are validated anyway in one form or another after expansion.
2016-12-07core: resolve more specifiers in unit_name_printf()Lennart Poettering
unit_name_printf() is usually what we use when the resulting string shall qualify as unit name, and it hence avoids resolving specifiers that almost certainly won't result in valid unit names. Add a couple of more specifiers that unit_full_printf() resolves also to the list unit_name_printf() resolves, as they are likely to be useful in valid unit names too. (Note that there might be cases where this doesn't hold, but we should still permit this, as more often than not they are safe, and if people want to use them that way, they should be able to.)
2016-12-07man: drop reference to %U being uselessLennart Poettering
This paragraph was a missed left-over from 79413b673b45adc98dfeaec882bbdda2343cb2f9. Drop it now.
2016-12-07core: move specifier expansion out of service.c/socket.cLennart Poettering
This monopolizes unit file specifier expansion in load-fragment.c, and removes it from socket.c + service.c. This way expansion becomes an operation done exclusively at time of loading unit files. Previously specifiers were resolved for all settings during loading of unit files with the exception of ExecStart= and friends which were resolved in socket.c and service.c. With this change the latter is also moved to the loading of unit files. Fixes: #3061
2016-12-07man: update the nspawn man page, and document what kind of dissection ↵Lennart Poettering
features we now support
generated by cgit v1.2.3-54-g00ecf (git 2.45.2) at 2025-01-06 07:19:48 +0000