summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2013-12-30sleep-config: Dereference pointer before check for NULLStefan Beller
This fixes a bug pointed out by http://css.csail.mit.edu/stack/ (Optimization-unstable code) It is a similar fix as f146f5e159 (2013-12-30, core: Forgot to dereference pointer when checking for NULL) To explain this bug consider the following similar, but simpler code: if (!p) free(*p) Assume the if condition evaluates to true, then we will access *p, which means the compiler can assume p is a valid pointer, so it could dereference p and use the value *p. Assuming p as a valid pointer, !p will be false. But initally we assumed the condition evaluates to true. By this reasoning the optimizing compiler can deduce, we have dead code. ("The if will never be taken, as *p must be valid, because otherwise accessing *p inside the if would segfault") This led to an error message of the static code checker, so I checked the code in question. As we access *modes and *states before the check in the changed line of this patch, I assume the line to be wrong and we actually wanted to check for *modes and *states being both non null.
2013-12-30bootchart: Remove unneeded check for NULLStefan Beller
Directly before the changed line there is: while ((parent->next_ps && parent->pid != ps->ppid)) parent = parent->next_ps; which looks one element ahead of the list, hence we can rely on parent being non null here. If 'parent' were NULL at that while loop already, it would crash as we're dereferencing 'parent' when checking for next_ps already. Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
2013-12-30tmpfiles: rename --unsafe to --bootZbigniew Jędrzejewski-Szmek
As suggested by Kay, it is better to describe what is done, not what might happen.
2013-12-30build-sys: fix systemd-stdio-bridge link to work with split /usrZbigniew Jędrzejewski-Szmek
shumski> there seems to be slight error in systemd git master Makefile.am
2013-12-30core: Forgot to dereference pointer when checking for NULLStefan Beller
Actually we already checked for !rt before, now we'd like to examine the return value of the memory allocation.
2013-12-30man: expand on some more subtle points in systemd.socket(5)Zbigniew Jędrzejewski-Szmek
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=727708#1694
2013-12-30systemd-python: fix listen_fds under Python 2Zbigniew Jędrzejewski-Szmek
2013-12-30systemd-python: fix setting of exception codesZbigniew Jędrzejewski-Szmek
The return value of 0 would be treated as failure by mistake, resulting in " SystemError: error return without exception set". The way that set_error() is used is changed to be the same everywhere.
2013-12-30acticate: rename --environment to --setenvZbigniew Jędrzejewski-Szmek
Nspawn has --setenv, and systemd itself accepts systemd.setenv. It is nice to have the same parameter name everywhere. Old name is accepted, but not advertised.
2013-12-29udev: LOG_PRIORITY -> LOG_LEVELKay Sievers
2013-12-28autogen: add shortcut for running scan-buildThomas Hindoe Paaboel Andersen
scan-build is a static analyzer in llvm. As ususal static analyzers tend to mostly find theoretical bugs in software that has been in production for a while. For in-development code it can be useful to check if new issues is added as there is a chance to spot real problems before release. For systemd we are now down to 297 issues - the vast majority are false positives because the tool does not understand the cleanup attribute. Running clang's static analyzer scan-build is a bit messy. You have to run both configure and make "inside" the build-scan tool. To have an easy shortcut from autogen.sh I thus call both directly from it. This makes it different from the other options in autogen.sh. I chose 's' for static analysis. scan-build is in the package clang-analyzer on fedora.
2013-12-28autogen: add shortcut for building with clangThomas Hindoe Paaboel Andersen
For a while I have been cleaning up warnings when building with clang. There are currently only two sources of warnings left: Wcast-align and Wgnu. I am not convinced that fixing up those up is feasible so I run with them disabled to spot regressions. E.g. clang is a bit more strict wrt to unused variables with the cleanup attribute and I have fixed a number of those since. Like the other options in autogen.sh I have a shortcut for clang as well. I use 'l' for llvm.
2013-12-28gitignore: add back user@.serviceMarc-Antoine Perennou
2013-12-28bus: fix a couple of format string mistakesLennart Poettering
2013-12-28bus: driverd; add missing format string parameterMarc-Antoine Perennou
This was causing a nasty coredump
2013-12-28bus: correct a number of gcc format string attribute usagesLennart Poettering
2013-12-27man: include autoconf snippet in daemon(7)Michał Górny
https://bugs.freedesktop.org/show_bug.cgi?id=40446
2013-12-27selinux: Check access vector for enable/disable perm for each unit fileLubomir Rintel
SELinux check will be done using the context of the unit file as as a target instead of the default init_t context, allowing selinux control on the level of individual units. https://bugzilla.redhat.com/show_bug.cgi?id=1022762
2013-12-28shared: add simplistic XML parser for usage in the D-Bus policy language ↵Lennart Poettering
compat parser
2013-12-27bus: fix running tests in parallelZbigniew Jędrzejewski-Szmek
2013-12-27man: add a note about propagating signalsZbigniew Jędrzejewski-Szmek
2013-12-27hwdb: Update database of Bluetooth company identifiersMarcel Holtmann
2013-12-27build-sys: fix generation of user@.serviceZbigniew Jędrzejewski-Szmek
2013-12-27units: user@.service: fix user bus pathMantas Mikulėnas
2013-12-27bus: PORTING-DBUS1: fix user bus pathMantas Mikulėnas
2013-12-27systemctl: remove unused variableThomas Hindoe Paaboel Andersen
2013-12-27bus: PORTING-DBUS1 typo fixesThomas Hindoe Paaboel Andersen
2013-12-27man: fix Type= reference v2Zbigniew Jędrzejewski-Szmek
grawity: It looks like the old version _was_ correct – the default value will be "Type=dbus" if the service has a BusName set. Suggested change: "if neither Type= nor BusName= is specified"
2013-12-27bus: PORTING-DBUS1 clarify pool size valueKay Sievers
2013-12-27bus: PORTING-DBUS1 updateKay Sievers
2013-12-27bus: update PORTING-DBUS1Kay Sievers
2013-12-27bus: actually, the kernel does enforce validity of bus names...Lennart Poettering
2013-12-27bus: explain obsoletion of dbus1 .service filesLennart Poettering
2013-12-27bus: refuse invalid names from kbus meta dataLennart Poettering
2013-12-27bus: add some preliminary docs for porting existing dbus1 client libraries ↵Lennart Poettering
to kdbus
2013-12-26bus: update kdbus.hKay Sievers
2013-12-26man: fix Type= referenceMarcos Felipe Rasia de Mello
Simple man page fix attached. -- Marcos From 268d10a2f8769fd1dcb9440670af15ac02c5df89 Mon Sep 17 00:00:00 2001 From: Marcos Mello <marcosfrm@gmail.com> Date: Thu, 26 Dec 2013 17:19:04 -0200 Subject: [PATCH 1/1] man: fix Type= reference
2013-12-26Use enums to make it obvious what boolean params meanZbigniew Jędrzejewski-Szmek
Suggested-by: Russ Allbery <rra@debian.org>
2013-12-26systemctl: allow globbing in commands which take multiple unit namesZbigniew Jędrzejewski-Szmek
2013-12-26systemctl: drop uninteresting units immediatelyZbigniew Jędrzejewski-Szmek
Also properly free memory if list-unit-files --root=... is used.
2013-12-26systemctl: simplify start_unitZbigniew Jędrzejewski-Szmek
2013-12-26man: fix description of is-enabled returned valueZbigniew Jędrzejewski-Szmek
2013-12-26bus: add a temporary hard-coded policy to proxyd to make gdm workLennart Poettering
gdm relies on the policy to deny its own requests to not deadlock. Given that we currently do not enforce any policy in the dbus1 compat proxy service this means that gdm will necessarily deadlock on our systems. To work around this, enforce a fixed policy teomporarily, until we interpret the legacy XML policy in full. Booh, gdm, booh, for requring this and making me waste two days on tracking this brokenness down.
2013-12-26bus: always show messages we sendLennart Poettering
2013-12-25man: document fail/nofail, auto/noautoZbigniew Jędrzejewski-Szmek
Also s/filesystem/file system/ in a few places.
2013-12-25Trim TODOZbigniew Jędrzejewski-Szmek
2013-12-25man: grammar and wording improvementsJan Engelhardt
This is a recurring submission and includes corrections to: - missing words, preposition choice. - change of /lib to /usr/lib, because that is what most distros are using as the system-wide location for systemd/udev files.
2013-12-25man: improvements to comma placementJan Engelhardt
This is a recurring submission and includes corrections to: comma placement.
2013-12-25man: resolve word omissionsJan Engelhardt
This is a recurring submission and includes corrections to: word omissions and word class choice.
2013-12-26bus: don't process Peer interface messages in the proxyLennart Poettering