summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-02-29test-clock: fix FILE* leakMartin Pitt
Close the FILE* instead of the underlying fd.
2016-02-29Merge pull request #2752 from eliasp/no-container-name-escapingZbigniew Jędrzejewski-Szmek
Don't escape the name of the container nspawn service
2016-02-29Merge pull request #2763 from tblume/shorten-hostname-before-removing-dotsLennart Poettering
shorten hostname before checking for trailing dot
2016-02-29Merge pull request #2756 from thom311/masterLennart Poettering
core: avoid compiler warning when compiling with -fexceptions
2016-02-29test-clock: fix assertionsMartin Pitt
Use assert_se() to ensure that they don't get optimized away.
2016-02-29timedated: trivial stylistic fixMartin Pitt
Don't use {} for single-line "then" blocks.
2016-02-29Merge pull request #2766 from keszybz/coverityMartin Pitt
test-clock: fix fd "leak"
2016-02-29systemctl: Fix warn: action_to_runlevel() is not usedBenjamin ROBIN
If HAVE_SYSV_COMPAT is not defined: ‘action_to_runlevel’ defined but not used
2016-02-29systemctl: Replace check_one_unit() by get_state_one_unit()Benjamin ROBIN
The get_state_one_unit returns the enum of the active state of the unit Do not rely on the string value of the active state. Fix #2718 since the refactoring allow to handle more case
2016-02-29test-clock: fix fd "leak"Zbigniew Jędrzejewski-Szmek
CID #1352301.
2016-02-29core: use DUAL_TIMESTAMP_NULL to reset kernel_timestampAlexander Kuleshov
instead of direct reset of kernel_timestamp fields.
2016-02-29Merge pull request #2764 from benjarobin/fix-stdio-bridgeRonny Chevalier
stdio-bridge: Correctly propagate error
2016-02-29stdio-bridge: Correctly propagate errorBenjamin Robin
Return EXIT_FAILURE and print the correct errno code if sd_bus_get_fd() or sd_bus_get_events() fail
2016-02-29shorten hostname before checking for trailing dotThomas Blume
Shortening can lead to a hostname that has a trailing dot. Therefore it should be done before checking from trailing dots.
2016-02-28Merge pull request #2746 from daurnimator/patch-1Zbigniew Jędrzejewski-Szmek
ISSUE_TEMPLATE: Use a list for submission type so that it appears as a checkbox
2016-02-28Merge pull request #2753 from phomes/trivial-fixes2Zbigniew Jędrzejewski-Szmek
Trivial fixes
2016-02-28Merge pull request #2749 from martinpitt/adjtimeZbigniew Jędrzejewski-Szmek
2016-02-27core: avoid compiler warning when compiling with -fexceptionsThomas Haller
Initialize auto variables with cleanup attribute, otherwise we get a compiler warning with -fexceptions. ./configure CFLAGS='-Wmaybe-uninitialized -fexceptions -O2'
2016-02-26stdio-bridge: remove dead codeThomas Hindoe Paaboel Andersen
2016-02-26tree-wide: indentation fixesThomas Hindoe Paaboel Andersen
2016-02-26Don't escape the name of the container in instances ofElias Probst
When using `%I` for instances of `systemd-nspawn@.service`, the result will be `systemd-nspawn` trying to launch a container named e.g. `fedora/23` instead of `fedora-23`. Using `%i` instead prevents escaping `-` in a container name and uses the unmodified container name from the machine store.
2016-02-26timedated: be more tolerant in parsing /etc/adjtimeMartin Pitt
Similarly to the previous commit, make context_write_data_local_rtc() understand /etc/adjtime files with just one or two lines, with or without a final newline. Normalize the file to the current definition in hwclock(8), in the spirit of "be liberal what you accept and strict what you produce": Add line terminators, and set the second line to "0" if missing. Fixes: #2638
2016-02-26clock-util: be more tolerant in parsing /etc/adjtimeMartin Pitt
As we default to "hardware clock is in UTC" if /etc/adjtime is not present, it also makes sense to have that default if /etc/adjtime contains only one or two lines. Drop the "gibberish" test case, as this was just EIO because of not containing three lines, which is already contained in other tests. clock_is_localtime() never actually validated the format of the first two lines, and there is little point in doing that. This addresses the reading half of issue #2638.
2016-02-26clock-util: make clock_is_localtime() testable and add initial testsMartin Pitt
Add path argument to clock_is_localtime() and default to "/etc/adjtime" if it's NULL. This makes the function testable. Add test-clock: initial test cases for some scenarios, using a temporary file. This also checks the behaviour with a NULL (i. e. the system's /etc/adjtime) file.
2016-02-26.github/ISSUE_TEMPLATE: Use a list for submission type so that it appears as ↵daurnimator
a checkbox
2016-02-25Merge pull request #2671 from 0xAX/move-pager-open-to-one-placeZbigniew Jędrzejewski-Szmek
tree-wide: merge pager_open_if_enabled() to the pager_open()
2016-02-26tree-wide: merge pager_open_if_enabled() to the pager_open()Alexander Kuleshov
Many subsystems define own pager_open_if_enabled() function which checks '--no-pager' command line argument and open pager depends on its value. All implementations of pager_open_if_enabled() are the same. Let's merger this function with pager_open() from the shared/pager.c and remove pager_open_if_enabled() from all subsytems to prevent code duplication.
2016-02-25Merge pull request #2743 from pfl/dhcp4_serverLennart Poettering
sd-dhcp-server: Send replies to BOOTP relay server port
2016-02-25sd-dhcp-server: Send replies to BOOTP relay server portPatrik Flykt
RFC 2131 Section 4.1 says that "If the ’giaddr’ field in a DHCP message from a client is non-zero, the server sends any return messages to the ’DHCP server’ port on the BOOTP relay agent whose address appears in ’giaddr’." Fix this by adding a destination port when sending unicast UDP packets and provide the server port when a BOOTP relay agent is being used.
2016-02-24Merge pull request #2722 from torstehu/fix-typo2Daniel Mack
treewide: fix typos and then/that use
2016-02-24treewide: fix typos and then/that useTorstein Husebø
2016-02-24Merge pull request #2719 from evverx/add-test-to-makefileMartin Pitt
tests: various fixes
2016-02-24Merge pull request #2726 from ssiloti/masterZbigniew Jędrzejewski-Szmek
dnssec: only run tests that require gcrypt if we have it
2016-02-24Merge pull request #2727 from ian-kelling/man-pr-v3Zbigniew Jędrzejewski-Szmek
man: clarify unit ordering language
2016-02-23man: clarify unit ordering languageIan Kelling
2016-02-23dnssec: only run tests that require gcrypt if we have itSteven Siloti
2016-02-23Merge pull request #2724 from vcaputo/minor-formatting-cleanupsZbigniew Jędrzejewski-Szmek
tree-wide: minor formatting inconsistency cleanups
2016-02-23tree-wide: minor formatting inconsistency cleanupsVito Caputo
2016-02-23Merge pull request #2639 from nafets227/masterZbigniew Jędrzejewski-Szmek
Bugfix set virt=none when running on XEN Dom0
2016-02-23basic: Bugfix Detect XEN Dom0 as no virtualizationStefan Schallenberg aka nafets227
When running in XEN Dom0 the virtualization check: 1) detect_xen returns HYPERVISOR_NONE so next checks are executed 2) /proc/sys/hypervisor detects a XEN hypervisor it is lacking the special Dom0 detection as in detect_xen With this patch, at the end of all virtualization checks we double-check if running in XEN Dom0 or DomU.
2016-02-23basic: Debug-logging of Virtualisation detectionStefan Schallenberg aka nafets227
print out every single detection executed and its result.
2016-02-23Merge pull request #2725 from phomes/misc-cleanupZbigniew Jędrzejewski-Szmek
Misc cleanup
2016-02-23networkctl: fix constThomas Hindoe Paaboel Andersen
2016-02-23tree-wide: remove unused variablesThomas Hindoe Paaboel Andersen
2016-02-23basic: mark unused variable as suchThomas Hindoe Paaboel Andersen
2016-02-23Merge pull request #2664 from zonque/bootchart-removalLennart Poettering
Remove systemd-bootchart
2016-02-23Merge pull request #2723 from poettering/importd-manZbigniew Jędrzejewski-Szmek
2016-02-23man: style fixesZbigniew Jędrzejewski-Szmek
2016-02-23man: change recommended order of NSS modules in /etc/nsswitch.confLennart Poettering
So far we recommended placing "nss-mymachines" after "nss-resolve" in the order of preference in /etc/nsswitch.conf. This change reverse this order. Rationale: single-label names are resolved via LLMNR by resolved, which has to time out if no peer by that name exists. By placing "nss-mymachines" first (which always responds immediately) we avoid running into this timeout for most containers. Both modules should return the same data if LLMNR is used by the container anyway. While we are at it, improve the man pages of the three NSS modules in other ways a bit.
2016-02-23tests: add exec-capabilityambientset* to Makefile.amEvgeny Vereshchagin
This is a follow-up to 70d7aea5c