summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-07-22basic: better readable IN_SET macroMichal Schmidt
Putting the set elements in an array variable and using ELEMENTSOF makes it clearer what's going on. Incidentally, it also makes gcc -O2 generate slightly smaller code: "size systemd", before: text data bss dec hex filename 1378318 128608 2632 1509558 1708b6 systemd After: text data bss dec hex filename 1377286 128608 2632 1508526 1704ae systemd
2015-07-22Merge pull request #654 from ssahani/nlLennart Poettering
network: Add tunnel params
2015-07-22Merge pull request #647 from michich/job-loggingTom Gundersen
Job logging fixes and improvements
2015-07-22Merge pull request #651 from keszybz/ata_id-wwn-orderingMichal Schmidt
ata_id: unreverse WWN identifier
2015-07-22sd-netlink: add tunnel paramsSusant Sahani
2015-07-22Tunnel NL params: Add to missing.hSusant Sahani
2015-07-22Merge pull request #652 from whot/hwdb-updatesDaniel Mack
hwdb: add Logitech MX Master DPI settings
2015-07-22ata_id: unreverse WWN identifierZbigniew Jędrzejewski-Szmek
An endianness conversion was lost in 6024a6e302bad6bcf073fa84a41a6123305dc845. Restore it. Now ata_id and scsi_id output match. https://bugzilla.redhat.com/show_bug.cgi?id=1227503
2015-07-22hwdb: add Logitech MX Master DPI settingsPeter Hutterer
2015-07-21Merge pull request #648 from michich/udev-log-priorityTom Gundersen
udev.log-priority crash fix and cleanup
2015-07-21udev: unify reporting of invalid cmdline keysMichal Schmidt
This way it does not need distinct string literals and it also preserves the "rd." prefix.
2015-07-21udev: fix crash with invalid udev.log-priorityMichal Schmidt
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1245293
2015-07-21core: adjust job completion message log levelsMichal Schmidt
We do not print all non-OK job completion status messages to the console in red, because not all of them are plain errors. We do however log the same messages as LOG_ERR. Differentiate the log levels by deducing them from the job result in a way that more or less matches the color of the console message.
2015-07-21core: small refactor of job completion loggingMichal Schmidt
Joins three log_struct() calls into one.
2015-07-21core: log completion of remaining job typesMichal Schmidt
JOB_RESTART and failed JOB_VERIFY_ACTIVE completions were printed to console but not to the log.
2015-07-21core: do not log done failed-condition jobs as if unit startedMichal Schmidt
It is misleading to see "Started foo." in the log when the unit's condition was false.
2015-07-21core: remove generic job completion messages from unit vtablesMichal Schmidt
These units' message format strings are identical to the generic strings. Since we can always rely on the fallback, these are now redundant.
2015-07-21core: try harder to get job completion messages tooMichal Schmidt
This is similar to "core: always try harder to get unit status message format string", but for job completion status messages. It makes generic status messages applicable for printing to the console. And it rewrites the functions in a more table-based style.
2015-07-21core: unit_get_status_message_format() never returns NULLMichal Schmidt
unit_get_status_message_format() is used only with one of JOB_START, JOB_STOP, JOB_RELOAD, all of which have fallback message strings defined, so the function may never return NULL.
2015-07-21bootchart: fix negative 'timeleft' conditionDaniel Mack
Fix the overrun case in sample acquistion and negative number calculations. Reported by Stefan Sauer. Fixes #642
2015-07-21Merge pull request #643 from zonque/fileioDaniel Mack
basic/fileio: fix write_string_file() fallout
2015-07-21user-sessions: fix write_string_file() falloutDaniel Mack
WRITE_STRING_FILE_ATOMIC is only valid if WRITE_STRING_FILE_CREATE is also given. IOW, an atomic file write operation is only possible when creating a file is also being asked for. This is a regression from the recent write_string_file() rework.
2015-07-21logind: fix write_string_file() falloutDaniel Mack
WRITE_STRING_FILE_ATOMIC is only valid if WRITE_STRING_FILE_CREATE is also given. IOW, an atomic file write operation is only possible when creating a file is also being asked for. This is a regression from the recent write_string_file() rework.
2015-07-21core: always try harder to get unit status message format stringMichal Schmidt
The starting/stopping messages are printed to the console only if the corresponding format string is defined in the unit's vtable. To avoid excessive messages on the console, the unit types whose start/stop jobs are instantaneous had the format strings intentionally undefined. When logging the same event to the journal, a fallback to generic Starting/Stopping/Reloading messages is used. The problem of excessive console messages with instantaneous jobs is already resolved in a nicer way ("core: fix confusing logging of instantaneous jobs"), so there's no longer a need to have two ways of getting the format strings. Let's fold them into one function with the fallback to generic message strings.
2015-07-21core: correct return value from reload methodsMichal Schmidt
Return 1 from *_reload() methods to signify "we did something", just like in *_start(). This causes "Reloading foo..." messages to be logged. "Reloaded foo." messages are already logged.
2015-07-21core: fix confusing logging of instantaneous jobsMichal Schmidt
For instantaneous jobs (e.g. starting of targets, sockets, slices, or Type=simple services) the log shows the job completion before starting: systemd[1]: Created slice -.slice. systemd[1]: Starting -.slice. systemd[1]: Created slice System Slice. systemd[1]: Starting System Slice. systemd[1]: Listening on Journal Audit Socket. systemd[1]: Starting Journal Audit Socket. systemd[1]: Reached target Timers. systemd[1]: Starting Timers. ... The reason is that the job completes before the ->start() method returns and only then does unit_start() print the "Starting ..." message. The same thing happens when stopping units. Rather than fixing the order of the messages, let's just not emit the Starting/Stopping message at all when the job completes instantaneously. The job completion message is sufficient in this case.
2015-07-21Merge pull request #636 from ssahani/tunnelTom Gundersen
networkd: ip6 tunnel add support for flowlabel
2015-07-21man: add man ipv6 flowlabel support for ip6 tunnelsSusant Sahani
2015-07-21networkd: ip6 tunnel add support for flowlabelSusant Sahani
Add Pv6 Flow Label support. The 20-bit Flow Label field in the IPv6 header[RFC2460] is used by a node to label packets of a flow.
2015-07-20Merge pull request #625 from ssahani/tun2Tom Gundersen
sd-netlink: add tunnel parameters
2015-07-20Merge pull request #630 from namhyung/use-isemptyTom Gundersen
sd-bus: use isempty() consistently
2015-07-20Merge pull request #549 from ssahani/dhcpTom Gundersen
networkd: allow hostname override
2015-07-20sd-bus: use isempty() consistentlyNamhyung Kim
Instead of open-coding, use isempty() to check NULL or empty string for consistency.
2015-07-20Merge pull request #626 from ↵Daniel Mack
systemd-mailing-devs/1437135133-9646-2-git-send-email-vivenzio.pagliari@nokia.com man: Typo fix in systemd.preset manpage
2015-07-20add NL parameters to missing.hSusant Sahani
2015-07-20sd-netlink: add tunnel NL parametersSusant Sahani
2015-07-19Merge pull request #614 from teg/bitmap-overflowDaniel Mack
basic: bitmap - complete fix for bitshift overflow
2015-07-17basic: bitmap - complete fix for bitshift overflowTom Gundersen
The bug found by David existed in several places, fix them all. Also extend the tests to cover these cases.
2015-07-17Typo fix in systemd.preset manpageVivenzio Pagliari
2015-07-17Merge pull request #611 from dvdhrm/bitmap-fixesTom Gundersen
Bitmap fixes
2015-07-17Merge pull request #607 from ssahani/vxlan1David Herrmann
networkd: move config parsers to specific header files
2015-07-17Merge pull request #610 from utezduyar/include-signal-headerDavid Herrmann
cgtop: include missing signal.h for sigwinch
2015-07-17bitmap: avoid 32bit integer overflow in shiftDavid Herrmann
We really must use 64bit integers to calculate long-long shifts. Otherwise, we will never get higher masks than 2^31.
2015-07-17bitmap: allow bitmap_iterate() on NULL bitmapDavid Herrmann
Make sure we properly treat NULL bitmaps as empty. Right now, we don't (which really looks like a typo).
2015-07-17cgtop: include missing signal.h for sigwinchUmut Tezduyar Lindskog
2015-07-16logind: never select closing sessions for a VTDavid Herrmann
If a session is in closing state (and already got rid of its VT), then never re-select it for that VT. There is no reason why we should grant something to a session that is already going away *AND* already got rid of exactly that.
2015-07-16build: add ./test-bitmap to .gitignoreDavid Herrmann
Make sure to ignore build files of Tom's recent test-bitmap addition.
2015-07-16logind: prefer new sessions over older ones on VT switchesDavid Herrmann
Our seat->positions[] array keeps track of the 'preferred' session on a VT. The only situation this is used, is to select the session to activate when a VT is activated. In the normal case, there's only one session per VT so the selection is trivial. Older greeters, however, implement take-overs when they start sessions on the same VT that the greeter ran on. We recently limited such take-overs to VTs where a greeter is running on, to force people to never share VTs in new code that is written. For legacy reasons, we need to be compatible to old greeters, though. Hence, we allow those greeters to implement take-over. In such take-overs, however, we should really make sure that the new sessions gets preferred over the old one under all circumstances. Hence, make sure we override the previous preferred session with a new session.
2015-07-16Merge pull request #605 from dvdhrm/test-bus-proxyTom Gundersen
sd-bus: add new test for NameAcquired via proxy/dbus-daemon
2015-07-16networkd: move config_parse_tunnel_addressSusant Sahani
move config_parse_tunnel_address from networkd.h to tunnel specific file networkd-netdev-tunnel.h