summaryrefslogtreecommitdiff
path: root/CODING_STYLE
AgeCommit message (Collapse)Author
2015-05-15CODING_STYLE: document that EXIT_FAILURE and EXIT_SUCCESS should be usedLennart Poettering
2015-05-15CODING_STYLE: document best practices when initializing structsLennart Poettering
2015-05-15CODING_STYLE: document alloca() DONTSLennart Poettering
2015-04-22CODING_STYLE: document that we prefer /* comments */ over // commentsLennart Poettering
2015-04-21CODING_STYLE: document how destructors should workLennart Poettering
2015-04-03CODING_STYLE: mention that dup() should not be usedLennart Poettering
2015-04-02CODING_STYLE: clarify that exit() is never OK to callLennart Poettering
2015-03-10CODING_STYLE: mention casting of function invocations to (void)Lennart Poettering
2015-02-28update TODOLennart Poettering
2015-02-11tree-wide: whenever we include libgen.h, immediately undefine basename()Lennart Poettering
Also, document in adjacent comments and in CODING_STYLE why we do that.
2015-02-10CODING_STYLE: elaborate on O_CLOEXEC a bitLennart Poettering
2015-02-03Reindent man pages to 2chZbigniew Jędrzejewski-Szmek
2014-10-30CODING_STYLE: clarify that we really should use O_CLOEXEC everywhereLennart Poettering
2014-10-27CODING_STYLE: don't clobber arguments on failureLennart Poettering
2014-10-22CODING_STYLE: clarify that single-line if blocks should not be enclosed in {}Lennart Poettering
2014-08-30Fix a few more typosRuben Kerkhof
2014-08-21CODING_STYLE: document that we don't break lines at 80chLennart Poettering
2014-08-03Unify parse_argv styleZbigniew Jędrzejewski-Szmek
getopt is usually good at printing out a nice error message when commandline options are invalid. It distinguishes between an unknown option and a known option with a missing arg. It is better to let it do its job and not use opterr=0 unless we actually want to suppress messages. So remove opterr=0 in the few places where it wasn't really useful. When an error in options is encountered, we should not print a lengthy help() and overwhelm the user, when we know precisely what is wrong with the commandline. In addition, since help() prints to stdout, it should not be used except when requested with -h or --help. Also, simplify things here and there.
2014-06-28doc: use expanded forms for written styleJan Engelhardt
2014-06-28doc: typographical improvements and choice of wordsJan Engelhardt
2014-06-28doc: grammatical correctionsJan Engelhardt
2014-05-24Fix several small typosJonathan Boulle
2013-12-09extend CODING_STYLE document a bitLennart Poettering
2013-12-03trivial coding style clean upsThomas Hindoe Paaboel Andersen
- Add space between if/for and the opening parentheses - Place the opening brace on same line as the function (not for udev) From the CODING_STYLE Try to use this: void foo() { } instead of this: void foo() { }
2013-03-08analyze: various cleanupsLennart Poettering
Update systemd-analyze to follow the coding style of the other tools more closely. Also, update the CODING_STYLE to document this for future additions. Changes: - Always use usec_t for time units, so that we always use the same types everywhere, and format times the same way as everywhere else. - Add "static" to global variables - Make sure we can always distuingish OOM and other errors: ensure we always return useful error codes from all functions. - Always free unit_times array
2013-01-29Clarify sentenceTollef Fog Heen
2012-10-01Minor typoTollef Fog Heen
2012-10-01Be consistent about "." vs no "." at the end of lines"Tollef Fog Heen
2011-02-28Spelling CorrectionsHarald Hoyer
Just some lame spelling corrections with no functionality.
2010-02-14CODING_STYLE: minor updatesLennart Poettering
2009-11-18CODING_STYLE: add missing -Lennart Poettering
2009-11-18initial commitLennart Poettering