Age | Commit message (Collapse) | Author | |
---|---|---|---|
2015-07-31 | CODING_STYLE: say that "for (;;)" is better than "while (1)" | Lennart Poettering | |
2015-06-17 | Stop talking about the "XDG" version of basename() | Simon McVittie | |
XDG refers to X Desktop Group, a former name for freedesktop.org. This group is responsible for specifications like basedirs, .desktop files and icon naming, but as far as I know, it has never tried to redefine basename(). I think these references were meant to say XPG (X/Open Portability Guide), a precursor of POSIX. POSIX is better-known and less easily confused with XDG, and is how the basename(3) man page describes the libgen.h version of basename(). The other version of basename() is glibc-specific and is described in basename(3) as "the GNU version"; specifically mention that version, to disambiguate. | |||
2015-05-29 | CODING_STYLE: document order in which to #include headers | Lennart Poettering | |
2015-05-18 | CODING_STYLE: document that we should avoid kernel types like u32 | Lennart Poettering | |
2015-05-15 | CODING_STYLE: document that EXIT_FAILURE and EXIT_SUCCESS should be used | Lennart Poettering | |
2015-05-15 | CODING_STYLE: document best practices when initializing structs | Lennart Poettering | |
2015-05-15 | CODING_STYLE: document alloca() DONTS | Lennart Poettering | |
2015-04-22 | CODING_STYLE: document that we prefer /* comments */ over // comments | Lennart Poettering | |
2015-04-21 | CODING_STYLE: document how destructors should work | Lennart Poettering | |
2015-04-03 | CODING_STYLE: mention that dup() should not be used | Lennart Poettering | |
2015-04-02 | CODING_STYLE: clarify that exit() is never OK to call | Lennart Poettering | |
2015-03-10 | CODING_STYLE: mention casting of function invocations to (void) | Lennart Poettering | |
2015-02-28 | update TODO | Lennart Poettering | |
2015-02-11 | tree-wide: whenever we include libgen.h, immediately undefine basename() | Lennart Poettering | |
Also, document in adjacent comments and in CODING_STYLE why we do that. | |||
2015-02-10 | CODING_STYLE: elaborate on O_CLOEXEC a bit | Lennart Poettering | |
2015-02-03 | Reindent man pages to 2ch | Zbigniew Jędrzejewski-Szmek | |
2014-10-30 | CODING_STYLE: clarify that we really should use O_CLOEXEC everywhere | Lennart Poettering | |
2014-10-27 | CODING_STYLE: don't clobber arguments on failure | Lennart Poettering | |
2014-10-22 | CODING_STYLE: clarify that single-line if blocks should not be enclosed in {} | Lennart Poettering | |
2014-08-30 | Fix a few more typos | Ruben Kerkhof | |
2014-08-21 | CODING_STYLE: document that we don't break lines at 80ch | Lennart Poettering | |
2014-08-03 | Unify parse_argv style | Zbigniew Jędrzejewski-Szmek | |
getopt is usually good at printing out a nice error message when commandline options are invalid. It distinguishes between an unknown option and a known option with a missing arg. It is better to let it do its job and not use opterr=0 unless we actually want to suppress messages. So remove opterr=0 in the few places where it wasn't really useful. When an error in options is encountered, we should not print a lengthy help() and overwhelm the user, when we know precisely what is wrong with the commandline. In addition, since help() prints to stdout, it should not be used except when requested with -h or --help. Also, simplify things here and there. | |||
2014-06-28 | doc: use expanded forms for written style | Jan Engelhardt | |
2014-06-28 | doc: typographical improvements and choice of words | Jan Engelhardt | |
2014-06-28 | doc: grammatical corrections | Jan Engelhardt | |
2014-05-24 | Fix several small typos | Jonathan Boulle | |
2013-12-09 | extend CODING_STYLE document a bit | Lennart Poettering | |
2013-12-03 | trivial coding style clean ups | Thomas Hindoe Paaboel Andersen | |
- Add space between if/for and the opening parentheses - Place the opening brace on same line as the function (not for udev) From the CODING_STYLE Try to use this: void foo() { } instead of this: void foo() { } | |||
2013-03-08 | analyze: various cleanups | Lennart Poettering | |
Update systemd-analyze to follow the coding style of the other tools more closely. Also, update the CODING_STYLE to document this for future additions. Changes: - Always use usec_t for time units, so that we always use the same types everywhere, and format times the same way as everywhere else. - Add "static" to global variables - Make sure we can always distuingish OOM and other errors: ensure we always return useful error codes from all functions. - Always free unit_times array | |||
2013-01-29 | Clarify sentence | Tollef Fog Heen | |
2012-10-01 | Minor typo | Tollef Fog Heen | |
2012-10-01 | Be consistent about "." vs no "." at the end of lines" | Tollef Fog Heen | |
2011-02-28 | Spelling Corrections | Harald Hoyer | |
Just some lame spelling corrections with no functionality. | |||
2010-02-14 | CODING_STYLE: minor updates | Lennart Poettering | |
2009-11-18 | CODING_STYLE: add missing - | Lennart Poettering | |
2009-11-18 | initial commit | Lennart Poettering | |