Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
time, if not needed
On Thu, Nov 20, 2008 at 14:17, Karel Zak <kzak@redhat.com> wrote:
> I see the patch (volume_id_probe_filesystem()) and a few things come
> to mind:
>
> - shouldn't be the relevant parts (label, uuid, version, ...) of
> the "struct volume_id" zeroized when you found a signature and
> before you call the next probing function?
>
> - it seems as overkill to use two for()s and probe two times for all
> filesystems. What about to store the first result and re-use it?
>
> - .. or at least never use the second for() when the fist for() found
> nothing ;-)
|
|
|
|
|
|
We probe for all known filesystems to find conflicting signatures. If
we find multiple matching signatures and one of the detected filesystem
types claims that it can not co-exist with any other filesystem type,
we do not return a probing result.
We can not afford to mount a volume with the wrong filesystem code and
possibly corrupt it. Linux ssytems have the problem of dozens of possible
filesystem types, and volumes with left-over signatures from former
filesystem types. Invalid signature need to be removed from the volume
to make the filesystem detection successful.
We do not want to read that many bytes from probed floppies, skip volumes
smaller than a usual floppy disk.
|
|
Use calloc to request cleared memory instead.
Kernel and libc conspire to make this more efficient.
Also, replace one malloc() + strcpy() with strdup().
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
* enables GFS/GFS2 probing code (it's disabled now!)
* adds support for LABELs -- it seems that locktable name is usable as
a LABEL (at least according to libblkid).
* removes extra check of sb_header.mh_format -- nothing in kernel and
blkid checks this superblock entry. It seems that check GFS_MAGIC and
GFS_METATYPE_SB is enough.
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
|
|
|
|
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
Otherwise probe_all will run two times into a timout, one
for the raid, and one for the filesystem probe. Thanks to
Tore Anderson for the debugging.
|
|
|
|
Needed for mount(8) to lookup LABEL=* in /dev/disk/by-label/*. Characters
not suited for a filename will be escaped and the encoded LABEL=* string
is able to find the corresponding symlink.
|
|
|
|
|
|
|
|
|
|
In a future version of libvolume_id, struct volume_id will be
an opaque data type, which can't be accessed directly.
No interface has changed for now, until all known users are
converted not to access the structure directly.
|
|
|
|
|
|
Patch from Red Hat.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|