summaryrefslogtreecommitdiff
path: root/src/journal/sd-journal.c
AgeCommit message (Collapse)Author
2012-03-14journal: Don't hold pointers to journal while remappingMarti Raudsepp
Hi! I was trying out the journal and the journalctl utility sometimes crashed on me. After some debugging, I tracked it down to the fact that next_with_matches() holds the "c" object pointer through the journal_file_next_entry_for_data() call -- which apparently may re-map the journal file, invalidating the pointer. The attached patch fixes this crash for me, but being unfamiliar with the code, I don't know if I'm doing the right thing. This patch is also available from my github repository: git://github.com/intgr/systemd.git https://github.com/intgr/systemd Regards, Marti For the record, here's the original stack trace at the time of remapping: ret=0x7fff1d5cdec0) at src/journal/journal-file.c:330 ret=0x7fff1d5cdf28) at src/journal/journal-file.c:414 ret=0x7fff1d5ce0a0, offset=0x7fff1d5ce098) at src/journal/journal-file.c:1101 i=5705, ret=0x7fff1d5ce0a0, offset=0x7fff1d5ce098) at src/journal/journal-file.c:1147 p=6413608, data_offset=66600, direction=DIRECTION_DOWN, ret=0x7fff1d5ce0a0, offset=0x7fff1d5ce098) at src/journal/journal-file.c:1626 direction=DIRECTION_DOWN, ret=0x7fff1d5ce120, offset=0x7fff1d5ce128) at src/journal/sd-journal.c:533 direction=DIRECTION_DOWN, ret=0x7fff1d5ce170, offset=0x7fff1d5ce178) at src/journal/sd-journal.c:595 src/journal/sd-journal.c:651 From 9266fc6a58065a7c5dab67430fd78925e519dce9 Mon Sep 17 00:00:00 2001 From: Marti Raudsepp <marti@juffo.org> Date: Fri, 9 Mar 2012 16:23:00 +0200 Subject: [PATCH] journal: Don't hold pointers to journal while remapping This would cause a segfault otherwise.
2012-01-21journal: systemd v38 fails to build on big-endiansDan Horák
Hi, during the builds for Fedora/s390x I've found that systemd v38 fails to build on big-endian platforms. ... make[2]: Entering directory `/root/systemd' CC src/journal/libsystemd_journal_la-sd-journal.lo src/journal/sd-journal.c: In function 'init_location': src/journal/sd-journal.c:69:22: error: incompatible types when initializing type 'long unsigned int' using type 'sd_id128_t' src/journal/sd-journal.c:69:20: error: incompatible types when assigning to type 'sd_id128_t' from type 'long unsigned int' make[2]: *** [src/journal/libsystemd_journal_la-sd-journal.lo] Error 1 I see the problem in using le64toh() on the 16 bytes boot_id structure in init_location() Please see http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=544375 for a full build log and attachment for a proposed fix. With regards Dan
2012-01-11sd-journal: implement a number of non-implemented calls from the API for nowLennart Poettering
2012-01-04journal: beef up journal output of systemctl and journalctlLennart Poettering
2012-01-04journalctl: fix counting of -n parameterLennart Poettering
2012-01-04journal: fix reverse traversing of entriesLennart Poettering
2012-01-04journal: add missing error checkLennart Poettering
2012-01-04journal: don't mind too much if we can't find a monotonic timestampLennart Poettering
2012-01-04journal: add missing error checkLennart Poettering
2012-01-03journal: add _public_ to all sd-journal calls, and add parameter checksLennart Poettering
2011-12-29journald: flush /run to /var as soon as it becomes availableLennart Poettering
2011-12-27journal: fix typoLennart Poettering
2011-12-22journald: enforce some syntax restrictions on field names sent from the ↵Lennart Poettering
client side
2011-12-21journalctl: add json, export, short and verbose output modesLennart Poettering
2011-12-21journal: add inline compression support with XZLennart Poettering
2011-12-20journal: fix matchesLennart Poettering
2011-12-19journal: implement inotify-based live logging logicLennart Poettering
2011-12-17journal: enforce limits on open journal filesLennart Poettering
2011-11-08journal: implement multiple field matchesLennart Poettering
2011-10-15journal: automaticall reset location when the set of matches changesLennart Poettering
2011-10-15journal: implement seek to head/tailLennart Poettering
2011-10-15journal: unify code for up and for down traversalLennart Poettering
2011-10-15journal: properly implement matching with multiple matchesLennart Poettering
2011-10-14journal: if two entries match with everything but seqnums, they are still ↵Lennart Poettering
identical
2011-10-14journal: move field index from file into journal objectLennart Poettering
2011-10-14journal: when the same entry is in two files, skip over them in syncLennart Poettering
2011-10-14journal: synchronize seqnum across filesLennart Poettering
2011-10-14journal: fix field retrieval by nameLennart Poettering
2011-10-14journal: implement parallel file traversalLennart Poettering
2011-10-13journal: implementation rotationLennart Poettering
2011-10-08journal: implement parallel traversal in clientLennart Poettering
2011-10-07journal: split user logs into their own journal filesLennart Poettering
2011-10-07journal: replace linked list by hashmap when merging filesLennart Poettering
2011-10-07journal: store XOR combination of entry data object hashes to identify hash ↵Lennart Poettering
lines
2011-10-07journal: add preliminary incomplete implementationLennart Poettering
generated by cgit v1.2.3-54-g00ecf (git 2.45.2) at 2024-11-29 23:01:56 +0000