Age | Commit message (Collapse) | Author | |
---|---|---|---|
2014-08-11 | fix a couple of more lazy "return -1" | Lennart Poettering | |
Fix should strictly follow the rule to return negative errno-style error codes from functions, hence let's fix more "return -1"-style lazinesses. | |||
2014-03-18 | util: replace close_nointr_nofail() by a more useful safe_close() | Lennart Poettering | |
safe_close() automatically becomes a NOP when a negative fd is passed, and returns -1 unconditionally. This makes it easy to write lines like this: fd = safe_close(fd); Which will close an fd if it is open, and reset the fd variable correctly. By making use of this new scheme we can drop a > 200 lines of code that was required to test for non-negative fds or to reset the closed fd variable afterwards. | |||
2013-04-05 | Use initalization instead of explicit zeroing | Zbigniew Jędrzejewski-Szmek | |
Before, we would initialize many fields twice: first by filling the structure with zeros, and then a second time with the real values. We can let the compiler do the job for us, avoiding one copy. A downside of this patch is that text gets slightly bigger. This is because all zero() calls are effectively inlined: $ size build/.libs/systemd text data bss dec hex filename before 897737 107300 2560 1007597 f5fed build/.libs/systemd after 897873 107300 2560 1007733 f6075 build/.libs/systemd … actually less than 1‰. A few asserts that the parameter is not null had to be removed. I don't think this changes much, because first, it is quite unlikely for the assert to fail, and second, an immediate SEGV is almost as good as an assert. | |||
2012-04-13 | build-sys: add stub makefiles to all subdirs to ease development with emacs | Lennart Poettering | |
2012-04-12 | move all tools to subdirs | Kay Sievers | |