summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2013-06-02udev/udev-ctrl.c:udev_ctrl_new_from_fd() enable SO_PASSCREDHarald Hoyer
Avoid "sender uid=65534, message ignored" case, where no credentials can be read on the sender side. Seems, the server socket does not enable credential receiving fast enough, and the message from the client (without credential) sometimes is queued before the credential passing was active. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-06-02Use initalization instead of explicit zeroingZbigniew Jędrzejewski-Szmek
Before, we would initialize many fields twice: first by filling the structure with zeros, and then a second time with the real values. We can let the compiler do the job for us, avoiding one copy. A downside of this patch is that text gets slightly bigger. This is because all zero() calls are effectively inlined: $ size build/.libs/systemd text data bss dec hex filename before 897737 107300 2560 1007597 f5fed build/.libs/systemd after 897873 107300 2560 1007733 f6075 build/.libs/systemd … actually less than 1‰. A few asserts that the parameter is not null had to be removed. I don't think this changes much, because first, it is quite unlikely for the assert to fail, and second, an immediate SEGV is almost as good as an assert. NOTE by Basile: the above analysis is for all systemd. This commit is just a sliver of the commit for all of system and so we can't expect size to be the same. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-06-02udevadm: do not free node on successZbigniew Jędrzejewski-Szmek
A fix for ff03aed06a422.
2013-06-02udev-builtin-usb_id: avoid comparison of unsigned and ssize_tZbigniew Jędrzejewski-Szmek
For some reason this shows up on i686 only: src/udev/udev-builtin-usb_id.c:192:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
2013-06-02udevadm-hwdb: avoid leak in error pathZbigniew Jędrzejewski-Szmek
2013-06-02libudev: remove udev_monitor_new_from_socket() symbolMichael Biebl
This function was removed in v183, so drop it from the symbols versioning file.
2013-06-02libudev: Move -lrt to Libs.privateMichael Biebl
It's only needed for static linking. https://bugs.freedesktop.org/show_bug.cgi?id=63309 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-06-02Correct missing int to size_t changeAnthony G. Basile
This corrects a previously applied commit for upstream's acd42fae59096d84e78f1c17bfcc0d8f96486341 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-06-02libude: remove special handling of "device" link and legacy respecting codeKay Sievers
Remove special handling of device link by Sievers. Remove legacy respecting code by Basile. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-06-02libudev: implement udev_device_set_attribute_value()Hannes Reinecke
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-06-02licence: remove references to old FSF addressSami Kerola
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=57206 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-04-21src/udev/Makefile.am: do not fail if sym link already existsAnthony G. Basile
This fixes two issues: 1) The -r option does not exist for busybox and we do not need relative sym linking anyhow, and 2) if the sym link already exists, we want to overwrite it, hence -f. X-Eudev-Bug: 58 X-Eudev-Bug-URL: https://github.com/gentoo/eudev/issues/58 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-04-09build-sys: fix HAVE/ENABLE_FIRMWAREKay Sievers
This fixes: https://github.com/gentoo/eudev/issues/55 https://bugs.freedesktop.org/show_bug.cgi?id=62864 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-04-07src/udev/udev-event.c: restore code to allow rule generator to workAnthony G. Basile
This code was dropped while importing from upstream. It is needed to allow the legacy renaming of interfaces like eth* or wlan*. X-Eudev-Bug: 56 X-Eudev-Bug-URL: https://github.com/gentoo/eudev/issues/56 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-04-07src/udev/Makefile.am: fix symlink to udevadmAnthony G. Basile
The installation was overwriting udevadm when building with --sbindir=/usr/bin and ignoring $bindir. Both situations lead to a symlink which points to nowhere. Thanks TZ86. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-04-05adjust symbol versioning for libudevIan Stakenvicius
Libudev has a symbol version for 199 now, so the libudev_internal version (which is used to essentially hide symbols that are not part of the external API) needs to use 199 as its baseline instead of 196 Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
2013-04-04src/udev/udev-rules.c: fix bug introduced in our 601c4e8Anthony G. Basile
This error was introduced in our commit 601c4e8ce69338652b3c9178386cbc05de8bae8d when importing from upstream. The revert line works only in the context of all of upstream's commit 7850b3b83791ba0e2377ba40383c5abc258b839d Signed-off-by: Anthony G. Basile <blueness@gentoo.org> Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
2013-04-04Initial forward-port of rules.d inotify supportIan Stakenvicius
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-04-04Add support for legacy behaviour in udev_device_get_sysattr_value()Ian Stakenvicius
Wraps the changes made in systemd commits 5ae18ddc and 53726349 with a #if's on LIBUDEV_LEGACY_VERSION so that old behaviour can be chosen at build-time if users find it necessary to support legacy software dependent on the original behaviour Original Authors: Kay Sievers Signed-off-by: Ian Stakenvicius <axs@gentoo.org> Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-04-04Use LN_S instead of directly calling ln -sIan Stakenvicius
configure.ac has AC_PROG_LN_S already so we should use it. upstream did this in commit 783162123dbac43d5b7a3fab9d4f11dcf86d06e1 Signed-off-by: Ian Stakenvicius <axs@gentoo.org> Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-04-04Move udevadm from sbin to binIan Stakenvicius
Follow upstream commit f432bb914499e2c28b43f592bb273f0a8664f352 but refactor the patch for eudev build system. Provide a compatibility symlink in sbindir for anything that hard-codes the path to udevadm Signed-off-by: Ian Stakenvicius <axs@gentoo.org> Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-04-03Respect the MIT licenseklondike
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
2013-04-03Fix buffer overflowklondike
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
2013-04-03Clean up the string functionsklondike
Avoid two evaluations of src in util_strpcpy clean the code in the ones where the pointer passed is not modified and merge the main loop of util_strpcpyl and util_strscpyl into util_strpcpyv. Also make strpcpy more compact by removing some unnecessary arithmetic. Cleanup util_strpcpyv by shortcutting size == 0 case Do some style fixups Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
2013-04-02udev: updateAnthony G. Basile
This updates the daemon codebase to upstream. Authors: Zbigniew Jędrzejewski-Szmek Lennart Poettering Václav Pavlín Kay Sievers Harald Hoyer Rob Clark Zeeshan Ali (Khattak) See http://cgit.freedesktop.org/systemd/systemd/log/src/udev Ian is signing off but has some concerns on a few of the changes that he may fix in future commits. Signed-off-by: Anthony G. Basile <blueness@gentoo.org> Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
2013-04-02udev: extern on functions is pointlessLennart Poettering
Signed-off-by: Anthony G. Basile <blueness@gentoo.org> Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
2013-04-02accelerometer: remove dead if and modernizeZbigniew Jędrzejewski-Szmek
Based on a coverity warning. Signed-off-by: Anthony G. Basile <blueness@gentoo.org> Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
2013-04-02libudev: update to 199Ian Stakenvicius
This updates the library codebase to upstream version 199. (originally merged by Anthony G. Basile <blueness@gentoo.org>) Upstream commits 5ae18ddc0d and 53726349e1 are not applied, code will be excluded via #if...#endif in a future commit Authors: Kay Sievers Thomas Hindoe Paaboel Andersen Hannes Reinecke Jan Engelhardt See http://cgit.freedesktop.org/systemd/systemd/log/src/libudev Signed-off-by: Anthony G. Basile <blueness@gentoo.org> Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
2013-04-02udev: ifdef all firmware special handlingKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org> Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
2013-04-02udev: make firmware loading optional and disable by defaultTom Gundersen
Distros that whish to support old kernels should set --with-firmware-dirs="/usr/lib/firmware/updates:/usr/lib/firmware" to retain the old behaviour. Signed-off-by: Anthony G. Basile <blueness@gentoo.org> Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
2013-04-02Make two functions staticZbigniew Jędrzejewski-Szmek
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
2013-03-14udev: fix segfault with android rndisRob Clark
The android gadget driver for network tethering over rndis somehow has a parent device with a null subsystem. Probably this is bug in android driver, but it is easy enough to make systemd/udev behave gracefully and not segfault. And this will help for making linux distros with systemd (like fedora) work on android devices. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-03-14udev: usb_id: parse only 'size' bytes of the 'descriptors' bufferKay Sievers
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-03-14udev: usb_id - ignore non-ASCII serial numbersKay Sievers
On Thu, Feb 7, 2013 at 3:52 PM, Robert Milasan <rmilasan@suse.com> wrote: > Hi, seems that using some strange usb devices with really bogus serial > numbers usb_id creates links with junk strings in it: > > /dev/disk/by-id/usb-TSSTcorp_BDDVDW_SE-506AB_㡒䍌䜶䉗ぁㄴ㌴†ँ-0:0 > > Initially was believed that usb_id is to blame, then the kernel, but it > turns out that really the usb cd/dvd drive has this bogus serial number: > > output from dmesg: > [ 538.200160] usb 1-2: new high-speed USB device number 5 using > ehci_hcd [ 538.335067] usb 1-2: New USB device found, idVendor=0e8d, > idProduct=1956 [ 538.335080] usb 1-2: New USB device strings: Mfr=1, > Product=2, SerialNumber=3 [ 538.335089] usb 1-2: Product: MT1956 > [ 538.335097] usb 1-2: Manufacturer: MediaTek Inc > [ 538.335105] usb 1-2: SerialNumber: > \xffffffe3\xffffffa1\xffffff92\xffffffe4\xffffff8d\xffffff8c ... > [ 538.337540] scsi6 : usb-storage 1-2:1.0 [ 539.341385] scsi 6:0:0:0: > CD-ROM TSSTcorp BDDVDW SE-506AB TS00 PQ: 0 ANSI: 0 > [ 539.354240] sr0: scsi3-mmc drive: 0x/24x writer dvd-ram cd/rw > xa/form2 cdda tray [ 539.354777] sr 6:0:0:0: Attached scsi CD-ROM sr0 > [ 539.355122] sr 6:0:0:0: Attached scsi generic sg2 type 5 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-03-14udev: Fix device matching in the accelerometerBastien Nocera
As we were searching by ID_PATH, it would have been possible for us to find a sibling device instead of the device we were looking for. This fixes device matching on the WeTab with the upstream kernel, as it was trying to use the "Asus Laptop extra buttons" device instead of the accelerometer. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-03-14Fix whitespace in various filesAnthony G. Basile
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-03-14src/udev/udev-builtin-blkid.c: expose new ISO9660 properties from libblkidZeeshan Ali (Khattak)
This is upstream commit ddb5bee15a6ad71e5b596c035c1ee4dc04d5fd2e Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-03-14cdrom_id: add data track count for bad virtual drive implementationsHarald Hoyer
/# /lib/udev/cdrom_id --debug /dev/sr0 probing: '/dev/sr0' INQUIRY: [AMI ][Virtual CDROM ][1.00] GET CONFIGURATION failed with SK=5h/ASC=20h/ACQ=00h drive is pre-MMC2 and does not support 46h get configuration command trying to work around the problem READ DISC INFORMATION failed with SK=5h/ASC=20h/ACQ=00h no current profile, but disc is present; assuming CD-ROM READ TOC: len: 12, start track: 1, end track: 1 last track 1 starts at block 0 READ DISC INFORMATION failed with SK=5h/ASC=20h/ACQ=00h ID_CDROM=1 ID_CDROM_MEDIA=1 ID_CDROM_MEDIA_CD=1 What is missing here is ID_CDROM_MEDIA_TRACK_COUNT_DATA to trigger blkid in /lib/udev/rules.d/60-persistent-storage.rules KERNEL=="sr*", ENV{DISK_EJECT_REQUEST}!="?*", ENV{ID_CDROM_MEDIA_TRACK_COUNT_DATA}=="?*", ENV{ID_CDROM_MEDIA_SESSION_LAST_OFFSET}=="", \ IMPORT{builtin}="blkid --noraid"
2013-03-14src/udev/udev-builtin-net_id.c: handle bcma busesKay Sievers
This is upstream commits: 984c4348ff14d29c526d3d372daa82e278eeb5b4 f4ddacbd4de0f159ec598f8ad690466a84787ec5 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-03-14udev: path_id - clarify comment about the kernel ATA naming problemKay Sievers
2013-03-14src/udev/udevadm-hwdb.c: fix helpAnthony G. Basile
This follows upstream commit e32a4e1ef4c61561b08f50f73f82587bdc946b40 Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-02-07udevadm: support updating hwdb from an offset rootLuca Barbato
Introduce `--root` option to make users run udevadm on rootfs not mounted as / Ease the life of distribution packagers.
2013-01-28Make blkid optionalIan Stakenvicius
Embedded systems may not want to include util-linux when they do not intend to use blkid functionality Modified from original author's commit to not install 60-persistent-storage.rules if blkid is disabled systemd commit f553b3b1074151200187df916427a1468186435e Original author: Anders Olofsson <Anders.Olofsson@axis.com> Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-01-28Set device node permissions only at "add" eventsIan Stakenvicius
New behavioural change -- has potential to fix bugs..? systemd commit 48a849ee17fb25e0001bfcc0f28a4aa633d016a1 Author: Kay Sievers <kay@vrfy.org> Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-01-28Cleanup of spacing to help with diffsIan Stakenvicius
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-01-28Add missing ':' to getopt_long 'e'Ian Stakenvicius
Parameter -e is set without additional argument in getopt and this leads to segfault when calling 'udevd -e'. systemd commit 5bbbe461fd4d133eac49f41210e2fd4846f577d8 Author: Lukas Nykryn <lnykryn@redhat.com> Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-01-28Handle scsi Hyper-V devices properlyIan Stakenvicius
Hyper-V has an abstract bus, which gets renumbered on guest startup. So instead of the bus numbers we should be using the device GUIDs, which can be retrieved from the 'device_id' sysfs attribute. systemd commit a24d03b8ee2ca62cd1273e27cf4e79ddcc0fbb1c Author: Hannes Reinecke <hare@suse.de> Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-01-28Port new net_id capabilities from systemd-udev-197Ian Stakenvicius
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-01-28Honor DEVUID, DEVGID in addition to DEVMODEIan Stakenvicius
New behaviour in udev-197 systemd commit 1edefa4f1d7bae6cc19aa4a97238400c5a04f7a4 Author: Kay Sievers <kay@vrfy.org> Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
2013-01-28Fix missing endian wrappersIan Stakenvicius
https://bugs.freedesktop.org/show_bug.cgi?id=58067 systemd commit f4443fa5976eca51661947dd4df60847213f27fa Signed-off-by: Anthony G. Basile <blueness@gentoo.org>