Age | Commit message (Collapse) | Author | |
---|---|---|---|
2015-03-09 | udev: simplify event_queue_update() and add debug logging | Tom Gundersen | |
This essentially replaces open("/run/udev/queue", O_WRONLY|O_CREAT|O_CLOEXEC|O_TRUNC|O_NOFOLLOW, 0444) with open("/run/udev/queue", O_WRONLY|O_CREAT|O_CLOEXEC|O_NOCTTY, 0644), which is ok for our purposes. | |||
2015-03-09 | efivars: use greedy_realloc | Zbigniew Jędrzejewski-Szmek | |
2015-03-09 | efivars: use more _cleanup_ | Zbigniew Jędrzejewski-Szmek | |
Also rename r to buf, since r is customarily reserved for the return value. | |||
2015-03-09 | efivars: do binary and before converting to bool | Zbigniew Jędrzejewski-Szmek | |
I'm pretty sure that this is what was meant here. | |||
2015-03-09 | efivars: rename last remaining err to r | Zbigniew Jędrzejewski-Szmek | |
2015-03-09 | efivars: modernization | Zbigniew Jędrzejewski-Szmek | |
Fix return value if unlink fails. | |||
2015-03-09 | boot/efi: do not assign variable twice | Zbigniew Jędrzejewski-Szmek | |
If the highlighted line did not move outside of the visible region, it should not be necessary to update idx_last. CID #1287137, #1287138. | |||
2015-03-09 | machinectl: remove unused variables | Thomas Hindoe Paaboel Andersen | |
2015-03-09 | fsck: modernize error handling | Lennart Poettering | |
2015-03-09 | fsck: use _cleanup_close_pair_ where appropriate | Lennart Poettering | |
2015-03-09 | fsckd: make sure we free the connection event source before we close the ↵ | Lennart Poettering | |
connection fd | |||
2015-03-09 | fsckd: don't allow unbounded numbers of clients | Lennart Poettering | |
2015-03-09 | fsckd: free client event source before we close its fd | Lennart Poettering | |
2015-03-09 | fsck: rename functions to reflect some object orientation | Lennart Poettering | |
Let's clean up the function naming scheme and put the object they operate on first in the name, the way OO programming usually does it. Also, let's make sure can properly destroy half-initialized Manager objects. | |||
2015-03-09 | fsck: don't read invalid data | Lennart Poettering | |
2015-03-09 | fsckd: internaly check if a client already was cancelled | Lennart Poettering | |
2015-03-09 | fsck: simplify client destruction logic | Lennart Poettering | |
2015-03-09 | fsckd: rework plymouth connection management | Lennart Poettering | |
- the even source should not be freed before the fd for it is closed - read() returns an ssize_t and we need to handle it as such - properly handle errors from read() - reuse on_plymouth_disconnect() whenever we disconnect from plymouth, and rename it plymouth_disconnect hence() | |||
2015-03-09 | fscd: fix error handling | Lennart Poettering | |
2015-03-09 | fsck: no need for a temporary variable | Lennart Poettering | |
2015-03-09 | fsckd: fix error handling when sending cancel request to fsck client | Lennart Poettering | |
2015-03-09 | fsck: unify exit path for connect_plymouth() | Lennart Poettering | |
2015-03-09 | fsck: use only a single exit code ternary operator | Lennart Poettering | |
2015-03-09 | fsck: simplification | Lennart Poettering | |
2015-03-09 | fsckd: the error code is actually returned in 'fd' | Lennart Poettering | |
Also, we don't use {} for single-line if-blocks. | |||
2015-03-09 | fsckd: simplify code a bit | Lennart Poettering | |
2015-03-09 | fsckd: make use of safe_close()'s return value | Lennart Poettering | |
2015-03-09 | build-sys: add one more Makefile symlink | Lennart Poettering | |
2015-03-09 | importd: add API for exporting container/VM images | Lennart Poettering | |
Also, expose it in machinectl. | |||
2015-03-09 | udev: use inttypes.h types wherever appropriate | Lennart Poettering | |
2015-03-09 | tree-wide: use _packed_ macro instead of raw gcc __attribute__ | Lennart Poettering | |
2015-03-09 | udevd: close race in udev settle | Tom Gundersen | |
The udev-settle guarantees that udevd is no longer processing any of the events casued by udev-trigger. The way this works is that it sends a synchronous PING to udevd after udev-trigger has ran, and when that returns it knows that udevd has started processing the events from udev-trigger. udev-settle will then wait for the event queue to empty before returning. However, there was a race here, as we would only update the /run state at the beginning of the event loop, before reading out new events and before processing the ping. That means that if the first uevent arrived in the same event-loop iteration as the PING, we would return the ping before updating the queue state in /run (which would happen on the next iteration). The race window here is tiny (as the /run state would probably get updated before udev-settle got a chance to read /run), but still a possibility. Fix the problem by updating the /run state as the last step before returning the PING. We must still update it at the beginning of the loop as well, otherwise we risk being stuck in poll() with a stale state in /run. Reported-by: Daniel Drake <drake@endlessm.com> | |||
2015-03-09 | missing.h: add NDA_* | Michael Olbrich | |
This is necessary to build with older kernel headers. NDA_VLAN was introduced in v3.9 and NDA_PORT, NDA_VNI and NDA_IFINDEX in v3.10 | |||
2015-03-09 | Fix typos | Torstein Husebø | |
2015-03-08 | sd-journal: return error when we cannot open a file | Zbigniew Jędrzejewski-Szmek | |
Lack of this caused journalctl not to display a hint about missing groups properly when the user lacks permissions. | |||
2015-03-08 | journalctl: update hint now that we set ACL everywhere | Zbigniew Jędrzejewski-Szmek | |
2015-03-07 | bus: fix leak in error path | Zbigniew Jędrzejewski-Szmek | |
CID #1271349. | |||
2015-03-07 | systemctl: remove dead check | Zbigniew Jędrzejewski-Szmek | |
r could never be less than zero. CID #1271350. | |||
2015-03-07 | core/load-fragment: safe_close() protects errno | Zbigniew Jędrzejewski-Szmek | |
2015-03-07 | libsystemd-terminal: use at most LOG_ERR for XKB errors | Zbigniew Jędrzejewski-Szmek | |
XKB errors aren't *that* important. Coverity complained that the same action is taken in multiple branches, which is semi-valid, so is fixed too (CID #1256582). | |||
2015-03-07 | login: fix copy-pasto in error path | Zbigniew Jędrzejewski-Szmek | |
CID #1256583. | |||
2015-03-07 | nspawn: fix use-after-free and leak in error paths | Zbigniew Jędrzejewski-Szmek | |
CID #1257765. | |||
2015-03-07 | core/dbus-manager: remove dead check | Zbigniew Jędrzejewski-Szmek | |
CID #1257766. | |||
2015-03-07 | bus-util: remove stray errno assignment | Zbigniew Jędrzejewski-Szmek | |
2015-03-07 | networkctl: avoid leak if a field was specified twice | Zbigniew Jędrzejewski-Szmek | |
The input data would have to be borked, so this is unlikely to happen, but since we have a nice helper function to do it properly... why not? CID #1261390. | |||
2015-03-07 | machine: do not rely on asprintf setting arg on error | Zbigniew Jędrzejewski-Szmek | |
Strictly speaking, the output variable is undefined if asprintf fails. We use the return value not the arg everywhere, and should we do here. | |||
2015-03-07 | v4l_id: use standard option parsing loop | Zbigniew Jędrzejewski-Szmek | |
Not terribly important, but the loop wasn't an actual loop, making coverity unhappy. CID #1261725. | |||
2015-03-07 | shared/machine-pool: remove unnecessary check | Zbigniew Jędrzejewski-Szmek | |
CID #128739. | |||
2015-03-07 | sysusers: do not reject users with already present /etc/shadow entries | Ivan Shapovalov | |
This is needed to interoperate firstboot and sysusers. The former one is started first, and it writes only /etc/shadow when it is told to set the root password. It's better to relax checks here than to duplicate functionality in firstboot. | |||
2015-03-07 | firstboot: set all spwd fields to -1 for consistency with sysusers | Ivan Shapovalov | |