summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2013-02-11efi: fix returned length of efi_get_variable()Lennart Poettering
2013-02-11util: rework load_env_file()Lennart Poettering
Inner library calls should not invoke log_oom(), that's something for main programs, not library calls. Don't read through uninitialized memory if a file ends in a continuation line. Add comments for the non-obvious bits. Don't choke on comment lines that are continuation lines. Simplify some things.
2013-02-11path-util: fix memory leakLennart Poettering
2013-02-11util: introduce FOREACH_LINE for iterating through filesLennart Poettering
2013-02-11test-env-replace: better user assert_se() everywhereLennart Poettering
For test tools it's better to use assert_se() rather than assert(), since the former is not optimized away, even if -DNDEBUG is used. That means the test program now retains its usefulness even if -DNDEBUG is used. This also adds in some OOM checks, to be extra anal...
2013-02-11env: considerably beef up environment cleaning logicLennart Poettering
Now, actually check if the environment variable names and values used are valid, before accepting them. With this in place are at some places more rigid than POSIX, and less rigid at others. For example, this code allows lower-case environment variables (which POSIX suggests not to use), but it will not allow non-UTF8 variable values. All in all this should be a good middle ground of what to allow and what not to allow as environment variables. (This also splits out all environment related calls into env-util.[ch])
2013-02-10tests: add tests of strxcpyxThomas Hindoe Paaboel Andersen
also fix a bad indentation in test-strbug.c
2013-02-09vconsole-setup: don't set the kbd mode to unicode if is is currently in ↵Lennart Poettering
raw/off mode Let's not confuse X11
2013-02-09shutdown: issue a sync() as soon as shutdown.target is queuedLennart Poettering
2013-02-09tests: add test of strbufThomas Hindoe Paaboel Andersen
2013-02-09logind: rename "seat-master" tag to "master-of-seat"Lennart Poettering
We currently enforce that seats are to be named in the form of "seatXXX", i.e. need to begin with the 4 characters "seat". Thus, "seat-master" would qualify as a seat name. As seat names are frequently used as tags on devices, the "seat-master" tag might hence confuse logind if the user decides to name a seat "seat-master". Hence, avoid any ambuigity: let's rename the "seat-master" tag to "master-of-seat".
2013-02-08udev: udevadm hwdb - add --root=Kay Sievers
https://bugs.freedesktop.org/show_bug.cgi?id=60398
2013-02-08shared: conf-files - use root parameter and convert to auto-cleanupKay Sievers
2013-02-08shared: conf-files - add root parameterKay Sievers
2013-02-07systemd: fix uninitialized memory access in selinuxZbigniew Jędrzejewski-Szmek
==6129== Syscall param socketcall.getsockopt(optlen) points to uninitialised byte(s) ==6129== at 0x312D0F325A: getsockopt (syscall-template.S:81) ==6129== by 0x4615E6: get_audit_data (selinux-access.c:268) ==6129== by 0x461A81: selinux_access_check (selinux-access.c:394) ==6129== by 0x453B23: bus_manager_message_handler (dbus-manager.c:1395) ==6129== by 0x313581D9C4: _dbus_object_tree_dispatch_and_unlock (dbus-object-tree.c:862) ==6129== by 0x313580FC1F: dbus_connection_dispatch (dbus-connection.c:4672) ==6129== by 0x44CD4C: bus_dispatch (dbus.c:528) ==6129== by 0x41292F: manager_loop (manager.c:1573) ==6129== by 0x40CD8E: main (main.c:1735) ==6129== Address 0x7fefff2c0 is on thread 1's stack
2013-02-08tests: add more testsThomas Hindoe Paaboel Andersen
Adds tests of: strv_env_delete strv_env_unset strv_env_set
2013-02-07udev: remove HWDB_BINKay Sievers
2013-02-07test-env-replace: assert results instead of printing themThomas Hindoe Paaboel Andersen
Also code cleanup and split into functions in preparation for more tests to come.
2013-02-07coredump: make use of the cleanup macrosMirco Tischler
2013-02-07logs-show: show messages for all unit types in systemctl statusMirco Tischler
I can't find a reason why we shouldn't try to output messages for other unit types than .service, .socket, .mount and .swap as well. It's probably a leftover from before we started logging UNIT= from inside PID 1.
2013-02-07journal: log user units for coredumps and show them in systemctl statusMirco Tischler
2013-02-07nss-myhostname: copy first result to preallocated bufferEelco Dolstra
Fixes a segfault in nscd when using nss-myhostname. Nscd expects that an NSS module's gethostbyname4_r function returns its first result in the pre-allocated gaih_addrtuple denoted by **pat. (See nscd/aicache.c in the Glibc sources.) However, nss-myhostname doesn't fill in **pat but allocates the first result in ‘buffer’, then sets *pat. So nscd crashes (e.g. when running ‘getent ahosts my-machine’). Hard to tell if this is a bug in nscd, since there doesn't seem to be a proper API spec for gethostbyname4_r. But in any case, this patch fixes the crash by copying the first result to **pat.
2013-02-06systemd: raise level of message about lookup pathsZbigniew Jędrzejewski-Szmek
This can be pretty important for the user, and is not trivial to figure out in all cases. Also show failing path in error messages.
2013-02-06shared: remove now unused functionZbigniew Jędrzejewski-Szmek
2013-02-06systemd: do not remove empty paths from unit lookup pathZbigniew Jędrzejewski-Szmek
The ability to start a new unit with 'systemctl start ...' should not depend on whether there are other units in the directory. Previously, an additional 'systemctl daemon-reload' would be necessary to tell systemd to update the list of unit lookup paths.
2013-02-06tests: skip tests if manager cannot be createdZbigniew Jędrzejewski-Szmek
When running without a user session, tests fail.
2013-02-07tests: move strv_parse_nulstr to test-strv, and actually test itThomas Hindoe Paaboel Andersen
The test was originally added with this commit message: "ask-password: supported plymouth cached passwords"
2013-02-07strv: add strv_printThomas Hindoe Paaboel Andersen
Clearer, and spares the temp variable.
2013-02-06tests: run manager in session modeZbigniew Jędrzejewski-Szmek
False positives pop up otherwise. FAIL: test-unit-name (exit: 134) ================================ Failed to open /dev/tty0: Permission denied Failed to create root cgroup hierarchy: Permission denied Assertion 'manager_new(SYSTEMD_SYSTEM, &m) == 0' failed at src/test/test-unit-name.c:125, function test_unit_printf(). Aborting.
2013-02-06test: add a few tests and tidy upThomas Hindoe Paaboel Andersen
adds test of: strv_find strv_find_prefix strv_overlap strv_sort streq_ptr first_word Splits tests of util.c into own file to avoid clutter as we add more. Removed a few prints and uses _cleanup_free_ to make the tests more focused.
2013-01-31cryptsetup: accept both "read-only" and "readonly" spellingsMichal Schmidt
Mukund Sivaraman pointed out that cryptsetup(5) mentions the "read-only" option, while the code understands "readonly". We could just fix the manpage, but for consistency in naming of multi-word options it would be prettier to have "read-only". So let's accept both spellings. BZ: https://bugzilla.redhat.com/show_bug.cgi?id=903463
2013-01-30test-strv.c: test strv_join addedDaniel Buch
2013-01-30test-strv.c: Split tests into seperate functionsDaniel Buch
test-strv.c: Leaves main clean for additional tests
2013-01-30systemctl: Fix wrong assertion testMauro Dreissig
2013-01-29tests: add test for unit name printingZbigniew Jędrzejewski-Szmek
2013-01-29tests: compress unit name tests and add more assertsZbigniew Jędrzejewski-Szmek
2013-01-29tests: add test for install_full_printf()Zbigniew Jędrzejewski-Szmek
2013-01-29install: allow %u an and %U specifiers in WantedBy/RequiredBy/AliasZbigniew Jędrzejewski-Szmek
2013-01-29install: allow specifiers in WantedBy/RequiredBy/AliasZbigniew Jędrzejewski-Szmek
This allows one templated unit to refer to another templated unit at installation time. Examples: > grep WantedBy ~/.config/systemd/user/mpop@.timer WantedBy=services@%i.target > srv disable mpop@iit.timer rm '/home/alxchk/.config/systemd/user/services@iit.target.wants/mpop@iit.timer' > srv enable mpop@iit.timer ln -s '/home/alxchk/.config/systemd/user/mpop@.timer' '/home/alxchk/.config/systemd/user/services@iit.target.wants/mpop@iit.timer' Based-on-patch-by: Oleksii Shevchuk <alxchk@gmail.com>
2013-01-29core: fix %U when no User= usedZbigniew Jędrzejewski-Szmek
When the username was not explicitly specified, both %U and %u would print the username. Make %U always print UID.
2013-01-29Move generic specifier functions to sharedZbigniew Jędrzejewski-Szmek
No functional change. This makes it possible to use them in install.c.
2013-01-29install: automatic cleanup using local cleanup functionsZbigniew Jędrzejewski-Szmek
2013-01-29install: use automatic cleanup in find_symlinks_fd()Zbigniew Jędrzejewski-Szmek
2013-01-29shared: introduce _cleanup_set_free_free_Zbigniew Jędrzejewski-Szmek
2013-01-28journalctl: allow --lines=0 i.e. only newZbigniew Jędrzejewski-Szmek
Makes it easier to watch just for new entries. Once scenario is where the user starts 'journalctl -qfn0' to watch for changes during some operation.
2013-01-28keymap: Add HP HDX 9494NRMartin Pitt
Add touchpad and www keys. https://bugzilla.redhat.com/show_bug.cgi?id=757928
2013-01-28keymap: Add support for the brower hotkey on the HP ProBookAyan George
https://bugs.launchpad.net/bugs/1105191
2013-01-27logind: add MESSAGE_IDs to interesting eventsZbigniew Jędrzejewski-Szmek
2013-01-27udev: set default rules permissions only at "add" eventsKay Sievers
2013-01-26core: unify kill code of mount, service, socket, swap unitsLennart Poettering